From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <hsweeten@visionengravers.com>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups
Date: Thu, 3 Jul 2014 10:39:08 +0100 [thread overview]
Message-ID: <53B524BC.6040301@mev.co.uk> (raw)
In-Reply-To: <1404353739-28607-1-git-send-email-chase.southwood@gmail.com>
On 2014-07-03 03:15, Chase Southwood wrote:
> This patchset moves a misplaced include to the proper file, swaps out an overly
> aggressive placement of apci1564_reset(), and cleans up apci1564_interrupt().
>
> Chase Southwood (3):
> staging: comedi: addi_apci_1564: move addi_watchdog.h include to
> addi_apci_1564.c
> staging: comedi: addi_apci_1564: fix use of apci1564_reset() to
> disable DI interrupts
> staging: comedi: addi_apci_1564: clean up apci1564_interrupt()
>
> .../comedi/drivers/addi-data/hwdrv_apci1564.c | 2 -
> drivers/staging/comedi/drivers/addi_apci_1564.c | 139 +++++----------------
> 2 files changed, 32 insertions(+), 109 deletions(-)
>
Looks good! You didn't list the v2 changes though. Maybe you could
summarize them here?
Reviewed-by: Ian Abbott <abbotti@mev.co.uk.>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-07-03 9:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-28 4:47 [PATCH " Chase Southwood
2014-06-28 4:48 ` [PATCH 1/3] staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c Chase Southwood
2014-06-28 4:49 ` [PATCH 2/3] staging: comedi: addi_apci_1564: fix use of apci1564_reset() to disable DI interrupts Chase Southwood
2014-06-28 4:50 ` [PATCH 3/3] staging: comedi: addi_apci_1564: clean up apci1564_interrupt() Chase Southwood
2014-06-30 10:25 ` [PATCH 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups Ian Abbott
2014-07-02 2:06 ` Chase Southwood
2014-07-03 2:15 ` [PATCH v2 " Chase Southwood
2014-07-03 2:16 ` [PATCH v2 1/3] staging: comedi: addi_apci_1564: move addi_watchdog.h include to addi_apci_1564.c Chase Southwood
2014-07-03 2:17 ` [PATCH v2 2/3] staging: comedi: addi_apci_1564: fix use of apci1564_reset() to disable DI interrupts Chase Southwood
2014-07-03 2:17 ` [PATCH v2 3/3] staging: comedi: addi_apci_1564: clean up apci1564_interrupt() Chase Southwood
2014-07-03 9:39 ` Ian Abbott [this message]
2014-07-04 2:50 ` [PATCH v2 0/3] staging: comedi: addi_apci_1564: miscellaneous fixes and cleanups Chase Southwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B524BC.6040301@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome