mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@suse.com>
To: "Andy Lutomirski" <luto@amacapital.net>
Cc: "Ingo Molnar" <mingo@elte.hu>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] ix86: fix vDSO build
Date: Thu, 03 Jul 2014 16:44:58 +0100	[thread overview]
Message-ID: <53B5969A0200007800020613@mail.emea.novell.com> (raw)
In-Reply-To: <CALCETrW2+jYz6NXaReTsEu4pN9G-pAkF8q7p+wP3-MPruy=DsA@mail.gmail.com>

>>> On 03.07.14 at 17:34, <luto@amacapital.net> wrote:
> On Thu, Jul 3, 2014 at 7:35 AM, Jan Beulich <JBeulich@suse.com> wrote:
>> Relying on static functions used just once to get inlined (and
>> subsequently have dead code paths eliminated) is wrong: Compilers are
>> free to decide whether they do this, regardless of optimization level.
>> With this not happening for vdso_addr() (observed with gcc 4.1.x), an
>> unresolved reference to align_vdso_addr() causes the build to fail.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Cc: Andy Lutomirski <luto@amacapital.net>
> 
> Acked-by: Andy Lutomirski <luto@amacapital.net>

Thanks (also for the other one).

> Any chance you could send a dump of the symbol and relocation tables
> of a .so.dbg with this problem?  I'm curious why checkundef.sh never
> caught it.

vma.o is part of the kernel, not the .so.

Jan


  reply	other threads:[~2014-07-03 15:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03 14:35 Jan Beulich
2014-07-03 15:34 ` Andy Lutomirski
2014-07-03 15:44   ` Jan Beulich [this message]
2014-07-03 15:51     ` Andy Lutomirski
2014-07-03 23:10 ` Boris Ostrovsky
2014-07-09 23:30 ` Andrew Morton
2014-07-10 22:58 ` H. Peter Anvin
2014-07-23  8:07   ` Jan Beulich
2014-07-10 23:45 ` [tip:x86/urgent] x86-32, vdso: Fix vDSO build error due to missing align_vdso_addr() tip-bot for Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53B5969A0200007800020613@mail.emea.novell.com \
    --to=jbeulich@suse.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®