From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756856AbaGNSXZ (ORCPT ); Mon, 14 Jul 2014 14:23:25 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38441 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751602AbaGNSXS (ORCPT ); Mon, 14 Jul 2014 14:23:18 -0400 Message-ID: <53C42011.5070708@suse.de> Date: Mon, 14 Jul 2014 20:23:13 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Olof Johansson , Michal Simek CC: Andreas Olofsson , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King Subject: Re: [PATCH 1/1] ARM: dts: zynq: Add Parallella device tree References: <1404075022-28745-1-git-send-email-afaerber@suse.de> <1404075022-28745-2-git-send-email-afaerber@suse.de> <61d660b7-17a9-4817-ba34-40a5c1674d28@BY2FFO11FD032.protection.gbl> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 14.07.2014 20:12, schrieb Olof Johansson: > On Tue, Jul 8, 2014 at 4:18 AM, Michal Simek wrote: >> On 06/30/2014 07:15 AM, Olof Johansson wrote: >>> Hi, >>> >>> On Sun, Jun 29, 2014 at 1:50 PM, Andreas Färber wrote: >>>> This allows to boot the Adapteva Parallella board to serial console. >>>> >>>> Cc: Andreas Olofsson >>>> Signed-off-by: Andreas Färber >>> >>> Nice and clean DTS, just a couple of comments below. >>> >>>> diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts >>>> new file mode 100644 >>>> index 0000000..98df66c >>>> --- /dev/null >>>> +++ b/arch/arm/boot/dts/zynq-parallella.dts >>>> @@ -0,0 +1,63 @@ >>>> +/* >>>> + * Copyright (c) 2014 SUSE LINUX Products GmbH >>>> + * >>>> + * Derived from zynq-zed.dts: >>>> + * >>>> + * Copyright (C) 2011 Xilinx >>>> + * Copyright (C) 2012 National Instruments Corp. >>>> + * Copyright (C) 2013 Xilinx >>>> + * >>>> + * This software is licensed under the terms of the GNU General Public >>>> + * License version 2, as published by the Free Software Foundation, and >>>> + * may be copied, distributed, and modified under those terms. >>>> + * >>>> + * This program is distributed in the hope that it will be useful, >>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >>>> + * GNU General Public License for more details. >>>> + */ >>>> +/dts-v1/; >>>> +/include/ "zynq-7000.dtsi" >>>> + >>>> +/ { >>>> + model = "Parallella Board"; > > You might want to have this say "Adapteva Parallella Board" instead > (just noticed). > >>>> + compatible = "xlnx,zynq-7000"; >>> >>> This should have a more specific compatible as the first one. Probably >>> something like: >>> compatible = "adapteva,parallella", "xlnx,zynq-7000"; >> >> We were using these compatible properties but later there is no reason >> to create them because they will be unused. >> It is easy to add it when you need it which is not this case. > > No, please add it from day one, otherwise everybody needs to update > their device tree, some will miss doing it, etc, etc. It's a simple > and trivial thing to do, and no reason to leave it o ut. OK, I have that prepared already, including the appropriate documentation. >>>> + >>>> + memory { >>>> + device_type = "memory"; >>>> + reg = <0 0x20000000>; >>> >>> Does the bootloader update this entry, or is it truly static? If it's >>> updated then it's become recent habit to leave the memory size empty >>> in the static file. >> >> Depends on your bootloader. I think it is good to have it here. >> Also this file can be used by u-boot for example and u-boot can be configured >> from it that's why I think that make sense to keep this here. > > Ok. It's become commonplace to leave memory empty for the machines > where it's guaranteed that the bootloader will have updated it, to > avoid having stale or incorrect values in the static tree. I'm not > going to be strict about it, but it's something to consider. Will update then, thanks. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg