From: Jaehoon Chung <jh80.chung@samsung.com>
To: "Fu, Zhonghui" <zhonghui.fu@linux.intel.com>,
Chris Ball <chris@printf.net>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
ulf.hansson@linaro.org, tgih.jun@samsung.com, aaron.lu@intel.com,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
jackey.shen@amd.com, gregkh@linuxfoundation.org
Subject: Re: One bug of SDHCI driver
Date: Tue, 15 Jul 2014 13:14:45 +0900 [thread overview]
Message-ID: <53C4AAB5.4070700@samsung.com> (raw)
In-Reply-To: <53C497FD.2070000@linux.intel.com>
On 07/15/2014 11:54 AM, Fu, Zhonghui wrote:
>
> Hi,
>
> The data type of "host" is "struct mmc_host", and there is not "quirks" member in this structure.
Sorry for wrong typo.
You use the "host->caps2" instead of "host->quirks".
Best Regards,
Jaehoon Chung
>
>
> Thanks,
> Zhonghui
>
> On 2014/7/14 21:26, Chris Ball wrote:
>> Hi Zhonghui,
>>
>> On Tue, Jul 08 2014, Fu, Zhonghui wrote:
>>> Why add "mmc->caps2 |= MMC_CAP2_SDIO_IRQ_NOTHREAD;" ? How to fix this bug?
>>>
>>> Could you please give out some idea about this bug?
>> Jaehoon already gave you a patch to fix this bug. Here it is again in
>> proper patch form. Please can you test it and let us know whether it
>> fixes the crash? Thanks.
>>
>>
>> From: Chris Ball <chris@printf.net>
>> Subject: [PATCH] mmc: core: sdio: Fix unconditional wake_up_process() on sdio thread
>>
>> 781e989cf59 ("mmc: sdhci: convert to new SDIO IRQ handling") and
>> bf3b5ec66bd ("mmc: sdio_irq: rework sdio irq handling") disabled
>> the use of our own custom threaded IRQ handler, but left in an
>> unconditional wake_up_process() on that handler at resume-time.
>>
>> Reported-by: Fu, Zhonghui <zhonghui.fu@linux.intel.com>
>> [Patch suggested by Jaehoon Chung]
>> Signed-off-by: Chris Ball <chris@printf.net>
>> ---
>> drivers/mmc/core/sdio.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
>> index e636d9e..2a128e2 100644
>> --- a/drivers/mmc/core/sdio.c
>> +++ b/drivers/mmc/core/sdio.c
>> @@ -992,7 +992,8 @@ static int mmc_sdio_resume(struct mmc_host *host)
>> }
>> }
>>
>> - if (!err && host->sdio_irqs)
>> + if (!err && host->sdio_irqs &&
>> + !(host->quirks & MMC_CAP2_SDIO_IRQ_NOTHREAD))
>> wake_up_process(host->sdio_irq_thread);
>> mmc_release_host(host);
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-07-15 4:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 5:39 one doubt about mmc_sdio_init_card function Fu, Zhonghui
2014-07-02 2:52 ` Aaron Lu
2014-07-03 15:47 ` One bug of SDHCI driver Fu, Zhonghui
2014-07-04 2:40 ` Jaehoon Chung
2014-07-06 15:19 ` Fu, Zhonghui
2014-07-08 16:03 ` Fu, Zhonghui
2014-07-14 13:26 ` Chris Ball
2014-07-15 2:54 ` Fu, Zhonghui
2014-07-15 4:14 ` Jaehoon Chung [this message]
2014-07-15 4:40 ` Jaehoon Chung
2014-07-20 14:51 ` Fu, Zhonghui
2014-07-24 15:27 ` Fu, Zhonghui
[not found] ` <53D85CBF.3070409@linux.intel.com>
2014-07-30 3:40 ` Jaehoon Chung
2014-08-05 4:56 ` Fu, Zhonghui
2014-08-07 6:58 ` Fu, Zhonghui
2014-08-11 5:53 ` Fu, Zhonghui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53C4AAB5.4070700@samsung.com \
--to=jh80.chung@samsung.com \
--cc=aaron.lu@intel.com \
--cc=chris@printf.net \
--cc=gregkh@linuxfoundation.org \
--cc=jackey.shen@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
--cc=zhonghui.fu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome