From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932116AbaHAUyk (ORCPT ); Fri, 1 Aug 2014 16:54:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:60359 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755933AbaHAUyi (ORCPT ); Fri, 1 Aug 2014 16:54:38 -0400 Message-ID: <53DBFE8A.7020505@suse.de> Date: Fri, 01 Aug 2014 22:54:34 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Doug Anderson CC: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Stephan van Schaik , Vincent Palatin , Javier Martinez Canillas , Tomasz Figa , Ben Dooks , Kukjin Kim , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , open list Subject: Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow References: <1406868897-26874-1-git-send-email-afaerber@suse.de> <1406868897-26874-6-git-send-email-afaerber@suse.de> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Doug, Am 01.08.2014 22:33, schrieb Doug Anderson: > On Thu, Jul 31, 2014 at 9:54 PM, Andreas Färber wrote: >> Spring uses a different GPIO, so this is not a generic SoC piece. >> >> Suggested-by: Tomasz Figa >> Signed-off-by: Andreas Färber >> --- >> v5: New (Tomasz Figa) >> Frees dp_hpd for Spring. >> >> arch/arm/boot/dts/exynos5250-pinctrl.dtsi | 7 ------- >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 9 +++++++++ >> arch/arm/boot/dts/exynos5250-snow.dts | 7 +++++++ >> 3 files changed, 16 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >> index 886cfca044ac..ed0e5230514b 100644 >> --- a/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >> +++ b/arch/arm/boot/dts/exynos5250-pinctrl.dtsi >> @@ -581,13 +581,6 @@ >> samsung,pin-pud = <0>; >> samsung,pin-drv = <0>; >> }; >> - >> - dp_hpd: dp_hpd { >> - samsung,pins = "gpx0-7"; >> - samsung,pin-function = <3>; >> - samsung,pin-pud = <0>; >> - samsung,pin-drv = <0>; >> - }; >> }; >> >> pinctrl@13400000 { >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> index aaa055ac0fe3..5d30fe1dcda4 100644 >> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> @@ -414,3 +414,12 @@ >> }; >> }; >> }; >> + >> +&pinctrl_0 { >> + dp_hpd: dp_hpd { >> + samsung,pins = "gpx0-7"; >> + samsung,pin-function = <3>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> +}; >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index c4b0c73c736d..a9a2f2743794 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -547,6 +547,13 @@ >> }; >> >> &pinctrl_0 { >> + dp_hpd: dp_hpd { >> + samsung,pins = "gpx0-7"; >> + samsung,pin-function = <3>; >> + samsung,pin-pud = <0>; >> + samsung,pin-drv = <0>; >> + }; >> + > > NAK. dp_hpd is a generic SoC piece. Pin function 0 and 1 are GPIOs. > Pin function 3 is special function. This pin _is_ the hot plug detect > pin for display port. When it's set as special function 3 it goes > straight into the hot plug logic of the display port controller. > > Spring may have had its reasons to detect hot plug events on a GPIO > instead of using this pin, but that doesn't make this pin any less the > "hot plug pin". Please advise how to handle it then: Should there be two different pinctrl entries (if so, how should it be named?), or should spring override the generic entry? As I reported, 3.8 has only one dp-hpd pinctrl entry, so I dropped the dp-hpd-gpio naming. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg