From: micky <micky_ching@realsil.com.cn>
To: Fabio Falzoi <fabio.falzoi84@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>, <joe@perches.com>,
<dan.carpenter@oracle.com>, <wei_wang@realsil.com.cn>
Subject: Re: [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*phspecifiertodump memory
Date: Mon, 4 Aug 2014 09:23:04 +0800 [thread overview]
Message-ID: <53DEE078.2060506@realsil.com.cn> (raw)
In-Reply-To: <20140801175526.GA19125@PippoloLaptop>
On 08/02/2014 01:55 AM, Fabio Falzoi wrote:
> On Wed, Jul 30, 2014 at 09:52:35AM +0800, micky wrote:
>> Documentation/printk-formats.txt
>>
>> Raw buffer as a hex string:
>> %*ph 00 01 02 ... 3f
>> %*phC 00:01:02: ... :3f
>> %*phD 00-01-02- ... -3f
>> %*phN 000102 ... 3f
>>
>> For printing a small buffers (up to 64 bytes long) as a hex string with
>> certain separator. For the larger buffers consider to use
>> print_hex_dump().
>>
>>
>> Since we can't make sure the cnt value, it is not good use "%*ph",
>> because it must make cnt <= 64.
>> dw_len * 4 <= 64 ?
> Hi Micky,
>
> I think that in these two cases we can rely on print_hex_dump_bytes that
> doesn't have the dev_dbg limit on buffer size.
> Let me know what you think about it. If you agree, I can send a new version
> for patches 3/4 and 4/4, since the first two have already been merged in the
> linux-next tree by Greg.
Hi Fabio,
I think it is good, Thanks.
Best Regards,
micky
> Regards,
> Fabio
> .
>
next prev parent reply other threads:[~2014-08-04 1:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 22:15 [PATCH v5 0/4] Staging: rts5208: Use standard debug features Fabio Falzoi
2014-07-29 22:15 ` [PATCH v5 1/4] Staging: rts5208: Remove useless debug prints Fabio Falzoi
2014-07-29 22:15 ` [PATCH v5 2/4] Staging: rts5208: Replace custom macro with dev_dbg Fabio Falzoi
2014-07-29 22:15 ` [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*ph specifier to dump memory Fabio Falzoi
[not found] ` <53D84FE3.9040709@realsil.com.cn>
2014-08-01 17:55 ` [PATCH v5 3/4] Staging: rts5208: Use dev_dbg and %*ph specifierto " Fabio Falzoi
2014-08-04 1:23 ` micky [this message]
2014-07-29 22:15 ` [PATCH v5 4/4] Staging: rts5208: Remove CONFIG_RTS5208_DEBUG option Fabio Falzoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DEE078.2060506@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fabio.falzoi84@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®