From: Juergen Gross <jgross@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: James.Bottomley@HansenPartnership.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] Save command pool address of Scsi_Host
Date: Mon, 04 Aug 2014 13:17:17 +0200 [thread overview]
Message-ID: <53DF6BBD.2060206@suse.com> (raw)
In-Reply-To: <20140804110844.GC19109@infradead.org>
On 08/04/2014 01:08 PM, Christoph Hellwig wrote:
> On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgross@suse.com wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's
>> private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
>> scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.
>>
>> This will result in an access error when the host is removed.
>>
>> Avoid the problem by saving the address of a new allocated command pool where
>> it is expected and delete it again when the pool is destroyed.
>
> I don't really like the double pointer passing - just NULLing out the
> pointer in the caller where needed seems cleaner.
I wanted to avoid to spread this, but I don't mind doing it. V4 is
coming...
Juergen
prev parent reply other threads:[~2014-08-04 11:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 4:26 jgross
2014-08-04 11:08 ` Christoph Hellwig
2014-08-04 11:17 ` Juergen Gross [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DF6BBD.2060206@suse.com \
--to=jgross@suse.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome