From: Ian Abbott <abbotti@mev.co.uk>
To: Niklas Svensson <nks@flawful.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
Raghavendra Ganiga <ravi23ganiga@gmail.com>,
<devel@driverdev.osuosl.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: fixing coding style problems
Date: Thu, 7 Aug 2014 10:56:10 +0100 [thread overview]
Message-ID: <53E34D3A.2090805@mev.co.uk> (raw)
In-Reply-To: <1407347710-11460-1-git-send-email-nks@flawful.org>
On 2014/08/06 06:55 PM, Niklas Svensson wrote:
> This patch fixes warnings of checkpatch.pl script:
>
> CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around devpriv->timer
> + init_timer(&(devpriv->timer));
>
> CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
> + dev_info(dev->class_dev,
> + "%s: %i microvolt, %li microsecond waveform attached\n",
>
> Task of Eudyptula challenge.
>
> Signed-off-by: Niklas Svensson <nks@flawful.org>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2014-08-07 9:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-06 17:55 Niklas Svensson
2014-08-07 9:56 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E34D3A.2090805@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nks@flawful.org \
--cc=ravi23ganiga@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®