From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756170AbaHHIYP (ORCPT ); Fri, 8 Aug 2014 04:24:15 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:44240 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755980AbaHHIYD (ORCPT ); Fri, 8 Aug 2014 04:24:03 -0400 Message-ID: <53E48920.9020703@jic23.retrosnub.co.uk> Date: Fri, 08 Aug 2014 09:24:00 +0100 From: Jonathan Cameron User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Luis Henriques , Jan Kardell CC: linux-kernel@vger.kernel.org, stable@vger.kernel.org, kernel-team@lists.ubuntu.com, Jonathan Cameron , Jiri Slaby Subject: Re: [PATCH] iio: ti_am335x_adc: Fix prerequisite for stepid patch References: <1406195177-8656-113-git-send-email-luis.henriques@canonical.com> <1406286826-30834-1-git-send-email-jan.kardell@telliq.com> <20140728100530.GB5068@hercules> In-Reply-To: <20140728100530.GB5068@hercules> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/07/14 11:05, Luis Henriques wrote: > On Fri, Jul 25, 2014 at 01:13:46PM +0200, Jan Kardell wrote: >> Kernel series 3.11 and 3.12 does not initialize scan_index in the >> iio_chan_spec structure as 3.13 and newer does. This is necessary >> for the stepid patch to work, otherwise it even breaks the cases >> that worked before the stepid patch. >> >> Unfortunately the stepid patch seems to already be in 3.12.25, >> must have missed that inclusion. >> >> Signed-off-by: Jan Kardell >> --- >> drivers/iio/adc/ti_am335x_adc.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c >> index 3ceac3e..6c56418 100644 >> --- a/drivers/iio/adc/ti_am335x_adc.c >> +++ b/drivers/iio/adc/ti_am335x_adc.c >> @@ -120,6 +120,7 @@ static int tiadc_channel_init(struct iio_dev *indio_dev, int channels) >> chan->channel = adc_dev->channel_line[i]; >> chan->info_mask_separate = BIT(IIO_CHAN_INFO_RAW); >> chan->datasheet_name = chan_name_ain[chan->channel]; >> + chan->scan_index = i; >> chan->scan_type.sign = 'u'; >> chan->scan_type.realbits = 12; >> chan->scan_type.storagebits = 32; >> -- >> 1.8.4.5 >> > Ah, nice catch! > > Ideally, I would pick commit ca9a563805f7ae821e3303b1bdbc65d3a3c783ff > ("iio: ti_am335x_adc: Add continuous sampling support"), which adds > this scan_index initialisation. However, this commit doesn't seem be > suitable for a stable kernel, so I'll add this patch to the 3.11.10.14 > queue branch. Thanks a lot, Jan. Indeed, thanks for picking this up. Acked-by: Jonathan Cameron for any other stable trees where it is relevant (won't do any harm on any where it isn't!) > > Cheers, > -- > Luís