From: Jiri Slaby <jslaby@suse.cz>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tty: serial: serial_core.c: printk replacement
Date: Mon, 18 Aug 2014 14:25:53 +0200 [thread overview]
Message-ID: <53F1F0D1.6070102@suse.cz> (raw)
In-Reply-To: <1407242145-3132-1-git-send-email-sudipm.mukherjee@gmail.com>
On 08/05/2014, 02:35 PM, Sudip Mukherjee wrote:
> printk replaced with corresponding dev_err, dev_alert, dev_notice and pr_info.
> pr_info has been used instead of dev_info as there is a check for port->dev being NULL or not.
> fixed two broken user-visible strings used by the corresponding printk
>
> Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> ---
>
> For my previous patch ,Jiri Slaby told to investigate further as I have used uport->dev and there was a check for whether it is NULL.
> For this patch instead of uport->dev , i have used tty_dev as that one gave a better desciption of the device than uport->dev.
Hi, that will not work either, as there is put_device(tty_dev) before
you use tty_dev.
--
js
suse labs
next prev parent reply other threads:[~2014-08-18 12:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 12:35 Sudip Mukherjee
2014-08-18 12:25 ` Jiri Slaby [this message]
2014-08-19 5:36 ` Sudip Mukherjee
[not found] <[PATCH] tty: serial: serial_core.c: printk replacement>
2014-07-30 14:07 ` Sudip Mukherjee
2014-07-30 14:37 ` Jiri Slaby
2014-07-30 14:52 ` Sudip Mukherjee
2014-07-31 13:50 ` Sudip Mukherjee
-- strict thread matches above, loose matches on Subject: below --
2014-07-28 14:58 Sudip Mukherjee
2014-07-28 15:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1F0D1.6070102@suse.cz \
--to=jslaby@suse.cz \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome