From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Nick Dyer <nick.dyer@itdev.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Stephen Warren <swarren@nvidia.com>,
Yufeng Shen <miletus@chromium.org>,
Benson Leung <bleung@chromium.org>,
Doug Anderson <dianders@chromium.org>,
Olof Johansson <olof@lixom.net>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example
Date: Mon, 18 Aug 2014 15:20:04 +0200 [thread overview]
Message-ID: <53F1FD84.5020901@collabora.co.uk> (raw)
In-Reply-To: <53EE307E.8060507@itdev.co.uk>
Hello Nick,
On 08/15/2014 06:08 PM, Nick Dyer wrote:
>>
>> Any comments on this? I would really appreciate if you can expand on how
>> this DT property is supposed to be used so I can re-spin the atmel support
>> patch for Peach boards.
>
> The below patch improves the documentation for the gpio-property. Stephen
> Warren has a good example here:
> https://github.com/swarren/linux-tegra/commit/09789801
>
> trackpad@4b {
> compatible = "atmel,maxtouch";
> reg = <0x4b>;
> interrupt-parent = <&gpio>;
> interrupts = <TEGRA_GPIO(W, 3) IRQ_TYPE_LEVEL_LOW>;
> linux,gpio-keymap = <0 0 0 BTN_LEFT>;
> };
>
> This maps BTN_LEFT to the 4th bit of the T19 message. I haven't looked up
> what GPIO number that corresponds to on the mXT224SL that he has, it varies
> with the particular maXTouch device you have.
>
> Hope this helps.
>
Thanks a lot for the patch and the pointer to Stephen's DTS. I'll do some
experimentation then to figure out the right values since I don't have
proper documentation. Fortunately the Chrome OS 3.8 downstream driver
works on -next so I can use evdev to compare if both drivers behave the same.
> Signed-off-by: Nick Dyer <nick.dyer@itdev.co.uk>
Best regards,
Javier
next prev parent reply other threads:[~2014-08-18 13:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-07 0:48 [PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting Javier Martinez Canillas
2014-08-07 0:48 ` [PATCH 2/2] Input: atmel_mxt_ts - Add keycodes array example Javier Martinez Canillas
2014-08-07 12:38 ` Nick Dyer
2014-08-08 14:52 ` Javier Martinez Canillas
2014-08-15 12:01 ` Javier Martinez Canillas
2014-08-15 16:08 ` Nick Dyer
2014-08-15 16:13 ` Stephen Warren
2014-09-11 14:52 ` [PATCH] Input: atmel_mxt_ts - fix merge in DT documentation Nick Dyer
2014-09-11 17:32 ` Dmitry Torokhov
2014-08-18 13:20 ` Javier Martinez Canillas [this message]
2014-08-07 1:14 ` [PATCH 1/2] Input: atmel_mxt_ts - Get IRQ edge/level flags on DT booting Tomasz Figa
2014-08-07 1:47 ` Javier Martinez Canillas
2014-08-07 6:09 ` Dmitry Torokhov
2014-08-07 7:49 ` Javier Martinez Canillas
2014-08-07 16:47 ` Dmitry Torokhov
2014-08-08 13:24 ` Javier Martinez Canillas
2014-08-08 16:25 ` Tomasz Figa
2014-08-07 12:20 ` Nick Dyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F1FD84.5020901@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=bleung@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=miletus@chromium.org \
--cc=nick.dyer@itdev.co.uk \
--cc=olof@lixom.net \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome