From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Axel Lin <axel.lin@ingics.com>, Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max77802: Remove unused fields from struct max77802_regulator_prv
Date: Wed, 20 Aug 2014 18:10:00 +0200 [thread overview]
Message-ID: <53F4C858.4040202@collabora.co.uk> (raw)
In-Reply-To: <1408500257.5309.2.camel@phoenix>
Hello Axel,
On 08/20/2014 04:04 AM, Axel Lin wrote:
> Both num_regulators and *rdev[MAX77802_REG_MAX] are not used, remove them.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Right, these are not used indeed since are left overs from the previous
attempt to have a single driver for both max77686 and max77802 PMICs.
Sorry about that and thanks a lot for the patch.
>
> struct max77802_regulator_prv {
> - int num_regulators;
> - struct regulator_dev *rdev[MAX77802_REG_MAX];
> unsigned int opmode[MAX77802_REG_MAX];
> };
>
>
I see that Mark already applied this but fwiw:
Acked-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
prev parent reply other threads:[~2014-08-20 16:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 2:04 Axel Lin
2014-08-20 15:21 ` Mark Brown
2014-08-20 16:10 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53F4C858.4040202@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=axel.lin@ingics.com \
--cc=broonie@kernel.org \
--cc=ch.naveen@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome