From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755007AbaHUNS5 (ORCPT ); Thu, 21 Aug 2014 09:18:57 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:57576 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754457AbaHUNS4 (ORCPT ); Thu, 21 Aug 2014 09:18:56 -0400 Message-ID: <53F5F1BA.3090306@redhat.com> Date: Thu, 21 Aug 2014 15:18:50 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 MIME-Version: 1.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Gleb Natapov , Raghavendra KT , Vinod Chegu , Hui-Zhi , Christian Borntraeger Subject: Re: [PATCH v2 4/6] KVM: VMX: dynamise PLE window References: <1408567997-21222-1-git-send-email-rkrcmar@redhat.com> <1408567997-21222-5-git-send-email-rkrcmar@redhat.com> <53F5AD3E.3050800@redhat.com> <20140821115405.GD20546@potion.brq.redhat.com> <53F5E623.5090906@redhat.com> <20140821124223.GD20453@potion.brq.redhat.com> In-Reply-To: <20140821124223.GD20453@potion.brq.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 21/08/2014 14:42, Radim Krčmář ha scritto: > 2014-08-21 14:29+0200, Paolo Bonzini: >> Il 21/08/2014 13:54, Radim Krčmář ha scritto: >>> Guity as charged. >>> Using 0/1 or true/false in this context directly would be pretty bad ... >>> Is enum fine? (SHIRINK_PLE_WINDOW, GROW_PLE_WINDOW?) >> >> I prefer good old Ctrl-C Ctrl-V (adjusted for your favorite editor). :) > > I, I should be able to do it, but nightmares are going to last a while. > > (And to lower chances of v4: are tracepoint macros, like for kvm_apic, > frowned upon now?) Nah, go ahead. But is there any example of #define like what you were doing? I tried grepping for "#define.*[a-z]\(" and didn't get anything similar. Paolo