From: Santosh Shilimkar <santosh.shilimkar@ti.com>
To: Doug Anderson <dianders@chromium.org>,
Mark Brown <broonie@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
<olof@lixom.net>, Arnd Bergmann <arnd@arndb.de>
Cc: Addy Ke <addy.ke@rock-chips.com>,
Sonny Rao <sonnyrao@chromium.org>,
<linux-arm-kernel@lists.infradead.org>, <mark.rutland@arm.com>,
<devicetree@vger.kernel.org>, <swarren@nvidia.com>,
<pawel.moll@arm.com>, <ijc+devicetree@hellion.org.uk>,
<pdeschrijver@nvidia.com>, <agross@codeaurora.org>,
<lgirdwood@gmail.com>, <robh+dt@kernel.org>,
<linux-kernel@vger.kernel.org>, <sandeep_n@ti.com>,
<galak@codeaurora.org>, <grant.likely@linaro.org>,
<treding@nvidia.com>, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH 0/2] IO voltage domain support for rk3188 and rk3288
Date: Thu, 28 Aug 2014 17:26:43 -0400 [thread overview]
Message-ID: <53FF9E93.3040601@ti.com> (raw)
In-Reply-To: <1409254565-10677-1-git-send-email-dianders@chromium.org>
On Thursday 28 August 2014 03:36 PM, Doug Anderson wrote:
> These two patches add support for automatically configuring the IO
> voltage domains on rk3188 and rk3288 SoCs. The first patch adds some
> new notification types to the regulator code. It's used by the second
> patch which actually implements the IO voltage domain driver.
>
> These two patches were co-developed by Heiko Stübner and Doug Anderson
> (proof of concept patches were written by Heiko). They were tested in
> a private branch on an rk3288 board using rk808 instead of mainline
> since rk808 support isn't finalized in mainline yet.
>
> (sorry if you got this series twice; my mailer seems unhappy with me)
>
> Heiko Stübner (2):
> regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT)
> soc/rockchip: io-domain: add driver handling io domains
>
Sorry to shot down but your IO domains are nothing but voltage domains
and you should really build something in the drivers/power/*
Please have a look at the RFC [1]. You should really go on those
lines and collaborate to make a generic voltage domain layer instead of throwing
the driver under drivers/soc.
> .../devicetree/bindings/arm/rockchip/io-domain.txt | 60 ++++
> drivers/regulator/core.c | 63 +++-
> drivers/soc/Kconfig | 1 +
> drivers/soc/Makefile | 1 +
> drivers/soc/rockchip/Kconfig | 10 +
> drivers/soc/rockchip/Makefile | 1 +
> drivers/soc/rockchip/io-domain.c | 333 +++++++++++++++++++++
> include/linux/regulator/consumer.h | 20 ++
> 8 files changed, 482 insertions(+), 7 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/arm/rockchip/io-domain.txt
> create mode 100644 drivers/soc/rockchip/Kconfig
> create mode 100644 drivers/soc/rockchip/Makefile
> create mode 100644 drivers/soc/rockchip/io-domain.c
>
Regards,
Santosh
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-February/233819.html
next prev parent reply other threads:[~2014-08-28 21:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-28 19:36 Doug Anderson
2014-08-28 19:36 ` [PATCH 1/2] regulator: core: Add REGULATOR_EVENT_PRE_VOLTAGE_CHANGE (and ABORT) Doug Anderson
2014-08-29 11:05 ` Mark Brown
2014-08-28 19:36 ` [PATCH 2/2] soc/rockchip: io-domain: add driver handling io domains Doug Anderson
2014-08-28 21:26 ` Santosh Shilimkar [this message]
2014-08-30 4:51 ` [PATCH 0/2] IO voltage domain support for rk3188 and rk3288 Doug Anderson
2014-08-30 11:27 ` Heiko Stübner
2014-09-04 16:51 ` Linus Walleij
2014-09-10 23:12 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2014-08-28 19:19 Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53FF9E93.3040601@ti.com \
--to=santosh.shilimkar@ti.com \
--cc=addy.ke@rock-chips.com \
--cc=agross@codeaurora.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nm@ti.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sandeep_n@ti.com \
--cc=sonnyrao@chromium.org \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®