From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B7BA62566 for ; Mon, 23 Jun 2025 16:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750696814; cv=none; b=NPjR3iW+dLNspyE2XscpXyDWJCU5Ozaw6Vuy16oLkU3MO1RREP300ivUaCB/N0nx8dZp53dvasnHg/Nm11DysWToQlkskfXu//Dr8K7aiavxNUGbl5/5DFoUmytSOIlrIrGQdgdV353wucsp7rJrS1BfACPIwRWqLPNA04JsRtg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750696814; c=relaxed/simple; bh=eR+ur1cKOg2flLGzDzwtH0YBRTLAIui1olriTCPWVSs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qrYDPriBBU08+Kp5LBUWGIkEf8ZRxd+Z6jNLkbpHReFXViKkt+HNLBbNBhWs32U2+b1aTXWfrGCjx870FJpm1BhAYwaYN6ix45SGPcl9NH2k09uD8E3BvzbGkwzTj26Zji8RKiurnJYgKWbBilo9xQy7RiDatEAUlwghzwUwTdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hXa4RjH5; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hXa4RjH5" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55N9VxsL002182 for ; Mon, 23 Jun 2025 16:40:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= t2bRT9SJHlT97u3ops9Jk5UZrZDQEVjvrIec/PkyZq8=; b=hXa4RjH5lR/jBXAK vycZBatVTqXUgXL2Phf9cnXpke7WyRnccJu7Vnt2/+9AniZUphgSxHf2wuqm66ii z2jpYcW3KYpA+ioPWrMygtQ8wqPbnmL/1+W7agkiP3AF45mGFU6a+Ry5l+5fINN5 GHiXxgeFx3T1EYprBp6jYa3YpOdV7XUA5QlDhbMRuCF71ND4YTYRYF/YZHY9FwKx TmridgQDpb8Q8HqiPPwaP1RKLpFCzMzGsR2Eev9gGhae+UAj1wZzDjvCPAANVmuG +50uYvHHG1ufCz6ll2mPrx2mozE/1TxixyRqciDJ4X0O6Q3RpOm/J345wJgshww8 fvr2Fg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47eah7um9v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 23 Jun 2025 16:40:11 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7d21080c26fso114789885a.1 for ; Mon, 23 Jun 2025 09:40:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750696811; x=1751301611; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t2bRT9SJHlT97u3ops9Jk5UZrZDQEVjvrIec/PkyZq8=; b=o4m888zw7FEYrw+uaxJcUk08ZqpeLGUYE754pNKVaggz2TJ+ebnKKfjjIbiRuve6Ab QVsS9VzSoqAUMBIWcYwX5/hkKCr6Q1/6e7c/tgXm8YX6I3dtdMVvuvUxoQrR8ldOk1Nk IZYQu2UnEsIXvOmfeu7oWNTusJGGaYrfIeI9SVnweJYQtqOULaacRjVUAjQxW+cIIF1x K7pIXnNsAbBV5tXmxWESKaPlbkCOstGmbSROo55AupMkp+9cj5HrbHYGTco9uRQ4FIEZ VLztgmoTsfImSGd9gGh7lZgk4xi6ri+FDxKseQBwaVDOA/Ur9XmSWzDqfY5vj2Uyxpdn cDyg== X-Forwarded-Encrypted: i=1; AJvYcCUULXPxUK6OjfPE+hEokszF/unu3j1zgJMq42kDIrHfeEZqniiyP9wDjtqVbMGUXpXzuWYx5a0zRzqQ0Ak=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6r9jTJCr7yJ1sMJpqH+6RWdlKC6EgWfqEBVB1F+RaXpjxgSbW CHZsGaCainfk6MM/SwjnCzyPtDTGnoAVs/TUBglNT2uIiZE4YKy3ROQOG8P0yiq94KYh8S57hw3 5Cqw40rgIdNmw0/M/oCUaLJTGCDXQxQze7sf5byQ2mz0bTMMY6OP2dS/m+yilV0fd3S4= X-Gm-Gg: ASbGncstFvB1pe0d+JdppiZluSF35NfyCKJsXkMAzqITVIRfombiw30PZONpQpjMXQC 85bCb/afz3UadEAROqArcKXd+Ne9nis2QGHxSfnbN6yQQ0lTkD0XNZadGzN01SPClP9YW0U+mmD Wj7lztcuECluQ1JExGVxjRsoDC+gIGbfHJSqKFUBq9bISOKVKe4ADkZWO3hX4Aog7Nuj5mmZLif Py+A68pWvW9gzv+8oJVg/wO3ADCHzZX5ErSfRGUu1zGjBNKMpHGwVLLzNCTQ+DrtTGli8qkfomT 7d5OBjxgmuS/UR8izG82IJN+MJ3tbeBqHG5xv8miEa7+n5L9c4unoFo/iAMbxk7QdmKBK+hPLDB ZRFs= X-Received: by 2002:ac8:5c91:0:b0:48b:6eeb:f98e with SMTP id d75a77b69052e-4a780353b2fmr42899891cf.2.1750696810505; Mon, 23 Jun 2025 09:40:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEq/XOpoxNvNR6RSBM0eTtgQkZh2y7a6j9L7YTt/WuGqvanSwKZAsgCnNh09krw6R1+H5c0WA== X-Received: by 2002:ac8:5c91:0:b0:48b:6eeb:f98e with SMTP id d75a77b69052e-4a780353b2fmr42899651cf.2.1750696809833; Mon, 23 Jun 2025 09:40:09 -0700 (PDT) Received: from [192.168.143.225] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae0541b6e04sm730543266b.115.2025.06.23.09.40.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Jun 2025 09:40:09 -0700 (PDT) Message-ID: <53a2cdba-0fb8-4b99-b58e-9318b1bd8ef6@oss.qualcomm.com> Date: Mon, 23 Jun 2025 18:40:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/11] power: supply: qcom_smbx: program aicl rerun time To: Casey Connolly , Konrad Dybcio , Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Kees Cook , "Gustavo A. R. Silva" Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sebastian Reichel , linux-hardening@vger.kernel.org References: <20250619-smb2-smb5-support-v1-0-ac5dec51b6e1@linaro.org> <20250619-smb2-smb5-support-v1-11-ac5dec51b6e1@linaro.org> <2d3ff07d-1cd8-4eb6-8b3b-2d0d6f64445f@oss.qualcomm.com> <613f2812-3c60-41fe-bdd3-fbe8ea7eeb69@linaro.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <613f2812-3c60-41fe-bdd3-fbe8ea7eeb69@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: W3mNkIiN6oCqobseYAkmb3FNrFib4WI8 X-Authority-Analysis: v=2.4 cv=PpWTbxM3 c=1 sm=1 tr=0 ts=6859836b cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=KKAkSRfTAAAA:8 a=NTzqWVVAQLbBsVAMQFsA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjIzMDEwMCBTYWx0ZWRfX25WFWX37GGz4 BwUS+url2hYgJnRdVHIWDfmD6UQ9XS+HLa11NFAzwb064JvwvIRnqH0qM1dX/KPs/PBAAR1gwiy zF216THdzXDC7rO8eZXkDHZNZpHvwvFKEycmSgUiIJ8j92rfF7EH5t1TBMoxCCYZyxk3smMrwXD xIc9878kA2uXzghTuzerJ0A7W9WrKCrDkOUiIGcOKWQnKPEwM8RgwMzKOPrBDs+gY0yLjYWOlPE GdB6Yp8ZScyiI2ZX++qyytP6hx5/imWwbyjGi1+9Rv2JoyWmdQUbC6UsoOUlgKTZqvhO3cqWdOX RKksU6DNMGkDYu9cQophH87TOry5NAwAu1xwemMWtPnPXwgwCUbMZLhcBoXiw2+fTrPlXAUslA2 we5WTSsGxzDsqLCbvcvprUmltJNV4voygV8xn3pIUGSKGTDX3g0inFt/6bWjKsXEZ4P0PD9q X-Proofpoint-GUID: W3mNkIiN6oCqobseYAkmb3FNrFib4WI8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-23_04,2025-06-23_07,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 clxscore=1015 adultscore=0 mlxscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506230100 On 6/23/25 6:33 PM, Casey Connolly wrote: > > > On 6/20/25 19:00, Konrad Dybcio wrote: >> On 6/19/25 4:55 PM, Casey Connolly wrote: >>> We don't know what the bootloader programmed here, but we want to have a >>> consistent value. Program the automatic input current limit detection to >>> re-run every 3 seconds. This seems to be necessary at least for smb5. >>> >>> Signed-off-by: Casey Connolly >>> --- >>>   drivers/power/supply/qcom_smbx.c | 6 ++++++ >>>   1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/power/supply/qcom_smbx.c b/drivers/power/supply/qcom_smbx.c >>> index d902f3f43548191d3d0310ce90e699918ed0f16f..b723dba5b86daefb238ee6aae19b1b7e5236fce3 100644 >>> --- a/drivers/power/supply/qcom_smbx.c >>> +++ b/drivers/power/supply/qcom_smbx.c >>> @@ -1091,8 +1091,14 @@ static int smb_probe(struct platform_device *pdev) >>>       if (rc < 0) >>>           return dev_err_probe(chip->dev, rc, >>>                        "Couldn't write fast charge current cfg"); >>>   +    rc = regmap_write_bits(chip->regmap, chip->base + AICL_RERUN_TIME_CFG, >>> +                   AICL_RERUN_TIME_MASK, AIC_RERUN_TIME_3_SECS); >> >> FWIW a random downstream clone I have sets 0x01 which is claimed to >> mean "every 12s" instead > > hmm I saw that too, I think more documentation would be needed to understand this properly (I'm not exactly clear on what this actually means, when the AICL would re-run, etc). > > I have reports that this works ok, so I'd just leave it unless we have info to suggest otherwise. Well, in case of such lack of understanding I'd much prefer to see a magic number that shipped on hundreds of millions of devices than a magic number that was confirmed working on a couple dozen.. especially since this looks like an improvement that people who had their hand in the hw design wouldn't generally overlook unless there was reasons (e.g. compatibility or some sort of a quirk) Konrad