From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DAAE352077 for ; Tue, 26 Aug 2025 14:09:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217363; cv=none; b=r3TkSxMNrE9arOkjw5V8YbLjfJBaVD8kPhx9Euv662Arrv8SeosNMqwrur4wJ5eFdxRUfhAhmkm+ILtc4OSYVInmnGYHSmou+DTbTQUleQSkaSTx33ZQIO3yYXoQddeGsyfp5rdnnbAYeTLJw5NbkyRc6NYSlU11zr1nfLmrXT8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756217363; c=relaxed/simple; bh=4Z8sacIFlP/t9bo1OcRvfuKo6GZJTg+94H6GtE2fEzk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tw5hJoO3/+c20DuIuekg+K35fZVFF1MVrDU82/XChkzO46UMAIPCdH0yCaMLp3Qnu2ThdLn/DKEoPFBLg182U5R+0L3C8gwDCY13GyRP+ljOqQ1iL+9nbnI8+kKC5zrI9t6AU4dlXp7pKbAFNwKWPwbnntYUpWNyQ8q5rLIRzhk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=CBgx2e8z; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CBgx2e8z" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1756217360; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=r38Ew10IXp4jVZ4hrFLLc2cPCRDjSFsLCeWhOStjPcs=; b=CBgx2e8zgsvyuPNF9IpuP2p/0UTT2TI1BiSY7PvUs666ZCq1+qnmEIHJ+9C4G1QbxtHww+ i0fe7SMcgVj1tC+cJJIY5wQiVcmrxVtm5iICmXzHp5Ld2PkbRmM6wIBR3dnJH8jnebRmK5 cJGbAoblZ3jJCOBWvPg6/AFlrT9OeYo= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-4nuCuQ3MNNaU1aLyacxBeA-1; Tue, 26 Aug 2025 10:09:18 -0400 X-MC-Unique: 4nuCuQ3MNNaU1aLyacxBeA-1 X-Mimecast-MFC-AGG-ID: 4nuCuQ3MNNaU1aLyacxBeA_1756217357 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3c630eea496so2042604f8f.2 for ; Tue, 26 Aug 2025 07:09:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1756217357; x=1756822157; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=r38Ew10IXp4jVZ4hrFLLc2cPCRDjSFsLCeWhOStjPcs=; b=jPFIik7Ov9N2TleRjQoWEBelNQjRe4wpin1eI7eukGPiIQJxNHkdf85ufkDjrQLLje F52INHAlx/RkI4tGwGyFo1Z0ooEj/nXey1V0Z8uFZ02ayEOT3Oy9K/frWVUvQfNbnuCW Lqbm5BdkZ67V2/LADm+sD1uXj7xBveTzPClOyGKdjnnPcnCdBEiomdUkA2ZN2dd8CO3F cjz+IJSg6hFymewfOwMyqqK8z0SVckvTfXN9BtBFhaSCiNKmXeapUabRmXo1C9wE25vM gQsJQBBdyLrKpmMUY+HLOmAy6uY0ksmUcLvBXCtYSeW47u2CHAoz1rlsCtQ6M0t6KGFA ehZg== X-Forwarded-Encrypted: i=1; AJvYcCUavqv9g7goblyrKamlpF4B3k3OsmSOnFvgcuOiQ9ohL+gboBnAYpqyFW+8cZe3jp4rTELVgFuQZAt+1Ts=@vger.kernel.org X-Gm-Message-State: AOJu0YxiaxyIPwjhoRWtoK/edoEjjEjzc0MFnshP4UZyMKYZw1bEEJ2W KsFbCdwr8sGLnvF9cWzk0FIk7XDIOvW+qKffHPhVqDo0vOGQgB3j5WGK9thhI0VuXHD5W159jfB sl9WVZrDZbZS54j3Ps7c/l0YDQq79oja9XP64Hpgy16U4HiTDSN06Z5opwY4QdDSBEQ== X-Gm-Gg: ASbGncslv6bVKoACuKl5rjXKVuwI7sCSL9ls0Rj4iAwRtXz2PGZn+xLRqVp2rAB5Ozr Q4PzfaDoTtKS7OmsWnqj1JLISQ0WSuz088rTw2kYbNKYWQqubDaSDpdGKPzPRD4ePTNeBOmmy4z SBUG2GbSrqNnpGXikTdFLi5mDBoUcq/YyH60PGYASxc2pEfskUJgYsaGqzRksfdIUIBCVhfBuWO +q4atnmaybo/8hSv+CP1od5lutMWZnZWyzPriwvtjkxgy/Abxgqa8wkzA+WgSdV/YN/8VrklAx2 hmq32NsInJX+da9D6JGYxxaIkbstcJOnLO4zmfxLlFmIMSJSmsi9aSixtbNpLOb+d6wbs1li7w= = X-Received: by 2002:a05:6000:401f:b0:3c9:a4b7:da09 with SMTP id ffacd0b85a97d-3c9a4b7de2bmr5506098f8f.31.1756217357348; Tue, 26 Aug 2025 07:09:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHpVnjqNtC8/am/9sMuVxjSqK3ied/VaDZynwsfDDcUj7OQY0t9J9gKlKy5kQIg+ur0P4AuDw== X-Received: by 2002:a05:6000:401f:b0:3c9:a4b7:da09 with SMTP id ffacd0b85a97d-3c9a4b7de2bmr5506077f8f.31.1756217356889; Tue, 26 Aug 2025 07:09:16 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3c7117d5977sm16676603f8f.51.2025.08.26.07.09.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Aug 2025 07:09:16 -0700 (PDT) Message-ID: <53a7bf3d-843d-4e19-b0a3-cc6852fe72c1@redhat.com> Date: Tue, 26 Aug 2025 16:09:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] mm/ksm: Reset KSM counters in mm_struct during fork To: Giorgi Tchankvetadze , donettom@linux.ibm.com Cc: aboorvad@linux.ibm.com, akpm@linux-foundation.org, chengming.zhou@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, richard.weiyang@gmail.com, ritesh.list@gmail.com, xu.xin16@zte.com.cn References: <2e662107e01417bf9af23bc7f52863cd538419be.1756211338.git.donettom@linux.ibm.com> <512764a4-611c-42d4-8b4a-2aaca4e519a4@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <512764a4-611c-42d4-8b4a-2aaca4e519a4@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26.08.25 15:47, Giorgi Tchankvetadze wrote: > What if we only allocate KSM stats when a process actually uses KSM? > > struct ksm_mm_stats { > atomic_long_t merging_pages; > atomic_long_t rmap_items; > atomic_long_t zero_pages; > }; > struct ksm_mm_stats *mm->ksm_stats; // NULL until first enter > > static inline struct ksm_mm_stats *mm_get_ksm_stats(struct mm_struct *mm) > { > if (likely(mm->ksm_stats)) > return mm->ksm_stats; > return ksm_alloc_stats_if_needed(mm); // Slow path > } The fork'ed child uses KSM. It just doesn't have any stable rmap entries. We have to copy the zero_pages counter such that ksm_might_unmap_zero_page() will do the right thing. But you're comment made me realize that there is likely another bug: When copying zero_pages during fork(), we have to increment &ksm_zero_pages as well. Otherwise we will get an underflow later. @Donet, can you look into that as well? -- Cheers David / dhildenb