From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B15C433F5 for ; Thu, 14 Apr 2022 07:15:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240321AbiDNHSE (ORCPT ); Thu, 14 Apr 2022 03:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240308AbiDNHR6 (ORCPT ); Thu, 14 Apr 2022 03:17:58 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 563402CCBF for ; Thu, 14 Apr 2022 00:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1649920534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=79kwX/RNU1YRXLJoHZACrxSzp6IRarRrMnUl7UIT+nc=; b=NDJhcfBoXJlLRYra4ihOn6w1fJUeKcAHFrTYMQg/MpVBT8MHoy4QXYL3aGfPlxw2tnLYTQ VyY0UkyLf0zbN9GNNsNOluDeDLIpnLacSALG7H7OED78mTgvZF6K4KlcvAH73dQgqev8Ku JhOBB2q6tmGnLpILb9OUkWh2pjBepao= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-VhgXzcjoN1u7V7yGH3CeAA-1; Thu, 14 Apr 2022 03:15:32 -0400 X-MC-Unique: VhgXzcjoN1u7V7yGH3CeAA-1 Received: by mail-wm1-f70.google.com with SMTP id i66-20020a1c3b45000000b0038eab4e0feaso1994334wma.9 for ; Thu, 14 Apr 2022 00:15:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=79kwX/RNU1YRXLJoHZACrxSzp6IRarRrMnUl7UIT+nc=; b=LiOw3nscvivchT+uWZS2GjtJq3VlljNYCCq8+mU5CWdyML/2TO9Kg/zbdTqTl1hJOk kjbGy+VFSWQRIEE1qshQmfkzMk62Qs3TzjeCyToJ+HSLZP3PAEQzGvE7spCuOSNP9s52 mpIFFOm0T9bnPv2rEJxJWA1FmLbbWhPhCYX+QWcIOApp7OafRmUqZBDRqOw1U017ff8Z AObN6nx5DVmf/vhu2wS3SEFyQYshQc/H69ULr8O414buflCQJeKzP6oDiJ4tAyM+p4jl eOxj93QGUuvpoQyZtxvESioSspB8VOXFMh9fszDFdCjYNj0TWQmO4QSKjSnfTrNwoWGh 7mkA== X-Gm-Message-State: AOAM531ynP1tqvEEYpxM7LeSNEBzOM9dfuw5jkzL88ks2Ef92inSOq7B 0kjU1/Jhu8AUtDzKnmxj9fwgKT4dUUzRyCbcc3Sj93uNAw+f0EHCJrdHf0MAKV32z+PlCxMvghJ lSoK+vTZWTFbIFpQ82biuvXem X-Received: by 2002:a1c:f604:0:b0:38c:8ffd:dbb6 with SMTP id w4-20020a1cf604000000b0038c8ffddbb6mr2231562wmc.43.1649920530773; Thu, 14 Apr 2022 00:15:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzCPTdyrfTscflJP3w/3vmjoolU6cKkX1iKfSQEVtiea+ko2V17NzcNLnJcgoaTRavULDlNRA== X-Received: by 2002:a1c:f604:0:b0:38c:8ffd:dbb6 with SMTP id w4-20020a1cf604000000b0038c8ffddbb6mr2231544wmc.43.1649920530547; Thu, 14 Apr 2022 00:15:30 -0700 (PDT) Received: from gerbillo.redhat.com (146-241-96-237.dyn.eolo.it. [146.241.96.237]) by smtp.gmail.com with ESMTPSA id f9-20020a05600c154900b0038cb98076d6sm1208781wmg.10.2022.04.14.00.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 00:15:30 -0700 (PDT) Message-ID: <53a984cb43cdeaa20a7f5416e970b28813b72779.camel@redhat.com> Subject: Re: [PATCH] net: bcmgenet: Revert "Use stronger register read/writes to assure ordering" From: Paolo Abeni To: Florian Fainelli , Jeremy Linton , netdev@vger.kernel.org Cc: opendmb@gmail.com, davem@davemloft.net, kuba@kernel.org, pbrobinson@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org Date: Thu, 14 Apr 2022 09:15:29 +0200 In-Reply-To: <3f4972d1-ace1-0260-16e6-84fd0f475273@gmail.com> References: <20220412210420.1129430-1-jeremy.linton@arm.com> <3f4972d1-ace1-0260-16e6-84fd0f475273@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2022-04-13 at 10:00 -0700, Florian Fainelli wrote: > > On 4/12/2022 2:04 PM, Jeremy Linton wrote: > > It turns out after digging deeper into this bug, that it was being > > triggered by GCC12 failing to call the bcmgenet_enable_dma() > > routine. Given that a gcc12 fix has been merged [1] and the genet > > driver now works properly when built with gcc12, this commit should > > be reverted. > > > > [1] > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105160 > > https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=aabb9a261ef060cf24fd626713f1d7d9df81aa57 > > > > Fixes: 8d3ea3d402db ("net: bcmgenet: "Use stronger register read/writes to assure ordering") For the records, there is a small typo in the above tag, I'll fix it while applying the patch. No need to repost it. Cheers, Paolo