From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3EE62EF64F for ; Tue, 18 Nov 2025 14:42:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763476964; cv=none; b=gsTcQ+OpVNA1Qflu7/hFAgxtseyx/HbGuyMnMM3r5xGcc+gVGiTfj4JXpJG8/AgP5W8QZniqG92qUYk5Qgmz1Re35vc0IVyzGnU3B366NlztTXYcptFSQhwedzNzgBz+YTS+p2RfLgVU5ktxp+jCgdtwInZMg6XJaJS0IZCbzOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763476964; c=relaxed/simple; bh=Pu9ixYZsFQItNRYJLylft6nHxSMZveZVAFQIAqMTqLg=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=DS++qfJhBVBpPfZQQFF5vcLAZZcwiZwFUysrjJ2/axskFUYO/ukrOlIYukPveyvBQEkd0LY4YwRSHAjkdN3cJHsP7e5F7Z0KNxXU0J+zs7dB22lG8CYph1MqxR3pajbWBKbe4hOb/Ys617oAEy6lhcGaou6Fpbh9axO7L3bM2B4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=eXJ1bdUq; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Wtfvm222; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="eXJ1bdUq"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Wtfvm222" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763476960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KcIjluc6CF4ch514Lk0ctcAIz2wl4W9d5ngSIs1tzo4=; b=eXJ1bdUqf49FF6ndjyOR9UwJVTF3oT23GWkFZRWSPXdAbbY3xCjTEgc8TlHYumSigpOvxq 6MpUiMG4kOPVHO0kZOQicTyG6ZKcunYAQoprfIKoidhNmq/0gQYS7zzg+Dk3vpPxcAhY5j f2vWQRmaQWnAfkBTuUh//am+hAEItjY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-1rEEtMduPhW0L7Pk4Fx5mw-1; Tue, 18 Nov 2025 09:42:39 -0500 X-MC-Unique: 1rEEtMduPhW0L7Pk4Fx5mw-1 X-Mimecast-MFC-AGG-ID: 1rEEtMduPhW0L7Pk4Fx5mw_1763476958 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-477a11d9e67so17253335e9.2 for ; Tue, 18 Nov 2025 06:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1763476958; x=1764081758; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=KcIjluc6CF4ch514Lk0ctcAIz2wl4W9d5ngSIs1tzo4=; b=Wtfvm222xsbY46cxLBDmisKxUJ+vS1Dsnb6JHq/NjxfN36hDT6vdJ/iNmfUtDuO1ih vAoS4FyclYHJdi2l3Dl1rTT2jQnbn+8a+KI7hgzkg3tHYRJu8RP9i5YTAd7xtFcjSzlJ DZ/rICeAguRJfv8OQORo3TZHMVmVinKzkprDg9EIxsMXbmKNZXtqtEpdOFYrCMM/SozH zPK9BseTQTuKv9MoOuBBu9coa4qvIvXOwOZuvgM4xfWF+OvBvTiaHdFqIyPFaxPnCemF 9ppBA+Ha1eP46VFG76gfYWnqaidFfPrmBhftfaa62BsFSXI7UpZBcobo3+AdTnfhtllU u1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763476958; x=1764081758; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KcIjluc6CF4ch514Lk0ctcAIz2wl4W9d5ngSIs1tzo4=; b=gvhoDBfgDFcvo+hanH57gJU01axDUcm3EVaW8cW2jQXHY9Dub2D8Q61Wpb+cRKjcQB /vKac2to+aXT46NOjpaad8k0Mx+Z8IiJDdCxETXwnhxxPxMnQkKt7zOlrx1q1lM52eWB RGd8oXB3TTi8eewU3bjODpqScs8WwceuS3R7ozCaZvhNKeO2i2lXcJVNDj7ln8W1E7Gu Xp3RNBemdagN8NGZhaiRvR8fyD4tiUJXXdZY3+3Kx9NnzUSIgQWpa6ErXM2whb+VuHSN D0wQiwUJDPOdz8J6eEfHreKbzkcGRBwnGMyRmx/yF4UoYr28tO0RDihFPT1NcYuRAjI1 r21w== X-Forwarded-Encrypted: i=1; AJvYcCWl/IePPGZ+uZ625g4U0CtM8edCgT7CSOOS6R5yOl6kFOrMAdCZgIJGvJWAwgnqWyWNhmI1wfd5O5b7XP8=@vger.kernel.org X-Gm-Message-State: AOJu0YwMyXB1GW/xZWb2qhKv0kUfzi2MOxj1b/pjBSgB7G1INLawgjX3 Ey24nzgzW7FgxjcheIppsjgHQhzXfUqbbIqULuHUTK/ZvvtJjzpNIrBRjGjGrTNrnn9WMElqwCN r2vIzhviaj808fvbZBAvPemE9Ux9tmKUz4DsJDv4pj/T1I9GVaOLM6gBX3nr6HoG8tA== X-Gm-Gg: ASbGncuv8F6gFR0EjKYZor6LDFhXUi9WMykNxl36xFragztZrSDw11ilWvaZ15O960a mnfL6Hm+YOuM2wCkflhU6MK+bmi3WTlq1hYHXIVRICfBzzp5ytcVLaWnVRJa4aPzpBMamARCltL Bja2UlP8+iKqHCheueZCmE80njerLgP8HAV+t91HXpAP5x+/z8evun3DwOZIuizkrqV7zNz2loK H+nker/hMmbvkweVglKQykuBml0JnIMvVcjQVMfWHZS+7JaL+8o3yNwqJZIIBvbQZpJTkGsJg1o ubPM0E+0dxiF6cK/oM5anLpBdiyItSV2h4L7FiLwyg6srJyxOL/ZJxkI21sC9zBKT8t9AWz6FIk PrUpjb1Z1mvkh X-Received: by 2002:a05:600c:c177:b0:471:13dd:baef with SMTP id 5b1f17b1804b1-4778fea3048mr167899365e9.26.1763476958175; Tue, 18 Nov 2025 06:42:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IG0CCY6x+8bA07W4MfE2Q3iuNu7PIm0BhBaWtRwjXdbvpokwwW2evCf1FYfJCFjxSD0LjK6Ug== X-Received: by 2002:a05:600c:c177:b0:471:13dd:baef with SMTP id 5b1f17b1804b1-4778fea3048mr167899055e9.26.1763476957729; Tue, 18 Nov 2025 06:42:37 -0800 (PST) Received: from [192.168.88.32] ([212.105.155.41]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-477a9741cbfsm19503645e9.6.2025.11.18.06.42.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 06:42:37 -0800 (PST) Message-ID: <53b3ac97-830a-47fc-a83c-3d12dac2e21a@redhat.com> Date: Tue, 18 Nov 2025 15:42:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] net: stmmac: add clk_prepare_enable() error handling From: Paolo Abeni To: Pavel Zhigulin , Andrew Lunn Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Maxime Coquelin , Alexandre Torgue , Maxime Chevallier , Inochi Amaoto , Quentin Schulz , Joe Hattori , Rayagond Kokatanur , Giuseppe CAVALLARO , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org References: <20251114142351.2189106-1-Pavel.Zhigulin@kaspersky.com> <4a3a8ba2-2535-461d-a0a5-e29873f538a4@redhat.com> Content-Language: en-US In-Reply-To: <4a3a8ba2-2535-461d-a0a5-e29873f538a4@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/18/25 3:30 PM, Paolo Abeni wrote: > On 11/14/25 3:23 PM, Pavel Zhigulin wrote: >> The driver previously ignored the return value of 'clk_prepare_enable()' >> for both the CSR clock and the PCLK in 'stmmac_probe_config_dt()' function. >> >> Add 'clk_prepare_enable()' return value checks. >> >> Found by Linux Verification Center (linuxtesting.org) with SVACE. >> >> Fixes: bfab27a146ed ("stmmac: add the experimental PCI support") >> Signed-off-by: Pavel Zhigulin >> --- >> v2: Fix 'ret' value initialization after build bot notification. >> v1: https://lore.kernel.org/all/20251113134009.79440-1-Pavel.Zhigulin@kaspersky.com/ >> >> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 11 +++++++++-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> index 27bcaae07a7f..8f9eb9683d2b 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c >> @@ -632,7 +632,9 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) >> dev_warn(&pdev->dev, "Cannot get CSR clock\n"); >> plat->stmmac_clk = NULL; >> } >> - clk_prepare_enable(plat->stmmac_clk); >> + rc = clk_prepare_enable(plat->stmmac_clk); >> + if (rc < 0) >> + dev_warn(&pdev->dev, "Cannot enable CSR clock: %d\n", rc); >> } >> >> plat->pclk = devm_clk_get_optional(&pdev->dev, "pclk"); >> @@ -640,7 +642,12 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) >> ret = plat->pclk; >> goto error_pclk_get; >> } >> - clk_prepare_enable(plat->pclk); >> + rc = clk_prepare_enable(plat->pclk); >> + if (rc < 0) { >> + ret = ERR_PTR(rc); >> + dev_err(&pdev->dev, "Cannot enable pclk: %d\n", rc); >> + goto error_pclk_get; >> + } > > It looks like the driver is supposed to handle the > IS_ERR_OR_NULL(plat->pclk) condition. This check could cause regression > on existing setup currently failing to initialize the (optional) clock > and still being functional. I'm sorry, ENOCOFFEE above, ->pclk is not NULL nor ERR when clk_prepare_enable() fails. Still I don't stmmac code depending pclk being successfully initialized, and the eventual regression looks like a real possibility. /P