From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A033830CDBC for ; Mon, 23 Feb 2026 02:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771814833; cv=none; b=mB9pNTVCg4MP31qxgc0h7zlw6uT5L2Zoa6EvI53WckOYitYdtzdRKbUWBsNXvqatXmIfHlG8Xk9LxGoCvOK5jC2fQTZkarKokD4ucrMEPXzH7ZUXtFgCTHbShnEtdGTCF05FLPi4qGJ9hrs4ArUDjLx4G56d2+BPB+VJD4QnSzQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771814833; c=relaxed/simple; bh=OvlDgSEqgnw3+FfD5yagaZpNIOH7xzw99QWYrpbrtVs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AazXOT7L1B8/M5ImF2kifWlHYIwK5a47zs0XlbroRXKvPtF+utvMMRe/8uNnWZOGSw6P9n7Eq2ra4TtgZmnN9vr/bGKs2Ypf+rnUbaNGn+J8zOf8w97+ybsKexvSejR8X8RO/x2/WLEbl1pURPOpSQTWpjpr9n4VDVw4m2OTYMA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=ZCYkyIXL; arc=none smtp.client-ip=115.124.30.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="ZCYkyIXL" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1771814827; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=oVdh8jhbOgmCfVl3Zcbm6neqLdmc0cLpE3ItMDoHJYU=; b=ZCYkyIXLFJvWC0RwhU7VwOtSrwcKsri5lomlDcSDQ5px4LE5qZQ89uJ6Qrt2ncPxNRHoyFaB6JZ4hnqNHnLjgGq+sYH4X1dxPgc8QGN5lvqG2Xa84+qlzvyjkFRmiXR/HJnGF0uLLHwwGNCLh1ni973iDnlQNwnZ0vsjycReLcM= Received: from 30.42.59.174(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0WzctCGz_1771813892 cluster:ay36) by smtp.aliyun-inc.com; Mon, 23 Feb 2026 10:31:33 +0800 Message-ID: <53b460ff-6744-4bd2-a000-5a1aaf08eed0@linux.alibaba.com> Date: Mon, 23 Feb 2026 10:31:32 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] erofs: allow sharing page cache with the same aops only To: Hongbo Li , xiang@kernel.org, chao@kernel.org Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org References: <20260214030248.771925-1-lihongbo22@huawei.com> From: Gao Xiang In-Reply-To: <20260214030248.771925-1-lihongbo22@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/2/14 11:02, Hongbo Li wrote: > Inode with identical data but different @aops cannot be mixed > because the page cache is managed by different subsystems (e.g., > @aops for compressed on-disk inodes cannot handle plain on-disk > inodes). > > In this patch, we never allow inodes to share the page cache > among plain, compressed, and fileio cases. When a shared inode > is created, we initialize @aops that is the same as the initial > real inode, and subsequent inodes cannot share the page cache > if the inferred @aops differ from the corresponding shared inode. > > This is reasonable as a first step because, in typical use cases, > if an inode is compressible, it will fall into compressed > inodes across different filesystem images unless users use plain > filesystems. However, in that cases, users will use plain > filesystems all the time. > > Fixes: 5ef3208e3be5 ("erofs: introduce the page cache share feature") > Signed-off-by: Hongbo Li Reviewed-by: Gao Xiang Thanks, Gao Xiang