From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4287EC433E6 for ; Wed, 22 Jul 2020 10:27:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 187B320729 for ; Wed, 22 Jul 2020 10:27:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732068AbgGVK1Z (ORCPT ); Wed, 22 Jul 2020 06:27:25 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:48156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729864AbgGVK1Y (ORCPT ); Wed, 22 Jul 2020 06:27:24 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 32F7A529B907B31831DB; Wed, 22 Jul 2020 18:27:15 +0800 (CST) Received: from [127.0.0.1] (10.174.179.92) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Wed, 22 Jul 2020 18:27:05 +0800 Subject: Re: [PATCH v1 1/2] {topost} scsi: libsas: delete postreset at sas_sata_ops To: Luo Jiaxing , , CC: , , , , References: <1595408643-63011-1-git-send-email-luojiaxing@huawei.com> <1595408643-63011-2-git-send-email-luojiaxing@huawei.com> From: Jason Yan Message-ID: <53b95bb4-c129-beff-9bc6-02225db2e762@huawei.com> Date: Wed, 22 Jul 2020 18:27:04 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <1595408643-63011-2-git-send-email-luojiaxing@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.92] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2020/7/22 17:04, Luo Jiaxing дµÀ: > We fill postreset with ata_std_postreset() at sas_sata_ops before, but we > found out that ata_std_postreset() call sata_scr_read()/sata_scr_write() > which need to access SCR register. Actually we don't own these kind of > register, so sata_scr_read()/sata_scr_write always return -EOPNOTSUPP. > > We drop ata_std_postreset() at sas_sata_ops. > > Signed-off-by: Luo Jiaxing > Reviewed-by: John Garry > --- > drivers/scsi/libsas/sas_ata.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c > index 5d716d3..a7d16d2 100644 > --- a/drivers/scsi/libsas/sas_ata.c > +++ b/drivers/scsi/libsas/sas_ata.c > @@ -510,7 +510,6 @@ void sas_ata_end_eh(struct ata_port *ap) > static struct ata_port_operations sas_sata_ops = { > .prereset = ata_std_prereset, > .hardreset = sas_ata_hard_reset, > - .postreset = ata_std_postreset, > .error_handler = ata_std_error_handler, > .post_internal_cmd = sas_ata_post_internal, > .qc_defer = ata_std_qc_defer, > Hi Luo, Please remove the "{topost}" in the subject, other than that: Reviewed-by: Jason Yan