From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 888C0ECE58D for ; Wed, 9 Oct 2019 15:37:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6BDC721848 for ; Wed, 9 Oct 2019 15:37:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731557AbfJIPhg (ORCPT ); Wed, 9 Oct 2019 11:37:36 -0400 Received: from mga06.intel.com ([134.134.136.31]:3516 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729742AbfJIPhg (ORCPT ); Wed, 9 Oct 2019 11:37:36 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Oct 2019 08:37:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,276,1566889200"; d="scan'208";a="223620857" Received: from mmahler-mobl1.amr.corp.intel.com (HELO [10.251.30.188]) ([10.251.30.188]) by fmsmga002.fm.intel.com with ESMTP; 09 Oct 2019 08:37:33 -0700 Subject: Re: [alsa-devel] [PATCH v2 3/5] ASoC: core: add support to snd_soc_dai_get_sdw_stream() To: Srinivas Kandagatla , Vinod Koul , Mark Brown Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, linux-kernel@vger.kernel.org, plai@codeaurora.org, lgirdwood@gmail.com, robh+dt@kernel.org, spapothi@codeaurora.org References: <20190813083550.5877-1-srinivas.kandagatla@linaro.org> <20190813083550.5877-4-srinivas.kandagatla@linaro.org> <20190813191827.GI5093@sirena.co.uk> <20190813195804.GL5093@sirena.co.uk> <20190814041142.GU12733@vkoul-mobl.Dlink> <99d35a9d-cbd8-f0da-4701-92ef650afe5a@linux.intel.com> <5e08f822-3507-6c69-5d83-4ce2a9f5c04f@linaro.org> From: Pierre-Louis Bossart Message-ID: <53bb3105-8e85-a972-fce8-a7911ae4d461@linux.intel.com> Date: Wed, 9 Oct 2019 09:29:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <5e08f822-3507-6c69-5d83-4ce2a9f5c04f@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/9/19 3:32 AM, Srinivas Kandagatla wrote: > Hi Pierre, > > On 14/08/2019 15:09, Pierre-Louis Bossart wrote: >> >> >> On 8/13/19 11:11 PM, Vinod Koul wrote: >>> On 13-08-19, 20:58, Mark Brown wrote: >>>> On Tue, Aug 13, 2019 at 02:38:53PM -0500, Pierre-Louis Bossart wrote: >>>> >>>>> Indeed. I don't have a full understanding of that part to be >>>>> honest, nor why >>>>> we need something SoundWire-specific. We already abused the >>>>> set_tdm_slot API >>>>> to store an HDaudio stream, now we have a rather confusing stream >>>>> information for SoundWire and I have about 3 other 'stream' >>>>> contexts in >>>>> SOF... I am still doing basic cleanups but this has been on my >>>>> radar for a >>>>> while. >>>> >>>> There is something to be said for not abusing the TDM slot API if it >>>> can >>>> make things clearer by using bus-idiomatic mechanisms, but it does mean >>>> everything needs to know about each individual bus :/ . >>> >>> Here ASoC doesn't need to know about sdw bus. As Srini explained, this >>> helps in the case for him to get the stream context and set the stream >>> context from the machine driver. >>> >>> Nothing else is expected to be done from this API. We already do a set >>> using snd_soc_dai_set_sdw_stream(). Here we add the >>> snd_soc_dai_get_sdw_stream() to query >> >> I didn't see a call to snd_soc_dai_set_sdw_stream() in Srini's code? > > > There is a snd_soc_dai_get_sdw_stream() to get stream context and we add > slave streams(amplifier in this case) to that context using > sdw_stream_add_slave() in machine driver[1]. > > Without this helper there is no way to link slave streams to stream > context in non dai based setup like smart speaker amplifiers. > > Currently this driver is blocked on this patch, If you think there are > other ways to do this, am happy to try them out. So to be clear, you are *not* using snd_soc_dai_set_sdw_stream?