From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BDD91B87CA for ; Mon, 23 Dec 2024 20:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=96.67.55.147 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734985273; cv=none; b=mSFwSvAFZXuX9decao+rdPqSWXsKXWBdr88Cwf91aIQWLqpKPUSZ//FXygpoSnVAgeMziDz/GPb4313Q+a8+nma4oZA3Ox9sOFq2pcb+acw5ZxoxV44FgzPFucG8Nsgu8zwom6dC+Xpaz1tfHTR3UJnueKZMT0kbIU3i5aoU3ao= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734985273; c=relaxed/simple; bh=G5WNcanDGnHtD2gfx2cf0zwIBwSS2AnstRnzyFraAS0=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=U++cIp3NPK13ocRqkNJSczuF7T5ex7BkgUXAvEvTvBgbDyMEGTOvfzYpbLM90KtCyOm+Eqv1HJAUJ2/VaCquC96Z0GT1BRa1TmPBtRi3dQVaJt+G4gopRR+xx5GKxW4GXlpXn3sZkfl0lUPqqFCTgL2uBCM+CwD6mbaer9EBFWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com; spf=pass smtp.mailfrom=shelob.surriel.com; arc=none smtp.client-ip=96.67.55.147 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=surriel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=shelob.surriel.com Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tPouf-00000000619-3vev; Mon, 23 Dec 2024 15:20:25 -0500 Message-ID: <53c9c3784a8136f41ac3c6ec3725af406f5394a5.camel@surriel.com> Subject: Re: [PATCH 01/11] x86/mm: make MMU_GATHER_RCU_TABLE_FREE unconditional From: Rik van Riel To: Qi Zheng Cc: x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, linux-mm@kvack.org Date: Mon, 23 Dec 2024 15:20:25 -0500 In-Reply-To: References: <20241223025751.3268975-1-riel@surriel.com> <20241223025751.3268975-2-riel@surriel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Sender: riel@surriel.com On Mon, 2024-12-23 at 14:01 +0800, Qi Zheng wrote: > Very happy to see this change! >=20 >=20 > > @@ -191,7 +186,7 @@ struct paravirt_patch_template pv_ops =3D { > > =C2=A0=C2=A0 .mmu.flush_tlb_kernel =3D native_flush_tlb_global, > > =C2=A0=C2=A0 .mmu.flush_tlb_one_user =3D > > native_flush_tlb_one_user, > > =C2=A0=C2=A0 .mmu.flush_tlb_multi =3D native_flush_tlb_multi, > > - .mmu.tlb_remove_table =3D native_tlb_remove_table, > > + .mmu.tlb_remove_table =3D tlb_remove_table, > > =C2=A0=20 > > =C2=A0=C2=A0 .mmu.exit_mmap =3D paravirt_nop, > > =C2=A0=C2=A0 .mmu.notify_page_enc_status_changed =3D paravirt_nop, >=20 > It look like this patch series is not based on the latest linux-next. >=20 That is correct. I based this on tip.git x86/mm, since that seems like the most likely destination for this code. > In addition to the above case, maybe the paravirt_tlb_remove_table() > in arch/x86/mm/pgtable.c also needs to be changed to > tlb_remove_table()? I'll get that in the next version. Thank you for reviewing the patch! --=20 All Rights Reversed.