From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com [209.85.215.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0435543E4AC for ; Tue, 4 Aug 2026 08:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832929; cv=none; b=uiUiqMj86QT/AXc5dTrQJmwS3JdKKpC1A4V7DkRmaBmvpwRZfg3U7yJYDVruMjlFcTvNRLHikfyomqBLD5l3mlJdeBjx/rn3/VtZVoamw/W86FWOp58+aeCQxbhAVVCm5nAoR+FyFhpP2QcG2H1tuKaIlzSfBMB6Cm5m0PsHgLA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785832929; c=relaxed/simple; bh=SD2jpuPrRshOPjZPDhOULtKF/IyS30DOHYKRJQ1eYRs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eCAtrztFPopWGkFoNg2k8RWDhLIaWpTVU4Ma4ppGNt+rXDbAXvRztZ50bo53IzLCi7b2HfdbBcDkMwQV+HjfaIs1Sj9tKlJoD0xDaupnTBExEmBmlwcQr49UOTVFYaDYJy6hXfkC3kG6LWCwzmw6YpHAvdEH5QEP1m2hmaORe4Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PA0v0brP; arc=none smtp.client-ip=209.85.215.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PA0v0brP" Received: by mail-pg1-f170.google.com with SMTP id 41be03b00d2f7-c9c26a5fb98so533154a12.0 for ; Tue, 04 Aug 2026 01:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785832926; x=1786437726; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U2I8sdYMfYJjOc8dSgSE9HfEVezQOKs2ggEWu0ibP00=; b=PA0v0brPxdaG3MEMmRscI/ZEK7lPZvVtloK+bV3z/F9OTMQIQYQK3/DIi4u1GI7qFN loGlkGRq//5VBuMSUY8lNrmwfGcdY4Dc3skR5sZU+/7VijefGzbiWad1oWBUhNiRIcBR cATciU315li3smb1VkkPjTv/WGRzNvjMRooeuj3M8NegTKCk5+CniXtcBKbrwzdX5Ppk AEZ81m5gD/uKb6SuQr7oj0ccxoRAvDdPkdHbgbpQj8hdWtBtKR3OCIc+XDmV+K49o6JU g8ze6gtlfWfC4/AeGKb2PunLoQvQYsHnEgqI3aEJhVqD8xaegcnxUAv7aD+3NAQ+DF75 YToA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785832926; x=1786437726; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U2I8sdYMfYJjOc8dSgSE9HfEVezQOKs2ggEWu0ibP00=; b=AieEXRDKOIUYszAqTvSK87g2HvEM8ygXVaF5mZr2ZGEAbxw+TaiSMkrkwoa89uvFx1 AA+gE+tKzwTAJglsJMdzA/XcBOMc/BLfjOVarB5vuVEREYvBaArHiOhlJLH+tpGxjuO9 9DT2f759OhZW4ukiMcokpBdA48MWZSOkvkHJDgZPS688ST+medV0aEOpcKbTHNkMJ8iS zT1mH31OnowhIvuzMyLLRMJxzXdMUHJoS8i5/ID3jXmfQZdLrzdsX4asnwcgjBJhsiYl 1X7kpELAO2KUq3krTm0NHVEaerIKySBPpw+f67ZxmbBRZbIfWwFvw+8GBT4nOr9+UBmy jMRQ== X-Forwarded-Encrypted: i=1; AHgh+RoJ/ncZ0ge/5wfbIusrr1129IXfKJLBwM72s7MK0ZtBs5Hj4NYlUosR4yXMJqldd41cMV4c1VNMBJH4Vx4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz6vCoj1FtldWf4vTz1QGdvI8zJFWgKqGcZU2pA5a6dpgsHdnTE UBkULweKbauO+naeOwlPLbCtkfUBHRq2OPB1d3cfXWJLDbciJKYgfrph X-Gm-Gg: AR+sD12ZamMiU8Nr0TTJT1TLcUjWyXOf1i/yT2p/1cihUxdFCZd+0sD1m3JZQJyGRzD faj+Bb+Nu8DjrcJVzZVnF51eBI0dQ8eg3kYIHWAYUMm8ZbcCZvw7A4zdc5em4nKjhqcm/p+oOzR 8VUNixLpXczdAM/9IX0gGETDCZ7/V6R5Vl39nHbNl04Ha5KhqD7FXOeBOPrlPfq/h9m9BFOldDc cL+eF01JIGz8Qdl5Xhh7ce4Tg/s5lnO2rjdNRAUf5YT3GJuiqrMpAOmgUkWS7zJccjfZjSbI0/O ZwzgpZ4RWRkM+5aQPWjKwhLv7OnPgXBevYGlLUuD/pBm1x9CB1YH6X1OglcveDezcaabu0jWH7I g7YOqWnfkp7w9rGrOSmSW3eL7HdgtyGDYauB7P1vQcMZhP3MqEPigAr1n+pRevRjlIGq173HX6u tswqWTEky/h9dN5bXvIlxd1Uu9ifNdF7x2R9tSkGQg6PR6a5xUem75uJWRJTsfJBKxw3lbdjtZ/ yF3VgRP4nBOR9fNRCutysBfYV+fwEUNebfRzS5Xrc4cnOQ6VZOP8Ks1NwJ1QmS2y5Nx4yP1H3mt oWlTZcNrLl4bM45gX25M X-Received: by 2002:a05:6a20:9188:b0:3bf:6c27:38b with SMTP id adf61e73a8af0-3cb6c937c3amr2601207637.29.1785832926102; Tue, 04 Aug 2026 01:42:06 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325:77fd:1068:74c8:af87? ([2620:10d:c092:600::1:541b]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cbe39ea0a73sm4753273a12.23.2026.08.04.01.41.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 01:42:05 -0700 (PDT) Message-ID: <53c9cf90-4284-4b6a-ab2f-1686c7461bf8@gmail.com> Date: Tue, 4 Aug 2026 09:41:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 09/16] nvme-pci: implement dma-buf backed requests To: Anuj Gupta/Anuj Gupta , Jens Axboe , Keith Busch , Christoph Hellwig , Sagi Grimberg , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org Cc: Alexander Viro , Christian Brauner , Andrew Morton , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Nitesh Shetty , Kanchan Joshi , Jason Gunthorpe , Damien Le Moal , Alasdair Kergon , Mike Snitzer , Mikulas Patocka , Benjamin Marzinski , David Sterba , Ilya Dryomov , dm-devel@lists.linux.dev, nvdimm@lists.linux.dev, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org References: <9e3dd1b2d71dc0f9bd556b6a6d6e48fb6a8d727b.1785596451.git.asml.silence@gmail.com> Content-Language: en-US From: Pavel Begunkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/4/26 08:29, Anuj Gupta/Anuj Gupta wrote: > On 8/1/2026 9:16 PM, Pavel Begunkov wrote: ...>> + if (WARN_ON_ONCE(seg_shift < NVME_CTRL_PAGE_SHIFT)) >> + return ERR_PTR(-EFAULT); > > This should be 'goto err;' instead of a direct return. If this ever > triggers, it leaks the map and already established sgt mapping. I can change it as I'm going to respin the series anyway, but it doesn't really matter here as it's a warning and shouldn't happen. -- Pavel Begunkov