From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [121.127.44.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 185AD23EA89 for ; Sun, 10 May 2026 19:13:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=121.127.44.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440400; cv=none; b=A31QO2emOe/ZZGajr/nM/UHYgUZqc+KxggGAdaIZXb92SRG1ePMP2H39s3b4LOIhNefSLwIAi186886nYmkNRH17MhICkj/yhxrPnuYT4AMqCMIlhWSGLVPSGsaE/3JHpezv5v1Q3KhNsfVlIoflZVswQN6C5vs8ngRtKxbMLRQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440400; c=relaxed/simple; bh=dq9LWOfEMa6mWBrR9eIcD8UY9Fz7WywaKBCRPMQneuE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UhDA5KYTfYB9Pb2DAryAzXwQK+C+y+E9KqTdoErZejTS2P57YcwI00KOiC513UzgJouRlN+7vCqIzXAPIRTccaPfE4m2wpcL4i6gpJYwiuzBnNom9fToEccrpWx5kQNzCmpExftfh+sIGjewTTlGi804qT2GhcG/mh8KfkupQ5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=Rjid8zd4; arc=none smtp.client-ip=121.127.44.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="Rjid8zd4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: From: References: Cc: To: Subject: MIME-Version: Date: Message-ID; q=dns/txt; s=fe-e1b5cab7be; t=1778440387; bh=8NtVp+XegjZHVec+TG++C7hqL/jdKwHQkADv6jK3v0Y=; b=Rjid8zd4ZFwJpN5Ma7/0obujCbNQRbCDp9kGHs6+gr7Q0PpNJMfTV6Ti5MBusPj+1scPnvk0n txAzVNfL8x700aGDKT7TOUZT2UDq+XnatC3nKZDZTKhmz5lGclUyzWunE92360BSX6JuxMU1XLg mL1PdjUROKcx9LMv4XOu9YWYCfCpoOl8JIi9apmEfGmY/gwDTu/gO0G35huPcIlT0n9hk84nQ8o qn0DqHJ67ZDNI7mymbLWwkITB6b2rArTYox877/PO3gqcQFdxfngh8a2u0GNGIT+XL0AGgsADxf GO9CJgfwDkht9AL9S8Z9kqUALV/URfsy1thRL0pZFIcg== X-Forward-Email-ID: 6a00d88e8983a631c215f734 X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.66 X-Forward-Email-Version: 2.8.0 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net Message-ID: <53e09f70-c449-49bb-b2a0-636d5d4bd395@kwiboo.se> Date: Sun, 10 May 2026 21:12:08 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/4] drm/rockchip: dw_hdmi: Apply DRM_BRIDGE_ATTACH_NO_CONNECTOR and the bridge-connector To: Damon Ding Cc: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, hjc@rock-chips.com, heiko@sntech.de, andy.yan@rock-chips.com, wens@kernel.org, samuel@sholland.org, luca.ceresoli@bootlin.com, Laurent.pinchart@ideasonboard.com, jernej.skrabec@gmail.com, victor.liu@nxp.com, dmitry.baryshkov@oss.qualcomm.com, shengjiu.wang@nxp.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20260403070032.447102-1-damon.ding@rock-chips.com> <20260403070032.447102-4-damon.ding@rock-chips.com> Content-Language: en-US From: Jonas Karlman In-Reply-To: <20260403070032.447102-4-damon.ding@rock-chips.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Damon, On 4/3/2026 9:00 AM, Damon Ding wrote: > Convert this driver to DRM_BRIDGE_ATTACH_NO_CONNECTOR and to the > drm_bridge_connector framework which is the current DRM bridge best > practice. Changing to use the bridge connector at this stage will cause the Rockchip platform to drop features the dw-hdmi connector currently only can provide, e.g. a CEC notifier, some connector properties and more. I am also currently working on a multi series effort to: - phy: rockchip: inno-hdmi: Change TMDS rate handling to configure() ops [v2] - drm/rockchip: dw_hdmi: Misc cleanup and propagate bus format [v1] - drm: bridge: dw_hdmi: Misc enable/disable, CEC and EDID cleanup [v5] - drm/bridge: dw-hdmi: Improve input/output bus format handling - drm/bridge: dw-hdmi: Convert to a HDMI bridge and use of bridge connector - drm/bridge: dw-hdmi: Add and use tmds_char_rate_valid() plat data ops - drm/meson: hdmi: Misc cleanup and use CEC notifier helpers - drm/rockchip: dw_hdmi: Enable YCbCr and Deep Color modes Link to snapshot: https://github.com/Kwiboo/linux-rockchip/commits/next-20260508-rk-hdmi-v3/ Part of that effort include to fully convert the dw-hdmi bridge into a HDMI bridge, something that is required to fully be able to replace all features currently provided by the use of the dw-hdmi connector. In that effort I have also taken a different approach and instead replace the dw-hdmi connector with the bridge connector directly from inside the dw-hdmi bridge driver. Regards, Jonas > Signed-off-by: Damon Ding > --- > drivers/gpu/drm/rockchip/Kconfig | 1 + > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 19 +++++++++++++++---- > 2 files changed, 16 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig > index e7f49fe845ea..69b832d0c8c4 100644 > --- a/drivers/gpu/drm/rockchip/Kconfig > +++ b/drivers/gpu/drm/rockchip/Kconfig > @@ -76,6 +76,7 @@ config ROCKCHIP_DW_DP > > config ROCKCHIP_DW_HDMI > bool "Rockchip specific extensions for Synopsys DW HDMI" > + select DRM_BRIDGE_CONNECTOR > help > This selects support for Rockchip SoC specific extensions > for the Synopsys DesignWare HDMI driver. If you want to > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > index 21b141b7cb9c..b5cfcb936078 100644 > --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c > @@ -13,6 +13,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -542,6 +543,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > struct drm_device *drm = data; > struct drm_encoder *encoder; > struct rockchip_hdmi *hdmi; > + struct drm_connector *connector; > int ret; > > if (!pdev->dev.of_node) > @@ -608,7 +610,7 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > > platform_set_drvdata(pdev, hdmi); > > - hdmi->hdmi = dw_hdmi_bind(pdev, encoder, plat_data, 0); > + hdmi->hdmi = dw_hdmi_bind(pdev, encoder, plat_data, DRM_BRIDGE_ATTACH_NO_CONNECTOR); > > /* > * If dw_hdmi_bind() fails we'll never call dw_hdmi_unbind(), > @@ -616,12 +618,21 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > */ > if (IS_ERR(hdmi->hdmi)) { > ret = PTR_ERR(hdmi->hdmi); > - goto err_bind; > + goto err_cleanup_encoder; > } > > - return 0; > + connector = drm_bridge_connector_init(drm, encoder); > + if (IS_ERR(connector)) { > + ret = PTR_ERR(connector); > + dev_err(hdmi->dev, "Failed to initialize bridge_connector\n"); > + goto err_unbind_bridge; > + } > > -err_bind: > + return drm_connector_attach_encoder(connector, encoder); > + > +err_unbind_bridge: > + dw_hdmi_unbind(hdmi->hdmi); > +err_cleanup_encoder: > drm_encoder_cleanup(encoder); > > return ret;