From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 414F83469E3 for ; Thu, 22 Jan 2026 13:48:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769089729; cv=none; b=FqE/wWbddK6kFBtsgH3NWyzutTwbe6jKAIsr8XKy9pMrBRDKamUFbePcMBMAK6TwWtMSpjfPhOvaofftybOGk2rAVzYtfbzwOPXD2Y5DpZV1jhprzV3u66TP1ftBW9h9cgYhmdPkl2MEyO5QfZCE5HO4VlxubjW8tLm/iaTYpeU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769089729; c=relaxed/simple; bh=Ik3isZg69uy819qCA91x8tXe6oJnuxTiAK4/NmF4g1Y=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=qsfiBSkvWQD0Dgs2+pfccJRH1+bqDXK7cK06riDsnp3L/6iCjU5wOx131+Fz3ABtFU+11O2lKr7Bv0YgjBvlR0k7AfMYlwQJKnO8VB5M8DKNywOFdjZdxbRt3unCiaLMYxY9qI4N+1XDV/jzlDHPWkfGvnDoWXfVkRZXKExXI0w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=Sl2XTA+U; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Sl2XTA+U" Received: from [192.168.88.20] (91-158-153-178.elisa-laajakaista.fi [91.158.153.178]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A7192DD; Thu, 22 Jan 2026 14:48:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1769089691; bh=Ik3isZg69uy819qCA91x8tXe6oJnuxTiAK4/NmF4g1Y=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=Sl2XTA+UElZ9ef4UJoUdLx3lzU+CLfjm8/NBvv/AU0xsmOv2+JWteJQIafdypUJr5 cdOtEzkup0Pg7IjQbxaceKTySqiWWS4yg4aFRXK2zxe8xsszu7t1riuT5Ah18BHFX4 RBbzuz3UeThEbVkULOdhBrYxIjZSE4fc3sN30s2w= Message-ID: <53e73b84-e2e1-42d7-afc9-f9bc04e5db37@ideasonboard.com> Date: Thu, 22 Jan 2026 15:48:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Tomi Valkeinen Subject: Re: [PATCH v2 0/4] drm: zynqmp: Make the video plane primary To: Sean Anderson , Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: Simona Vetter , Thomas Zimmermann , linux-kernel@vger.kernel.org, Maxime Ripard , David Airlie , linux-arm-kernel@lists.infradead.org, Michal Simek , Anatoliy Klymenko , Maarten Lankhorst , Mike Looijmans References: <20260106164247.472544-1-sean.anderson@linux.dev> Content-Language: en-US Autocrypt: addr=tomi.valkeinen@ideasonboard.com; keydata= xsFNBE6ms0cBEACyizowecZqXfMZtnBniOieTuFdErHAUyxVgtmr0f5ZfIi9Z4l+uUN4Zdw2 wCEZjx3o0Z34diXBaMRJ3rAk9yB90UJAnLtb8A97Oq64DskLF81GCYB2P1i0qrG7UjpASgCA Ru0lVvxsWyIwSfoYoLrazbT1wkWRs8YBkkXQFfL7Mn3ZMoGPcpfwYH9O7bV1NslbmyJzRCMO eYV258gjCcwYlrkyIratlHCek4GrwV8Z9NQcjD5iLzrONjfafrWPwj6yn2RlL0mQEwt1lOvn LnI7QRtB3zxA3yB+FLsT1hx0va6xCHpX3QO2gBsyHCyVafFMrg3c/7IIWkDLngJxFgz6DLiA G4ld1QK/jsYqfP2GIMH1mFdjY+iagG4DqOsjip479HCWAptpNxSOCL6z3qxCU8MCz8iNOtZk DYXQWVscM5qgYSn+fmMM2qN+eoWlnCGVURZZLDjg387S2E1jT/dNTOsM/IqQj+ZROUZuRcF7 0RTtuU5q1HnbRNwy+23xeoSGuwmLQ2UsUk7Q5CnrjYfiPo3wHze8avK95JBoSd+WIRmV3uoO rXCoYOIRlDhg9XJTrbnQ3Ot5zOa0Y9c4IpyAlut6mDtxtKXr4+8OzjSVFww7tIwadTK3wDQv Bus4jxHjS6dz1g2ypT65qnHen6mUUH63lhzewqO9peAHJ0SLrQARAQABzTBUb21pIFZhbGtl aW5lbiA8dG9taS52YWxrZWluZW5AaWRlYXNvbmJvYXJkLmNvbT7CwY4EEwEIADgWIQTEOAw+ ll79gQef86f6PaqMvJYe9QUCX/HruAIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRD6 PaqMvJYe9WmFD/99NGoD5lBJhlFDHMZvO+Op8vCwnIRZdTsyrtGl72rVh9xRfcSgYPZUvBuT VDxE53mY9HaZyu1eGMccYRBaTLJSfCXl/g317CrMNdY0k40b9YeIX10feiRYEWoDIPQ3tMmA 0nHDygzcnuPiPT68JYZ6tUOvAt7r6OX/litM+m2/E9mtp8xCoWOo/kYO4mOAIoMNvLB8vufi uBB4e/AvAjtny4ScuNV5c5q8MkfNIiOyag9QCiQ/JfoAqzXRjVb4VZG72AKaElwipiKCWEcU R4+Bu5Qbaxj7Cd36M/bI54OrbWWETJkVVSV1i0tghCd6HHyquTdFl7wYcz6cL1hn/6byVnD+ sR3BLvSBHYp8WSwv0TCuf6tLiNgHAO1hWiQ1pOoXyMEsxZlgPXT+wb4dbNVunckwqFjGxRbl Rz7apFT/ZRwbazEzEzNyrBOfB55xdipG/2+SmFn0oMFqFOBEszXLQVslh64lI0CMJm2OYYe3 PxHqYaztyeXsx13Bfnq9+bUynAQ4uW1P5DJ3OIRZWKmbQd/Me3Fq6TU57LsvwRgE0Le9PFQs dcP2071rMTpqTUteEgODJS4VDf4lXJfY91u32BJkiqM7/62Cqatcz5UWWHq5xeF03MIUTqdE qHWk3RJEoWHWQRzQfcx6Fn2fDAUKhAddvoopfcjAHfpAWJ+ENc7BTQROprNHARAAx0aat8GU hsusCLc4MIxOQwidecCTRc9Dz/7U2goUwhw2O5j9TPqLtp57VITmHILnvZf6q3QAho2QMQyE DDvHubrdtEoqaaSKxKkFie1uhWNNvXPhwkKLYieyL9m2JdU+b88HaDnpzdyTTR4uH7wk0bBa KbTSgIFDDe5lXInypewPO30TmYNkFSexnnM3n1PBCqiJXsJahE4ZQ+WnV5FbPUj8T2zXS2xk 0LZ0+DwKmZ0ZDovvdEWRWrz3UzJ8DLHb7blPpGhmqj3ANXQXC7mb9qJ6J/VSl61GbxIO2Dwb xPNkHk8fwnxlUBCOyBti/uD2uSTgKHNdabhVm2dgFNVuS1y3bBHbI/qjC3J7rWE0WiaHWEqy UVPk8rsph4rqITsj2RiY70vEW0SKePrChvET7D8P1UPqmveBNNtSS7In+DdZ5kUqLV7rJnM9 /4cwy+uZUt8cuCZlcA5u8IsBCNJudxEqBG10GHg1B6h1RZIz9Q9XfiBdaqa5+CjyFs8ua01c 9HmyfkuhXG2OLjfQuK+Ygd56mV3lq0aFdwbaX16DG22c6flkkBSjyWXYepFtHz9KsBS0DaZb 4IkLmZwEXpZcIOQjQ71fqlpiXkXSIaQ6YMEs8WjBbpP81h7QxWIfWtp+VnwNGc6nq5IQDESH mvQcsFS7d3eGVI6eyjCFdcAO8eMAEQEAAcLBXwQYAQIACQUCTqazRwIbDAAKCRD6PaqMvJYe 9fA7EACS6exUedsBKmt4pT7nqXBcRsqm6YzT6DeCM8PWMTeaVGHiR4TnNFiT3otD5UpYQI7S suYxoTdHrrrBzdlKe5rUWpzoZkVK6p0s9OIvGzLT0lrb0HC9iNDWT3JgpYDnk4Z2mFi6tTbq xKMtpVFRA6FjviGDRsfkfoURZI51nf2RSAk/A8BEDDZ7lgJHskYoklSpwyrXhkp9FHGMaYII m9EKuUTX9JPDG2FTthCBrdsgWYPdJQvM+zscq09vFMQ9Fykbx5N8z/oFEUy3ACyPqW2oyfvU CH5WDpWBG0s5BALp1gBJPytIAd/pY/5ZdNoi0Cx3+Z7jaBFEyYJdWy1hGddpkgnMjyOfLI7B CFrdecTZbR5upjNSDvQ7RG85SnpYJTIin+SAUazAeA2nS6gTZzumgtdw8XmVXZwdBfF+ICof 92UkbYcYNbzWO/GHgsNT1WnM4sa9lwCSWH8Fw1o/3bX1VVPEsnESOfxkNdu+gAF5S6+I6n3a ueeIlwJl5CpT5l8RpoZXEOVtXYn8zzOJ7oGZYINRV9Pf8qKGLf3Dft7zKBP832I3PQjeok7F yjt+9S+KgSFSHP3Pa4E7lsSdWhSlHYNdG/czhoUkSCN09C0rEK93wxACx3vtxPLjXu6RptBw 3dRq7n+mQChEB1am0BueV1JZaBboIL0AGlSJkm23kw== In-Reply-To: <20260106164247.472544-1-sean.anderson@linux.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 06/01/2026 18:42, Sean Anderson wrote: > The graphics plane does not support XRGB8888, which is the default mode > X uses for 24-bit color. Because of this, X must be set to use 16-bit > color, which has a measurable performance penalty. Make the video plane > the primary plane as it natively supports XRGB8888. An alternative > approach to add XRGB8888 to the graphics plane is discussed in [1], as > well as in patch 2. > > [1] https://lore.kernel.org/dri-devel/20250627145058.6880-1-mike.looijmans@topic.nl/ > > Changes in v2: > - Allow specifying blend mode default > - Advertise coverage instead of premulti, since that's what the hardware > supports. > - Set default blend mode to none since that's what the default was > before this series. > > Sean Anderson (4): > drm/drm_blend: Allow specifying blend mode default > drm: zynqmp: Check property creation status > drm: zynqmp: Make the video plane primary > drm: zynqmp: Add blend mode property to graphics plane > > drivers/gpu/drm/drm_blend.c | 22 ++++++------- > drivers/gpu/drm/xlnx/zynqmp_kms.c | 53 +++++++++++++++++++++++++------ > include/drm/drm_blend.h | 26 +++++++++++++-- > 3 files changed, 78 insertions(+), 23 deletions(-) > I think the series looks fine, but there's still the main question of whether making video plane primary is the best choice. I'll summarize my understanding of our two options here: 1) Make video plane primary plane, and thus graphics plane an overlay plane. The downside here is that, at least to me, the plane types feel like they are the wrong way around, and any existing code that depends on the plane type may start to fail. That said, the plane type is supposed to be a legacy thing, and a modern userspace should just look at the plane properties to decide how to use them (which raises the question of why is X/Weston even failing). 2) Add XRGB format to the graphics plane. This should work fine too, as long as we make sure using XRGB with per-pixel alpha will fail (i.e. only global alpha supported with XRGB). Afaics that could be done with a check in atomic_check. Does anyone have strong arguments for either of these options? Tomi