Re: [PATCH v2 1/2] dt-bindings: add bindings for pcd8544 displays

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 19/07/2023 17:44, Viktar Simanenka wrote:
> Signed-off-by: Viktar Simanenka <viteosen@gmail.com>

You still miss commit msg.

> 
> V2: deleted oneOf property from compatible
> changed prefix from 'philips' to existing vendor prefix 'nxp'
> placed `reg = <0>` right after `compatible`

That's not where the changelog is put. Please read again the patch, I
gave you link to.

> 
> About parameters exposed for controller:
> inverted - I had an unbranded display that after reset had all pixels black,
> while register was in 'normal operation'. The display I have now is opposite:
> all white after reset in normal mode. This parameter should help user keep
> same settings in KMS(?) for diverse displays;

OK, it was enough to respond to my comment.

> voltage-op & temperature-coeff - adjusts contrast for display. voltage-op
> cannot be expressed in real units, because resulting equation looks like
> V = a + Vop * b, where a and b varies with ambient temperature. Vop is a
> coefficient. same story for temperature-coeff - it shifts resulting voltage
> curve depending on display usage invironment;
> bias - relates to waveforms for LCD segments. default is 4 and should be
> changed only if you use external oscillator for display.

Most of this could be in property description, not here.

Best regards,
Krzysztof