From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B54A71A5BA2 for ; Wed, 26 Mar 2025 09:42:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742982171; cv=none; b=Oanw5besf1WTdHMYQoCWO6DCYEoW3biTaX5h9De0CNw6TMbnwti1IHUSe+Gzvp4DJp3kXQYpU+KLRmreBUfKX953ecxK0OXE2ZaIxGdchefyhmHtM2UY2yzxo1a3CL78aCiZgfnzUUez9sk03e20DspIo9VAriky+fHECKzoRi8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742982171; c=relaxed/simple; bh=oK9w0PHHeYSQoiTSBw6ii01fBfUomipWqhc0pGmOdEs=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=SFGcBCG2m9xKrlwIB4mmDIkL+ZQzcIwK1z1uXqqGdX1SX10j68zuwr/JZnfRnwyyCg9ekR0X4UVBMKxqHzkpz9zoYEPHHdIo19JARYQCEx/a5jpn6AJ3Pvhe5M3/qkH0eM57/SooussaPwodA3OkSC5IECOnpU1hkpZXAxTicY4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=zqjeVpyr; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zqjeVpyr" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-390f5f48eafso3630728f8f.0 for ; Wed, 26 Mar 2025 02:42:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742982167; x=1743586967; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=oK9w0PHHeYSQoiTSBw6ii01fBfUomipWqhc0pGmOdEs=; b=zqjeVpyrhgQ/NXGty1PgUN3b8mwx56PVRJzxDHl4Ock4WqFoi73/XTjZ0yMA2yGROM nJHE7xet4YKfMUS4U1/t8DktJHik+cttkZ+x3CZzDXWd2wzIB/JlvsvevgJMj6NMoCrV GVw1nag1t9U5b6r2H18ZqB3HquVxcwr6sO3qS0gdw3kL+Vd/4v0fR23qVSZERRq/hjDr YFMsw4ULzqT4HhK/pRkwhtPYJW881jF+5yaeABRjneatqdKAq/TVWfSYTCgfDL7TaI0i 2l0uPOn+yEea31cxsVGhvUoO2GhphEGl9wqrQ07X5p+fTdiJxmjar+h3MHwXGb2S76+C nfRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742982167; x=1743586967; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=oK9w0PHHeYSQoiTSBw6ii01fBfUomipWqhc0pGmOdEs=; b=WJwkuzlQBZ9R+navG25gK+D3ZAyAv6sCei6mlgSNCyAIfeog7C2zp/A5JDzA7qbxII /eLJCYu74w/BRONa/N19GTPEjZSqQn9otanbjECe+UbbD0YQIRRigGHeJnnNRwxdAYle tfufaxjtkVSa9OjpQPx0QKH5AIJrBMwTITfZNCYO9KeYzz8qeKkR1OXrCreL6Mp25pYJ BNhlKyYrtl7PmIjoCLsCzaNQWQesmS4/5MBwSLyIqlUcqj6I1GNyQYGibYGHbgDObEie YiqXNaWUdfyh9wIabGq4VxBKdwzlPcNHUwFvxiR43/1lZBgbcHpavnHF9M7NxIzU9jQ/ nXMg== X-Forwarded-Encrypted: i=1; AJvYcCU3/xV94wykPNq6efKmDPjRYa27cU+74Yu6BenekWuMs0Nh7/WTdfFTF5FHwvawSQXizRuSoyWZRi6p3SU=@vger.kernel.org X-Gm-Message-State: AOJu0YzQAiDsi1YWPJn2FhMfdGEgpB0lUoJkWNetUmOdlIzhdJWOPUy/ nOcRHS+F3Bi5AT1+Df007wTu1u97CvwcFQgaiyHrlCRLJxJ8q3Zsr/RSyL94uUM= X-Gm-Gg: ASbGncsyZUFXR17Wz/rTFJVr2d1SiITmwzVB6NCoUBvnW/oxoLJG6fAe6K8XDntRUb2 6YNI0FaXNBqzwTQL7KASVpF9SYwf3WVnXZ4ONXNrIlUtyAzmSi7R+VbLH8dAUC5GIxJEWk9rBhz Bfqjx7lB8RWONJUiDBRUfZ6YFUHMDh9DmVgqtGRdFR1zRl9v7iHepjjb2zy6Q3dntmxj1r2jZ9H OET7yL+IH/XJF+Y7ZFTXngqTpiT0LiK4ZylCjFXGmo4/Yf7LVkbz4Z6obkjTpKfc567w9Qs6+Wq reaEwNo+N0fJrOjLN/ldB0O9nkm2KdOA8I0PVNSeU3NzS9adqQ== X-Google-Smtp-Source: AGHT+IFPYFB/K6M208ce6TYKpgzYD2gbxBVrga6S1jcpfDNM/sLdTcLlHMBJoMx/mLpGmNEqFLCYBQ== X-Received: by 2002:a5d:64a2:0:b0:391:2c0c:1270 with SMTP id ffacd0b85a97d-3997f8ed9d4mr17888571f8f.1.1742982166969; Wed, 26 Mar 2025 02:42:46 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3997f995778sm16406564f8f.11.2025.03.26.02.42.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Mar 2025 02:42:45 -0700 (PDT) Message-ID: <53e7fd763da3748dbc7a5205b4f93cdf9476aded.camel@linaro.org> Subject: Re: [PATCH 15/34] mfd: sec: use dev_err_probe() where appropriate From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Krzysztof Kozlowski , Lee Jones , Rob Herring , Conor Dooley , Sylwester Nawrocki , Chanwoo Choi , Alim Akhtar , Michael Turquette , Stephen Boyd , Russell King , Catalin Marinas , Will Deacon , Alexandre Belloni Cc: Peter Griffin , Tudor Ambarus , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rtc@vger.kernel.org Date: Wed, 26 Mar 2025 09:42:44 +0000 In-Reply-To: References: <20250323-s2mpg10-v1-0-d08943702707@linaro.org> <20250323-s2mpg10-v1-15-d08943702707@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.53.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-03-26 at 08:24 +0100, Krzysztof Kozlowski wrote: > On 23/03/2025 23:39, Andr=C3=A9 Draszik wrote: > > dev_err_probe() exists to simplify code and harmonise error messages, > > there's no reason not to use it here. > >=20 > > While at it, harmonise some error messages. > >=20 > > Signed-off-by: Andr=C3=A9 Draszik > Maybe such cleanups should be before you start moving the code and > splitting modules into i2c/core/acpm. Sure, I can re-order them. I didn't want the new PMIC to depend on all that cleanup, as I believe that had been previous feedback (but maybe I misremember :-), and also to avoid the new PMIC being blocked on potentially contentious earlier cleanup patches, if any. > Anyway: >=20 > Reviewed-by: Krzysztof Kozlowski Thanks! Andre'