From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 252BFC761A6 for ; Thu, 30 Mar 2023 09:35:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbjC3Je6 (ORCPT ); Thu, 30 Mar 2023 05:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjC3Je5 (ORCPT ); Thu, 30 Mar 2023 05:34:57 -0400 Received: from out30-111.freemail.mail.aliyun.com (out30-111.freemail.mail.aliyun.com [115.124.30.111]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B54D46A7F for ; Thu, 30 Mar 2023 02:34:55 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=hsiangkao@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Vf-9haW_1680168892; Received: from 30.221.133.238(mailfrom:hsiangkao@linux.alibaba.com fp:SMTPD_---0Vf-9haW_1680168892) by smtp.aliyun-inc.com; Thu, 30 Mar 2023 17:34:53 +0800 Message-ID: <53ea9c11-47f5-cadd-af38-eb7337347a2e@linux.alibaba.com> Date: Thu, 30 Mar 2023 17:34:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 1/8] erofs: move several xattr helpers into xattr.c To: Jingbo Xu , xiang@kernel.org, chao@kernel.org, huyue2@coolpad.com, linux-erofs@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org References: <20230330082910.125374-1-jefflexu@linux.alibaba.com> <20230330082910.125374-2-jefflexu@linux.alibaba.com> From: Gao Xiang In-Reply-To: <20230330082910.125374-2-jefflexu@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/3/30 16:29, Jingbo Xu wrote: > Move xattrblock_addr() and xattrblock_offset() helpers into xattr.c, > as they are not used outside of xattr.c. > > inlinexattr_header_size() has only one caller, and thus make it inlined > into the caller directly. > > Signed-off-by: Jingbo Xu Reviewed-by: Gao Xiang Thanks, Gao Xiang