From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752395AbdJSLMp (ORCPT ); Thu, 19 Oct 2017 07:12:45 -0400 Received: from mout.web.de ([217.72.192.78]:64622 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbdJSLMn (ORCPT ); Thu, 19 Oct 2017 07:12:43 -0400 Subject: Re: kernel/module: Delete an error message for a failed memory allocation in add_module_usage() To: Jessica Yu , kernel-janitors@vger.kernel.org, linux-doc@vger.kernel.org Cc: Dan Carpenter , Rusty Russell , LKML References: <20171019092943.hbghcaifwkcdsgd3@redbean> <20171019103034.kw6lthwq22vafqjx@mwanda> <20171019110246.7f5m5ossvq5c5jz7@redbean> From: SF Markus Elfring Message-ID: <53f5b946-34a2-fe06-b118-d6c563e838e0@users.sourceforge.net> Date: Thu, 19 Oct 2017 13:12:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171019110246.7f5m5ossvq5c5jz7@redbean> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:y4aKXiS3X0qPP52RRikdCqWK0PMb7LcA/chdAPkpwaC+Gd2V8e5 eilZacKyv+yJXhs9TECwAIAsY7fOvyR9yURsTn1YnM2nDzVl1oPR8OWnKherunbU4BEgQtK EED0BxFfVd0EH03YAw3aU+4v7SDM9ShvBg7n48vAsB6VtPyqoH/hEW7sOHMADw1Mar3Rfr3 tRU/vraQpNiCg9ry1/zSw== X-UI-Out-Filterresults: notjunk:1;V01:K0:I2S9QT3+zR8=:p3zrGsbzopygLceU8DuXlp e46qaraoDwDMYZpkBm9FKi80+ja2u8PEhH72Xyt5px/Sv1NWbPfXUnWULnZFlV5w4eZQ0WLGR qLH7jqxvK4YfKp7emf16YXDzBNDauDdQsJJ/dZLAsDo7YBv0zXNu5/Zmxdwui3MTQPW4KUlGq 9Q1lgya9Ky9bpB2fqme38NP2H7ISdeYMNGpJ4oznEQeRv6g7But7wR2lQ1koapJSub7iNsWJP 5W6dWpVYLX6ggvcsYHUXxDkznfACjpSr+0T1g07Za7kreozpLJVtXTDPhjIrDESDlMQ3At5Fp 2j8xSQNCqSz2VMoVjyDqmDWr9tNkG1KK7WsTLfzez/uYux1I/KsjUtE4c3jYhvXzet1qpv1vD BWaZFykNaI7cVsyFdVgjYDdgw+adjnMEWRHr0zM6pWgkJs19l4SQZ0jJqoaeZ6/yjNLeD/hW5 tZBe2jvAvrTBmLAfSf8U3ojP6/Cd3SH4hBqryrDa5H4Q9Rilws9BlFkCMORi80b1izmsyKEcJ +ctd2B/igSGCAKH1rKwyWhRamJbT0fXTplGRtqGN4jRZ5bi60D/HXPFSNbEbvHGqdf2FiCkup iqt3O66eXI1Gq4HQuB74QmINtxOmXHK/v0PVvRoO4HqUJu9rOIYUUAPtWZnljzaQLzdd7MtSo JYcQ6ZPp+Lf0E/0ObOI44dWqzwk8SQ/045jaBmUP2dj9/p+FbeV+7HUKqcAPg+lFFtGZmCgW9 hDaAiEkT8qfh4dyVowbZIPefXgCtrkD77CAPF6udcnrxQcGsIsseJwp7KfIEMVZLtkaODtYcx pWiRfpS69Y8YQrlPlyKg+wPVmYYecla+xWjuhPuqwDL9XHkYjg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> This is a small allocation so it can't fail in current kernels.  I can't >> imagine a situation where this could fail and it wasn't dead easy to >> debug.  Most modules are loaded at boot so it's not likely to fail, but >> if it did, it would be easy to reproduce.  If it's not loaded at boot >> it's probably really easy to tell which module we're loading. > > Yeah, good points. And on second thought, we normally don't print > warnings for every small alloc failure in the kernel anyway (that > would be utterly superfluous), the error code itself is sufficient. > And in the module loader this seems to be the only printk out of the > dozen alloc calls we do, so I'm OK with removing this one. Thanks for your constructive feedback. Can it help to improve the corresponding documentation for Linux programming interfaces a bit more? Regards, Markus