From: Florian Fainelli <florian.fainelli@broadcom.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, opendmb@gmail.com, nb@tipi-net.de,
bcm-kernel-feedback-list@broadcom.com, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, kudzo51@gmail.com
Subject: Re: [PATCH net-next v4 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support
Date: Fri, 20 Nov 2026 11:10:55 -0800 [thread overview]
Message-ID: <53f8b30a-99d4-47cd-9838-85aaa4da6df1@broadcom.com> (raw)
In-Reply-To: <179515311151.3136.11984816802162340674@kernel.org>
On 11/19/26 21:38, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 1
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] unimac_mdio_probe() now sets bus->read_c45/bus->write_c45 for
> every instance, including the one GENET creates from platform data.
Your analysis is correct: without a DT node nothing is masked, and
bcmgenet_mii_wait() sleeps for a timeout per frame since irq0 is only
requested in bcmgenet_open(). I'd rather not special-case that path:
- it only affects GENET probed without a DT node (ACPI/UEFI), and it is
an one-off cost at probe time, bounded to two failed C45 reads per address
- the C22 scan on that path already pays the same per-frame sleep, so
this slows an existing slow path rather than creating a new one
- C45 support is a property of the MDIO controller, not of how the
platform device was instantiated, and gating it on DT or on pdata would
make the driver's behavior depend on the firmware interface.
The commit message now says that this scan runs there and why it is
slower. If the probe time turns out to matter, the fix belongs in
bcmgenet_mii_wait(), which should poll while the interrupt is not
registered yet. That would speed up the C22 scan as well and I'd rather
send it as a separate GENET patch.
> - [Medium] The patch's own comment in unimac_mdio_addr_c45() says
> bcmgenet_mii_wait() can return 0 after timing out with MDIO_START_BUSY…
Agreed. v5 adds unimac_mdio_wait(), which calls wait_func() and then
polls MDIO_START_BUSY. Every cycle goes through it: the ADDR frame, the
RD_C45/WR_C45 data frame and the C22 read and write. MDIO_CFG is
therefore never rewritten while a frame is in flight, and the read data
is never fetched before the frame completes. The commit message explains
this.
> - [Low] unimac_mdio_resume() now takes priv->mii_bus->mdio_lock around
> unimac_mdio_clk_set(), so system resume now serializes against, and…
The commit message already said that resume takes the bus lock around
unimac_mdio_clk_set(). v5 also says that resume may now wait for an
in-flight MDIO access.
pw-bot: cr
--
Florian
next prev parent reply other threads:[~2026-11-20 19:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 0:59 [PATCH net-next v4 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-19 0:59 ` [PATCH net-next v4 1/4] net: phy: Map C45 probe read errors to -ENODEV during bus scan Florian Fainelli
2026-11-20 5:38 ` netdev-bot+sashiko
2026-11-20 19:04 ` Florian Fainelli
2026-11-19 0:59 ` [PATCH net-next v4 2/4] net: mdio: mdio-bcm-unimac: Define MDIO_OP_SHIFT Florian Fainelli
2026-11-19 0:59 ` [PATCH net-next v4 3/4] net: mdio: mdio-bcm-unimac: Poll for completion at 1us granularity Florian Fainelli
2026-11-19 0:59 ` [PATCH net-next v4 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
2026-11-20 5:38 ` netdev-bot+sashiko
2026-11-20 19:10 ` Florian Fainelli [this message]
2026-11-20 5:16 [PATCH net-next v4 0/4] net: mdio: Clause 45 support for mdio-bcm-unimac Florian Fainelli
2026-11-20 5:16 ` [PATCH net-next v4 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53f8b30a-99d4-47cd-9838-85aaa4da6df1@broadcom.com \
--to=florian.fainelli@broadcom.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=kudzo51@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®