From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1785AC54EBE for ; Fri, 13 Jan 2023 08:24:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240129AbjAMIYg (ORCPT ); Fri, 13 Jan 2023 03:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233587AbjAMIWg (ORCPT ); Fri, 13 Jan 2023 03:22:36 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBAA75C91C for ; Fri, 13 Jan 2023 00:19:56 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id i15so30181312edf.2 for ; Fri, 13 Jan 2023 00:19:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gEMfh+dF27C0xo62tkZAvzuYB0w/rh5LuxMqVXfiOP4=; b=tKEEvPGU/vILbvjEUsGKE+y58fr5B5UnoSYnuVUzJsdVIPjAhJxIjvbc4zufUR/lQr ZU5okt+/pPDgzqL42oMhc9CSMpLJupQl2+/aA5CwRMR4QBRc8YEfqPTjvmATJ01BDADi ECutv2pigAHrC6AZ4z7fcofAcPsoP/rnLT9sfxSstShgWLgqS+Jo7ig4nKnidOC0c+3V XMr1w6SInTLPGHBn2TZekNOx+ySBpR/nvtaykEhZE8n2C+A0PsbHLmRbGf2oylGcJOpv gT9ymNdsJwDuk5GZeF5JuwhrZiJyoLTqKjrrYUlyIasoHsrvL2qtMxy2ECfZsHgAVEKE W7cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gEMfh+dF27C0xo62tkZAvzuYB0w/rh5LuxMqVXfiOP4=; b=2PXTREWgqWhedIeM47LmWpgh+34HRiqVAqiaqNXW2WLDA5BVlg7LgrinP9xmDJq86e 15E9iXRbB9mMTKemR4rXq5YVKfPeTIwm8vx8oyR4o2sltvIyVluQHHJRF6djIbPvDmFI lF35FigM2Sr+swdRWgxyFQZRqpM2dELZU0BgviZWXDrZkF5e7LXiAdEVOHMskBp6s4Z8 iLYw2/4fRrrhhN/Z6Jp82ZDUlnqRn43GUdpGnqxDOQGnHgKEVImpSnZHJp2JeQ2Hu5Y2 gfOavF3Oa1+Jt1sTso68cNN+ngy9RO76mAXWhQ42JLIBPZ5cLCkFydTCdfWfT+zO+omq b1WA== X-Gm-Message-State: AFqh2kr7AMNCdBqXXWNLeQa32fmmR3YYTx4UtjBg7Pgy43JA8V93cJgs GinkRnzHGwI/TE814AVkdujULw== X-Google-Smtp-Source: AMrXdXuG+6vUC/ezf8jXIZPukwxqiok49NrKM7wXJ0H4rLQF0PxPRmIXAjqmoyXms1cRuzbpAF5QYA== X-Received: by 2002:a05:6402:128a:b0:499:bec6:f492 with SMTP id w10-20020a056402128a00b00499bec6f492mr14319415edv.36.1673597995335; Fri, 13 Jan 2023 00:19:55 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id kt7-20020a1709079d0700b007c4fbb79535sm8307824ejc.82.2023.01.13.00.19.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Jan 2023 00:19:54 -0800 (PST) Message-ID: <53fd44f1-513d-35e8-0471-854fbf2f10cd@linaro.org> Date: Fri, 13 Jan 2023 09:19:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: add display port audio Content-Language: en-US To: Judy Hsiao , Andy Gross , Douglas Anderson , Matthias Kaehlcke Cc: Bjorn Andersson , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org, Konrad Dybcio , Krzysztof Kozlowski References: <20230113062229.774871-1-judyhsiao@chromium.org> From: Krzysztof Kozlowski In-Reply-To: <20230113062229.774871-1-judyhsiao@chromium.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13/01/2023 07:22, Judy Hsiao wrote: > Add DisplayPort sound node and lpass_cpu node > in sc7280-herobrine-audio-rt5682.dtsi. This we see from diff. You should explain stuff which is not easily visible, e.g. why you are doing it, what do you want to achieve. > > Signed-off-by: Judy Hsiao > > --- > Changes Since v1: > -- Fix the commit message. > > > (no changes since v1) > > .../qcom/sc7280-herobrine-audio-rt5682.dtsi | 19 ++++++++++++++++++- > 1 file changed, 18 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > index af685bc35e10..69e7aa7b2f6c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -33,9 +33,22 @@ codec { > }; > > dai-link@1 { > - link-name = "ALC5682"; > + link-name = "DisplayPort"; This change is still not explained in commit msg. Best regards, Krzysztof