mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Kuogee Hsieh <quic_khsieh@quicinc.com>,
	dri-devel@lists.freedesktop.org, robdclark@gmail.com,
	sean@poorly.run, swboyd@chromium.org, dianders@chromium.org,
	vkoul@kernel.org, daniel@ffwll.ch, airlied@gmail.com,
	agross@kernel.org, andersson@kernel.org
Cc: quic_sbillaka@quicinc.com, marijn.suijten@somainline.org,
	freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc_config()
Date: Fri, 24 Feb 2023 23:14:52 +0200	[thread overview]
Message-ID: <54004e9c-256c-15b2-9c55-8bd88ebb0c85@linaro.org> (raw)
In-Reply-To: <21623a6d-7f83-5d2c-068c-f600a1834ac9@quicinc.com>

On 24/02/2023 23:09, Abhinav Kumar wrote:
> 
> 
> On 2/24/2023 1:04 PM, Dmitry Baryshkov wrote:
>> On 24/02/2023 21:40, Kuogee Hsieh wrote:
>>> use new introduced dpu_dsc_populate_dsc_config() to calculate
>>> and populate drm_dsc_info instead of hard code value.
>>
>> DPU is an optional component, so DSI driver should not depend on the 
>> DPU driver.
>>
> 
> Today, the implicit dependency is already there. Without the DPU DSC 
> blocks, the DSI cannot operate in compressed mode.

It can not operate, but one will compile w/o other driver.

> 
> But, from a SW standpoint I agree we can separate this.
> 
> We can move this one level up to the disp/ or msm/ folder
> 
> What do you think about that?

I think about drivers/gpu/drm/display/drm_dsc_helper.c

> -- 
With best wishes
Dmitry


  reply	other threads:[~2023-02-24 21:15 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 19:40 [RFC PATCH 0/2] Add DPU DSC helper module Kuogee Hsieh
2023-02-24 19:40 ` [RFC PATCH 1/2] drm/msm/dpu: add dsc helper functions Kuogee Hsieh
2023-02-24 21:13   ` Dmitry Baryshkov
2023-02-24 21:23     ` Abhinav Kumar
2023-02-24 21:36       ` Dmitry Baryshkov
2023-02-24 22:26         ` Abhinav Kumar
2023-02-24 23:53           ` Dmitry Baryshkov
2023-02-25  0:36             ` Abhinav Kumar
2023-02-25 15:23               ` Dmitry Baryshkov
2023-02-26  0:47                 ` Abhinav Kumar
2023-02-26 13:09                   ` Dmitry Baryshkov
2023-02-26 23:49                     ` Abhinav Kumar
2023-02-27 12:45                       ` Dmitry Baryshkov
2023-02-27 17:59                         ` Abhinav Kumar
2023-02-27 19:25                           ` Dmitry Baryshkov
2023-02-27 21:24                             ` Abhinav Kumar
2023-03-16  1:28                               ` [Freedreno] " Jessica Zhang
2023-03-16 16:03                                 ` Dmitry Baryshkov
2023-03-16 16:13                                   ` Abhinav Kumar
2023-03-16 16:23                                     ` Dmitry Baryshkov
2023-03-16 16:36                                       ` Abhinav Kumar
2023-03-16 23:40                                         ` Abhinav Kumar
2023-02-27 12:48                       ` Jani Nikula
2023-02-24 23:51     ` Kuogee Hsieh
2023-02-24 23:57       ` Dmitry Baryshkov
2023-02-26  0:16         ` Abhinav Kumar
2023-02-26 13:13           ` Dmitry Baryshkov
2023-02-27  0:15             ` Abhinav Kumar
2023-02-27 12:33               ` Dmitry Baryshkov
2023-02-24 19:40 ` [RFC PATCH 2/2] drm/msm/dsi: use new dpu_dsc_populate_dsc_config() Kuogee Hsieh
2023-02-24 21:04   ` Dmitry Baryshkov
2023-02-24 21:09     ` Abhinav Kumar
2023-02-24 21:14       ` Dmitry Baryshkov [this message]
2023-02-24 21:24         ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54004e9c-256c-15b2-9c55-8bd88ebb0c85@linaro.org \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=quic_abhinavk@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=robdclark@gmail.com \
    --cc=sean@poorly.run \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®