Re: [PATCH v3 0/4] Add Agilex5 support in SVC driver and FPGA configuration and partial reconfiguration support for Agilex5

["NG, ADRIAN HO YIN" <adrian.ho.yin.ng@altera.com>]

On 9/11/2026 9:54 PM, Dinh Nguyen wrote:
> Sorry, but I had to un-applied the firmware patches.
>
> Patch "firmware: stratix10-svc: add DMA coherent memory allocation for 
> SMMU-enabled platforms", when built by itself produces this warning:
>
> drivers/firmware/stratix10-svc.c:1112:12: warning: 
> ‘svc_setup_dma_memory’ defined but not used [-Wunused-function]
>  1112 | static int svc_setup_dma_memory(struct platform_device *pdev)
>       |            ^~~~~~~~~~~~~~~~~~~~
>
> Looks like you need to bring this function into "firmware: 
> stratix10-svc: enable Agilex5 SMMU support in probe".
>
> Please fix up and resend just the firmware patches.
Hi Dinh,

Thanks for catching that. You are right — svc_setup_dma_memory() was
unused until the probe patch, so building the DMA-allocation commit
alone triggered -Wunused-function. That split was also inert on its own
(use_dma_mem stayed false).

v4 squashes the DMA-allocation and Agilex5 probe enablement patches into
one commit, and resends the firmware patches only.

Best regards,
Adrian
>
> Thanks,
> Dinh