mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Aaron Lu <aaron.lu@intel.com>
To: Bin Gao <bin.gao@linux.intel.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, ysiyer <yegnesh.s.iyer@intel.com>,
	Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
	Bin Gao <bin.gao@intel.com>
Subject: Re: [PATCH 2/2] acpi/pmic: Add opregion driver for Intel BXT WhiskeyCove PMIC
Date: Sun, 12 Jun 2016 10:13:33 +0800	[thread overview]
Message-ID: <54020215-86ac-77be-ea4f-19941ed3a176@intel.com> (raw)
In-Reply-To: <20160611072531.GB90940@worksta>

On 06/11/2016 03:25 PM, Bin Gao wrote:
> This patch adds operation region driver for Intel BXT WhiskeyCove
> PMIC. The register mapping is done as per the BXT WC data sheet.
> 
> Signed-off-by: Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>
> Signed-off-by: Bin Gao <bin.gao@intel.com>
> ---
> +static int __init intel_bxtwc_pmic_opregion_driver_init(void)
> +{
> +	return platform_driver_register(&intel_bxtwc_pmic_opregion_driver);
> +}
> +
> +module_init(intel_bxtwc_pmic_opregion_driver_init);

Last time Paul suggests device_initcall instead of module_init here:

commit 75829dcf10862966f52716f2d67ac1c1b1eb486b
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Mon Feb 15 00:27:51 2016 -0500

    drivers/acpi: make pmic/intel_pmic_crc.c explicitly non-modular

Perhaps you should do the same.

Thanks,
Aaron

> +
> +MODULE_DESCRIPTION("BXT WhiskeyCove ACPI opregion driver");
> +MODULE_LICENSE("GPL");
> 

  reply	other threads:[~2016-06-12  2:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-11  7:25 Bin Gao
2016-06-12  2:13 ` Aaron Lu [this message]
2016-06-13 17:38   ` Bin Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54020215-86ac-77be-ea4f-19941ed3a176@intel.com \
    --to=aaron.lu@intel.com \
    --cc=ajay.thomas.david.rajamanickam@intel.com \
    --cc=bin.gao@intel.com \
    --cc=bin.gao@linux.intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=rjw@rjwysocki.net \
    --cc=yegnesh.s.iyer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome