From: Ian Abbott <abbotti@mev.co.uk>
To: Chase Southwood <chase.southwood@gmail.com>,
<gregkh@linuxfoundation.org>
Cc: <hsweeten@visionengravers.com>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: comedi: usbdux: fix more sparse endianness warnings
Date: Mon, 1 Sep 2014 10:03:27 +0100 [thread overview]
Message-ID: <5404365F.5060306@mev.co.uk> (raw)
In-Reply-To: <1409514263-15251-1-git-send-email-chase.southwood@gmail.com>
On 2014-08-31 20:44, Chase Southwood wrote:
> Sparse shows a couple of warnings like:
>
> drivers/staging/comedi/drivers/usbdux.c:889:20: warning: incorrect type in assignment (different base types)
> drivers/staging/comedi/drivers/usbdux.c:889:20: expected unsigned short [unsigned] [short] [usertype] <noident>
> drivers/staging/comedi/drivers/usbdux.c:889:20: got restricted __le16 [usertype] <noident>
>
> This is the result of a couple of calls to cpu_to_le16() being assigned to
> uint16_t typed variables. Switch the types of these variables/pointers to
> __le16 accordingly.
>
> Signed-off-by: Chase Southwood <chase.southwood@gmail.com>
> Suggested-by: Ian Abbott <abbotti@mev.co.uk>
> Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
> ---
>
> drivers/staging/comedi/drivers/usbdux.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
prev parent reply other threads:[~2014-09-01 9:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-31 19:44 Chase Southwood
2014-09-01 9:03 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5404365F.5060306@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=chase.southwood@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome