From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-188.mta1.migadu.com (out-188.mta1.migadu.com [95.215.58.188]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9F73A345CAF for ; Tue, 16 Dec 2025 14:48:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.188 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765896502; cv=none; b=bxFrYvRsgLqD9WVNqGTQhcDP4hmod3IEEnINp0jK1WUxqss5uTnDhKTMYJsa8bikG08TPPP9EpeGNrUKjj8rX8LhdVua5VduO1M55oxYe1efKey/zh2blcvwv3HPCO8EIbrpvcRrex9a8WFFCR2btJ6nImjEpImEM3gOpygUc9c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765896502; c=relaxed/simple; bh=TzHzxZtoxbC+9DYF3XhCgirxsG9smEHR7iYZ/6gtNQ0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DoNvnSldnHPMQC/bQ3djcSz7OaGeKKuXN0nmt+FIwhDJYEb4tLAQs6I0x7egYnXqDUaiNzaiIWxUNAJXTxxYDuVdwv/OJ/E39YCYmSaH7bO6Q8TllkvHJDKmnV6kbUM/G110gDPJ3AGO8X2pWeoSAM85KD74gotvqEzWcFYvZO0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=iy7oveTE; arc=none smtp.client-ip=95.215.58.188 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="iy7oveTE" Message-ID: <540737b2-f155-4c55-ab95-b18f113e0031@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1765896492; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2D/ob5yIVb7qub0SeY7blQIeUFxiZ9h57KLPeQrxZ/w=; b=iy7oveTEd8UA8a5GYnnZLI0WInS4zo1ZY/C3kCe/tTH/iv2V5fGlkFW+cGmKPtvkuIo6tu iio2LdBBgg7JjQ+NVZ6MnD2z87Kk+vp4xLR85gMQEHwARVKYb9+8I7JRYkB6ofQMZ7Gu6u YhMTfJeHRJ7Y7yv5CQBQMWd2Wsz+liQ= Date: Tue, 16 Dec 2025 09:48:00 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering To: "Gupta, Suraj" , Andrew Lunn Cc: "Pandey, Radhey Shyam" , Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , "Simek, Michal" , Leon Romanovsky References: <20250805153456.1313661-1-sean.anderson@linux.dev> <20250805153456.1313661-2-sean.anderson@linux.dev> <9572f798-d294-4f24-8acb-c7972c1db247@lunn.ch> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 12/16/25 06:53, Gupta, Suraj wrote: > [Public] > > Hi, >> -----Original Message----- >> From: Andrew Lunn >> Sent: Wednesday, August 6, 2025 2:29 AM >> To: Sean Anderson >> Cc: Pandey, Radhey Shyam ; Andrew Lunn >> ; David S . Miller ; Eric >> Dumazet ; Jakub Kicinski ; Paolo >> Abeni ; netdev@vger.kernel.org; linux-arm- >> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Greg Kroah-Hartman >> ; Simek, Michal ; >> Leon Romanovsky ; Gupta, Suraj >> Subject: Re: [PATCH net-next v4 1/7] net: axienet: Fix resource release ordering >> >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> > +static void axienet_disable_misc(void *clocks) { >> > + clk_bulk_disable_unprepare(XAE_NUM_MISC_CLOCKS, clocks); } >> > + >> >> ... >> >> > ret = devm_clk_bulk_get_optional(&pdev->dev, XAE_NUM_MISC_CLOCKS, >> lp->misc_clks); >> > if (ret) >> > - goto cleanup_clk; >> > + return dev_err_probe(&pdev->dev, ret, >> > + "could not get misc. clocks\n"); >> > >> > ret = clk_bulk_prepare_enable(XAE_NUM_MISC_CLOCKS, lp->misc_clks); >> > if (ret) >> > - goto cleanup_clk; >> > + return dev_err_probe(&pdev->dev, ret, >> > + "could not enable misc. clocks\n"); >> > + >> > + ret = devm_add_action_or_reset(&pdev->dev, axienet_disable_misc, >> > + lp->misc_clks); >> >> It seems like it would be better to add >> devm_clk_bulk_get_optional_enable(). There is already an >> devm_clk_bulk_get_all_enabled() so it does not seem like too big a step. >> >> Andrew > > We are interested in this patch to fix AXI Ethernet probe path and can collaborate on upstreaming it. Feel free to modify it as suggested by Andrew. Unfortunately I have not had time to work on this series recently and probably won't be able to return to it for another few months. --Sean