From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Dirk Brandewie <dirk.brandewie@gmail.com>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Patch Tracking <patches@linaro.org>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nishanth Menon <nm@ti.com>, Carlos Hernandez <ceh@ti.com>
Subject: Re: [PATCH V2] cpufreq: Make sure CPU is running on a freq from freq-table
Date: Wed, 27 Nov 2013 21:21:55 +0100 [thread overview]
Message-ID: <5408313.YdNvR1b3g5@vostro.rjw.lan> (raw)
In-Reply-To: <CAKohpomXk34aaG3bKX9AuOcn7ZEXcKrc858jCUhcB2bavcnarQ@mail.gmail.com>
On Wednesday, November 27, 2013 09:22:01 PM Viresh Kumar wrote:
> On 27 November 2013 19:52, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> > And here my question was: Is it safe to continue at all in that case?
>
> Hmm.. Honestly speaking I haven't thought about it earlier. And from
> the kind of inputs we got from Nishanth its not safe at all and so we
> really need a BUG_ON in this case, instead of WARN_ON.
>
> What do you say?
Yeah, BUG_ON() sounds like the right thing to do here.
I have a concern that on some systems you can't really say what frequency
you're running at the moment, however. So there should be a flag for
drivers indicating whether or not frequencies (or operation points in
general) are directly testable and the check should only be done for
the drivers with the flag set.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-11-27 20:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-25 4:23 Viresh Kumar
2013-11-25 16:38 ` Dirk Brandewie
2013-11-25 17:01 ` Viresh Kumar
2013-11-25 17:43 ` Dirk Brandewie
2013-11-25 21:13 ` Rafael J. Wysocki
2013-11-26 2:01 ` Viresh Kumar
2013-11-26 6:14 ` viresh kumar
2013-11-26 20:21 ` Rafael J. Wysocki
2013-11-27 3:01 ` Viresh Kumar
2013-11-27 14:22 ` Rafael J. Wysocki
2013-11-27 15:52 ` Viresh Kumar
2013-11-27 20:21 ` Rafael J. Wysocki [this message]
2013-11-28 3:20 ` Viresh Kumar
2013-11-28 13:09 ` Rafael J. Wysocki
2013-11-28 13:41 ` Viresh Kumar
2013-11-28 14:12 ` Rafael J. Wysocki
2013-11-28 14:14 ` Viresh Kumar
2013-11-28 20:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5408313.YdNvR1b3g5@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ceh@ti.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.brandewie@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=patches@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®