From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD0D3A8734 for ; Tue, 31 Mar 2026 10:58:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954689; cv=none; b=aHyXFz72tpDor7uxB8sFr1uO9XQ2LH0SPF9xvihXLaO5GkYs5Ly6aB3Au/DgKFGqFGkCzX5LB0wfLt1gwEw61mkIym5zlVjrpNL3eUwbCMHLMOOqvL7QqIpTpupzVesBZijcaMkuZSzXzRYbDJZcpczDYLQjPUmOo7iGGuFqaBg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774954689; c=relaxed/simple; bh=b7tq6DQtRCgmYUVhlKeubOo7PrQh/bCTQHPN69hYTiQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lpOaJuyFp4VY/XYnz+9lNFLExrM3ohJYOl/KXLCWL0LZnw7t5Lhb4iOmpzK8sjc/HTZL0vNfACQuY8fgfPZ1V4YvR/a3/l4u92XPX4SUqoqwhtUxOuacir1ic8QEeOZJwzUBjzTOXGyPJyoVuBOYn6IkxbyCi0sdgL1WrDex3Ec= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AQBPNlsL; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JyYdPamW; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AQBPNlsL"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JyYdPamW" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V6hrVj2391977 for ; Tue, 31 Mar 2026 10:58:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= rmV+CUKgpBT40E/5onUcGoi9dgiWANHHOSIdJ5YEyhw=; b=AQBPNlsL+M17kdWU 9OzHm5Su0mgOwcKoIkrtH8rVNDkcRrssNjnJrociLxXfN/H/1czPwNgO311hWLvN 1Nm8PQivx9hTwJeuw1lQf6mfkYqpshrN0cjkAZNXBrubQVT6QsX9R8TnDsgic9mT LEf08m/+az/Ln0tv0yYdZ65vULyI4njrFGKyI1FSFAwZF717gy+QgbZBckUjyDQO Px6oY/t81Vkvow3fk/pHzmFdAZQYI3id1OD1TXIRDcfvBl5LMIY+sToONTKgR8HM ZiFhJFsizyaRdkdwiVLSpIIZeMQi/gnKBlYhjHRol9AUqxScFDLsjLKv4WXrGq2C rai+cg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7ue7m67d-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 10:58:07 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-82c613194caso3984989b3a.1 for ; Tue, 31 Mar 2026 03:58:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774954686; x=1775559486; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rmV+CUKgpBT40E/5onUcGoi9dgiWANHHOSIdJ5YEyhw=; b=JyYdPamWqtxT1POtV1ZYswnG47ohhvGMMLcZTneIUyd973fS5LB//wKrNd0iEiXRCA uLc4doG4QQ4oXLL0hUcDUSMORnzBb0iqHUuU0w/P3xl0xCTH7sCLcZIIKeic7cNXy6iE 8RPcuKn4W0aoKrGuDJfPVYhGWwBD5CslHwrnc8Lkq4jDTGRwCRK8CWv+r4/Sqg/XldKj F7lBromm1OiZwLecCpqfcnSa2Zvj2vcZG0i+4SuQ0FEqlqwnxpgROQ3KcVAK5WKrllOM wHsSIHebXIgIaKvIc+gd0z7vxvF35WunYnt495bI2gns/rAX6EPo+XqVC8IyfoXe0u7t zTZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774954686; x=1775559486; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rmV+CUKgpBT40E/5onUcGoi9dgiWANHHOSIdJ5YEyhw=; b=FF+OEGaoMWEC/GMGcJ1HzdkQIaYGM3IqQZf18FKUbgcTBdvct44BY14NFC1Hk38x+E VG38lpqcoKN+UF4CLGyxfV47+dWrPumJxV9/+v4d/UoHJObSacA2n7WvxxtMQ5ZhKx1g 18CfMiXbW2P3RphJD9IdH47rkR567w74WHWVNc1XBHmeF3BV63WGdHQG4fEMI15HoR6/ z+t1NyoEZcL/PQxlxKRDapOjia/3czYNcJw0JO0QSvCH6OOki+4RTqFjD1gAFVAvRs56 LRWhSRomJnUcdaevVNRc/Quyr0OzEKgbW5gdv+YTNdapP9dNSM5yMdxMSQx/BxeKtRRG lp9A== X-Forwarded-Encrypted: i=1; AJvYcCUst4RqhrQN8sFcDU11OclVlqgr9DL66l0KRk0aw2iiaM2n5N/x0EIJRcpZnpkeoKwjX5e1NttmO5sU9Ko=@vger.kernel.org X-Gm-Message-State: AOJu0YxKjHUJViwT7PBzNQp7vkuRUyE9xYk3EXoL3Epa+nT1MT1qgiZa MwEsHUMILghIFqy23vszoPN8WRyshJxVGhf/pDKV4yVuKKf0qpblv1e199Kc7qXG/CsHzm5EYVk KIc7BNg/2ywHc6Tan9cLMBgWSzHG3ovxtLwXDszf8fVTsA0Uln9/0QdgLkUI9IXVdykc= X-Gm-Gg: ATEYQzyLp5TLA2noCHmzNPgdbYNwotm6OADBJUWCI49yvjoGKI3WPHLgYwhYF56zMNf P+J7IVFOmlZ2pspiLheoWe7sMYcx0XAeJMPb1/AJdQfC94PA0SDoXZ9/Wi7t41N+I1JFNC1T3Hl +DNGSxUl0Dqy4v2OWnFfjtqsmrIvfc+4to8n9l/RX8O2dq92VXEqGJULrqgCQis9hGqm/dXP58M rab6UFpJc4PQvEHRDAv5bgcJ/lP8nBafIkDwrGMQiaVf4mUox/PhBqTqI2F6f1+huGoXtSeNFHB O4ZVhclgQ9KbMGD9+WKzZTW76FIh/5EQTa7WYVXQgv0jgQT/uys/QoS0dwgEyyKMFDW++qBOTg6 CCV0LllDT0/NCpaCCKpIN3ceVzuKnAWieXcu8LMkzwFwIujPdOp25NQ== X-Received: by 2002:a05:6a00:2e27:b0:82a:7dfd:9757 with SMTP id d2e1a72fcca58-82c95c27e6amr14264825b3a.4.1774954686355; Tue, 31 Mar 2026 03:58:06 -0700 (PDT) X-Received: by 2002:a05:6a00:2e27:b0:82a:7dfd:9757 with SMTP id d2e1a72fcca58-82c95c27e6amr14264787b3a.4.1774954685820; Tue, 31 Mar 2026 03:58:05 -0700 (PDT) Received: from [10.217.216.47] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82ca86286dbsm10214104b3a.56.2026.03.31.03.58.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 03:58:05 -0700 (PDT) Message-ID: <5409e13e-280c-47b6-a29f-351cb609bc6f@oss.qualcomm.com> Date: Tue, 31 Mar 2026 16:27:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] clk: qcom: Add support for GXCLK for Milos To: Alexander Koskovich , Luca Weiss Cc: Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260306-milos-gxclkctl-v1-0-00b09ee159a7@fairphone.com> <20260306-milos-gxclkctl-v1-2-00b09ee159a7@fairphone.com> Content-Language: en-US From: Jagadeesh Kona In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDEwNSBTYWx0ZWRfXyRFokmxp5p0A ZnkdhPr82U7Tjp+rrgKIu+ovb91KrV+aVzXyC6SVo07XAsXPHjHqttGUiYamD+7yAy9OHtcshGG RX53pPsUyXLO7tqsDGAHPAVwfyPWQD30UmoMjF98eibdH78NX9WqapvgrJiuO4jHFBSbCogpnOB cWbMoxCDDvpDcrNl7LvCaC3wVONwZfBeEIkhNAGsIvQArO/iYGAcAsXErzezzcyqcGGCKEaadaB /UbZStTWhuMtWBE+Ns5GH6btd/FRr3K69wiFSCv3V9GBWze/JEhzIT/PWCfKmx3o8PJgig/BeDs Q83wQ51um4EnIjn8pYXSSo8J1SIJmIv5H3JAZSTHKxZ5cvEYOue+2JPxZjn6NmPg+2sIVUjhxfn kIoQ4Ngzf8ZFxGl/nmX1tuOg/bO1t+hV6D4M0aBUvSNRIXW0FOPDK+eLM0fjqBlgH3m4vcJ8aJs C5pLXk7XANNGgTnXHfA== X-Proofpoint-GUID: Cs-IjrCbjGnfKFQv28ba_THU5NUFf3XV X-Authority-Analysis: v=2.4 cv=G7sR0tk5 c=1 sm=1 tr=0 ts=69cba8bf cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=qC_FGOx9AAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=6H0WHjuAAAAA:8 a=d5075zjUzbg6PSGir3kA:9 a=QEXdDO2ut3YA:10 a=OpyuDcXvxspvyRM73sMx:22 a=fsdK_YakeE02zTmptMdW:22 a=Soq9LBFxuPC4vsCAQt-j:22 X-Proofpoint-ORIG-GUID: Cs-IjrCbjGnfKFQv28ba_THU5NUFf3XV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310105 On 3/31/2026 8:07 AM, Alexander Koskovich wrote: > On Friday, March 6th, 2026 at 8:56 AM, Luca Weiss wrote: > >> GXCLKCTL (Graphics GX Clock Controller) is a block dedicated to managing >> clocks for the GPU subsystem on GX power domain. The GX clock controller >> driver manages only the GX GDSC and the rest of the resources of the >> controller are managed by the firmware. >> >> We can use the existing kaanapali driver for Milos as well since the >> GX_CLKCTL_GX_GDSC supported by the Linux driver requires the same >> configuration. >> >> Signed-off-by: Luca Weiss >> --- >> drivers/clk/qcom/Makefile | 2 +- >> drivers/clk/qcom/gxclkctl-kaanapali.c | 1 + >> 2 files changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >> index 90ea21c3b7cf..155830140d26 100644 >> --- a/drivers/clk/qcom/Makefile >> +++ b/drivers/clk/qcom/Makefile >> @@ -182,7 +182,7 @@ obj-$(CONFIG_SM_GPUCC_8350) += gpucc-sm8350.o >> obj-$(CONFIG_SM_GPUCC_8450) += gpucc-sm8450.o >> obj-$(CONFIG_SM_GPUCC_8550) += gpucc-sm8550.o >> obj-$(CONFIG_SM_GPUCC_8650) += gpucc-sm8650.o >> -obj-$(CONFIG_SM_GPUCC_MILOS) += gpucc-milos.o >> +obj-$(CONFIG_SM_GPUCC_MILOS) += gpucc-milos.o gxclkctl-kaanapali.o >> obj-$(CONFIG_SM_LPASSCC_6115) += lpasscc-sm6115.o >> obj-$(CONFIG_SM_TCSRCC_8550) += tcsrcc-sm8550.o >> obj-$(CONFIG_SM_TCSRCC_8650) += tcsrcc-sm8650.o >> diff --git a/drivers/clk/qcom/gxclkctl-kaanapali.c b/drivers/clk/qcom/gxclkctl-kaanapali.c >> index 3ee512f34967..d3899420d6f2 100644 >> --- a/drivers/clk/qcom/gxclkctl-kaanapali.c >> +++ b/drivers/clk/qcom/gxclkctl-kaanapali.c >> @@ -54,6 +54,7 @@ static const struct qcom_cc_desc gx_clkctl_kaanapali_desc = { >> static const struct of_device_id gx_clkctl_kaanapali_match_table[] = { >> { .compatible = "qcom,glymur-gxclkctl" }, >> { .compatible = "qcom,kaanapali-gxclkctl" }, >> + { .compatible = "qcom,milos-gxclkctl" }, >> { } >> }; >> MODULE_DEVICE_TABLE(of, gx_clkctl_kaanapali_match_table); >> >> -- >> 2.53.0 >> > > Was running into gx_clkctl_gx_gdsc being stuck on when GPU was doing runtime pm > and it seems like this GDSC requires GPU_CC_GX_AHB_FF_CLK to be enabled. Though > it is already in gpu_cc_milos_critical_cbcrs, the GMU firmware appears to be > disabling it. > > Relevant downstream change: > https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/3c1f31518edb7b094b9b9285287ba49a5c9196d8 > Hi Alexander, This change was introduced as a temporary placeholder specific to downstream GPU SW & GPUCC code, to unblock the gx gdsc warnings observed during system resume. But it is not the final implementation and change was reverted later in below commit: https://git.codelinaro.org/clo/la/kernel/qcom/-/commit/11bd8d8d6f654cf156bb4fbbfe6587e0c41adc2b But you are right, gpu_cc_gx_ahb_ff_clk is indeed required for GX GDSC register access. And the actual requirement is linux GMU driver should disable the GX GDSC only in GMU recovery use case at which point the necessary clock will already be enabled by firmware. In all other cases, the GX GDSC should never be enabled/disabled from linux. In the upstream implementation of GMU driver, the GX GDSC is being enabled/disabled in every runtime resume/suspend of GMU driver which is leading to these GX GDSC warnings. Milos GPU architecture is similar to that of Pakala and similar GX GDSC warnings were reported on Pakala already[1]. Discussions are in progress with internal GPU SW team to see if GX GDSC can be handled gracefully only during GMU recovery use case and not control it in other scenarios, to avoid this issue and without impacting any other GPU use cases. [1]: https://lore.kernel.org/all/CAH2e8h4R-nF+eV+OnkSySKSY5_H-V8Ndyfhac3=VNQ-bMaBeFg@mail.gmail.com/ Thanks, Jagadeesh >> >> >