From: Nick Dyer <nick.dyer@itdev.co.uk>
To: Sjoerd Simons <sjoerd.simons@collabora.co.uk>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Subject: Re: [PATCH] Input: atmel_mxt_ts: Add of node type to the i2c table
Date: Tue, 09 Sep 2014 13:36:27 +0100 [thread overview]
Message-ID: <540EF44B.4070907@itdev.co.uk> (raw)
In-Reply-To: <1410249158-18192-1-git-send-email-sjoerd.simons@collabora.co.uk>
On 09/09/14 08:52, Sjoerd Simons wrote:
> For i2c devices in OF the modalias exposed to userspace is i2c:<node
> type>, for the Maxtouch driver this is i2c:maxtouch.
>
> Add maxtouch to the i2c id table such that userspace can correctly
> load the module for the device and drop the OF table as it's not
> needed for i2c devices.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
I've tested this and it does work. In fact, it seems that you can use
compatible = "i2c:atmel,maxtouch";
because the "atmel," is ignored in the matching.
Before I could ack this patch, we will need to update this dts file:
arch/arm/boot/dts/s5pv210-goni.dts
and this documentation file:
Documentation/devicetree/bindings/input/atmel,maxtouch.txt
thanks!
prev parent reply other threads:[~2014-09-09 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 7:52 Sjoerd Simons
2014-09-09 10:21 ` Javier Martinez Canillas
2014-09-09 10:29 ` Nick Dyer
2014-09-09 10:54 ` Sjoerd Simons
2014-09-10 9:28 ` Lee Jones
2014-09-11 8:00 ` Sjoerd Simons
2014-09-11 8:38 ` Javier Martinez Canillas
2014-09-11 9:19 ` Nick Dyer
2014-09-11 9:54 ` Javier Martinez Canillas
2014-09-11 11:08 ` Wolfram Sang
2014-09-11 11:24 ` Javier Martinez Canillas
2014-09-11 11:35 ` Wolfram Sang
2014-09-11 11:41 ` Javier Martinez Canillas
2014-09-11 12:24 ` Nick Dyer
2014-09-09 12:36 ` Nick Dyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540EF44B.4070907@itdev.co.uk \
--to=nick.dyer@itdev.co.uk \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sjoerd.simons@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome