From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 990B627057D for ; Thu, 26 Mar 2026 02:07:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774490876; cv=none; b=C0GGspltoCTSfR18u2+cOzmB7IO2cE7oX5SM2YdIRvZge07mNZ5fR/8hYhy8BALTXmQLL8HAYPmbiAJyoc84HRJV8kUl/DmMBp8u8pzuwY0iG6vKl+PfZnBNyOkmrvU0IervNOl7QczsqYgXnsAkvflSVYRNraUeQNpqak2a5ZE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774490876; c=relaxed/simple; bh=fP5ca+wleAv365iglFP1lOZ6n8fv/yloi+JcxBej+bs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FHOCgQ39yIBVc+npSBXLw4lLntCbeDOJWxoP9AYhfgVNyj+qCgAWx0tVb2y2iy8Y+mQF1S9bTj1m5eSgH2yfFgL3vjLnl8zPBgQFDJZdXV5zNr9CEgP4A+79xwhhC5sl6dHoCF2nu6pU5eydOhAFDuDKRdLGK44idyKUissF0xY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=u11lRW6y; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="u11lRW6y" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43b4f48c47cso307047f8f.0 for ; Wed, 25 Mar 2026 19:07:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1774490873; x=1775095673; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IQBV0aIbBMoDV/It9TWPuN/5h+uJKLUgF07SUqXfhYk=; b=u11lRW6yTU9igaZ2Yps0O7OWHzDAggN1vfYCEJe3jUvgAEWXFx2FLmsdAZ41cfHEEa qwUyD6/4JCm/yti5ttjf8yONy4HtY6RAj/mGsqI24HTNmoGgi7HQ8s6821i5kxU5iems eJQU6EFARhixfbBJe6zK1747JUvgpAYMfLoOEftdtW3gMVPtgMnwNnJpGgzopQBwBFiV 0N7gPVnHcAv/iAd2dIn4L2es/tfcfk9Px+0QQSRgG9/pQ28e3TU1wAbJ5DySJBDp+y3/ ucrawWKu1ShFtTQ8A0VNWj6952+tTIPBEYIFvB3YPZByWS8pg9upiTofan9Q8mBKNm79 aU+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774490873; x=1775095673; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IQBV0aIbBMoDV/It9TWPuN/5h+uJKLUgF07SUqXfhYk=; b=CXwjewZu1iHTloHvlJqI/ZQpg9poaQXW3TO1cpjYrVkZpD34Qmg0YKN9Q8J3uGW0U4 05GVasbyQJIDGgDcbbERQOmRHy7Ta5zy49949oT8Nb13Ap6ENvuknWX1CCQLHZxvnkeo oN40gAN7xEqoRZwdYzW94R4knXs0/dhFUrDO799fJjCWJsu/n8Ir/k8uf/B25pKwqYJB K/+69Hu8y4pumLm/r5myye6JlbWnS7uRIsE7xP+CtMsOalaZZq9wCnjJ64sIrBUBdXgw wwMSqwgwmSWQWNI8ulD70yRsQLiMpUKNlUxxKIMPDo9+3U1tjZkK826b2QFw737laR3q pWaw== X-Forwarded-Encrypted: i=1; AJvYcCWxKuo+qqsCw0ATXBHO+GeOzbR0REbbRQZOs6r6k8C4JUPByGcYIPS2gHLg2q+7ZmjGYmG52I7SVbY03n0=@vger.kernel.org X-Gm-Message-State: AOJu0YxDrWFyTEICoFZymNYULivfjfTOGwyGCds/cDIb+o3044Tq22pS 2B2NL8xaS/ds4gOv0Sfm33jCSOiFeMk516jCnm/ECv4cyZ2KjJ3yvTQe5GL9J8ajch0= X-Gm-Gg: ATEYQzxyYzbIKXmguMaghvH4S9lgoc0ICAMKj2aggWlnMHKx9mLAgyp3P/1qeLKzE2T dgZqt8eO1jtNF4vYL3neIDW2XfrrV+dvqUzwwAexLX+lJfdNPCZCVCp/z6QfnJNWJyyNRlNA8qq z0WuDJLGr+fj0CJXXj6xjqgwyTXAdsZ9CejJbcJzGFX/Iv18lEbeuc5PMXwnhKuiUxywuxTeYjb TmJYg/xXZoyIhC+gbMt/JSX9f61Tt9c5CVxq7SI9qZzG/NSWfuQeHPqUml7Q3zMF5H1CnT8rG4U LBchs8IKBNxCqHB7PqekLnq/zENtEuMwmhLLhBh327KzVdAYrw+XfCwEwHHeva6AY0hIsyHsq3d 6LRqE5RlxkmfwuuqNzj3pL2KJbuR5T8a6tFw6v1EF2eYFMg/kFI2g2g1CrkHxH3EfHwESmZbhjj bdV9qEdx9gHauZD1ntVu+A//n9wXXIkwwNksg= X-Received: by 2002:a5d:5d07:0:b0:439:fbbc:d593 with SMTP id ffacd0b85a97d-43b88a04ff5mr8594238f8f.27.1774490872955; Wed, 25 Mar 2026 19:07:52 -0700 (PDT) Received: from [192.168.0.35] ([109.76.163.154]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43b919e7372sm5264843f8f.34.2026.03.25.19.07.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Mar 2026 19:07:51 -0700 (PDT) Message-ID: <540c2a97-00ec-4358-855a-b238aab53860@linaro.org> Date: Thu, 26 Mar 2026 02:08:21 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v11 2/7] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints To: Vladimir Zapolskiy , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Konrad Dybcio , Bryan O'Donoghue Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Krzysztof Kozlowski , Christopher Obbard References: <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-0-5b93415be6dd@linaro.org> <20260326-b4-linux-next-25-03-13-dtsi-x1e80100-camss-v11-2-5b93415be6dd@linaro.org> <17ab70a4-1ab8-4384-8537-44dbfe31889a@linaro.org> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <17ab70a4-1ab8-4384-8537-44dbfe31889a@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 26/03/2026 01:51, Vladimir Zapolskiy wrote: > On 3/26/26 03:28, Bryan O'Donoghue wrote: >> Qualcomm CSI2 PHYs support a mode where two sensors may be attached to >> the >> one CSIPHY. >> >> When we have one endpoint we may have >> - DPHY 1, 2 or 4 data lanes + 1 clock lane >> - CPHY 3 wire data lane >> >> When we have two endpoints this indicates the special fixed combo-mode. >> - DPHY endpoint0 => 2+1 and endpoint1 => 1+1 data-lane/clock-lane >> combination. >> >> Reviewed-by: Christopher Obbard >> Signed-off-by: Bryan O'Donoghue >> --- >>   .../bindings/media/qcom,x1e80100-camss.yaml        | 69 ++++++++++++ >> ++++++++-- >>   1 file changed, 65 insertions(+), 4 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/qcom,x1e80100- >> camss.yaml b/Documentation/devicetree/bindings/media/qcom,x1e80100- >> camss.yaml >> index c17b9757b2c86..f44138f522bba 100644 >> --- a/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >> +++ b/Documentation/devicetree/bindings/media/qcom,x1e80100-camss.yaml >> @@ -148,7 +148,8 @@ properties: >>       $ref: /schemas/graph.yaml#/properties/ports >>       description: >> -      CSI input ports. >> +      CSI input ports. Supports either standard single sensor mode or >> +      Qualcomm's combo mode with one sensor in 2x1 + 1x1 data-lane, >> clock-lane mode. >>       patternProperties: >>         "^port@[0-3]$": >> @@ -156,26 +157,86 @@ properties: >>           unevaluatedProperties: false >>           description: >> -          Input port for receiving CSI data from a CSIPHY. >> +          Input port for receiving CSI data. >>           properties: >> -          endpoint: >> +          endpoint@0: >>               $ref: video-interfaces.yaml# >>               unevaluatedProperties: false >> +            description: >> +              Endpoint for receiving a single sensor input (or first >> leg of combo). >> + >>               properties: >>                 data-lanes: >>                   minItems: 1 >> -                maxItems: 4 >> +                maxItems: 4 # Base max allows 4 (for D-PHY) >> + >> +              clock-lanes: >> +                maxItems: 1 >>                 bus-type: >>                   enum: >>                     - 1 # MEDIA_BUS_TYPE_CSI2_CPHY >>                     - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >> +          endpoint@1: >> +            $ref: video-interfaces.yaml# >> +            unevaluatedProperties: false >> + >> +            description: >> +              Endpoint for receiving the second leg of a combo sensor >> input. >> + >> +            properties: >> +              data-lanes: >> +                maxItems: 1 >> + >> +              clock-lanes: >> +                maxItems: 1 >> + >> +              bus-type: >> +                const: 4 # Combo is D-PHY specific >> + > > It's unclear why both 'bus-type' and 'phys' cell argument are needed > at the same time, they are equal and thus one of two is redundant. > bus-type lives on the CAMSS controller endpoint. It tells the V4L2 fwnode parser (v4l2_fwnode_endpoint_parse) how to interpret the endpoint properties — DPHY has data-lanes + clock-lanes, CPHY has trios. PHY phandle cell lives on the phys reference. It tells the PHY driver which electrical mode to configure --- bod