From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 27A4A33E367 for ; Tue, 3 Feb 2026 12:14:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770120890; cv=none; b=s10PvjOYRSPVa/MuKsXKnFqb0/8v+hrwqcljq48vf62Pjm5AwZiGhoBMi9gH6TvGPmY9aNev5pJvsCmoLHX9RCz0jb5b7vIH8LMms98BjrkPLfx7w+x0iStpiCv+12CVs3DE/l2h3hnF92AErayoeNFNWvOuXr0mjnsnB5P4ONw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770120890; c=relaxed/simple; bh=f2jxbDBMXSZTUZA+fhe3W5fEXPcXuzuwd9OFbZFi+aQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XO6W+16zW4vhgOH79IepwI7v4aTnku+2hW9vTRcM/WltmTzP8Po1CFDEcw1GtA1YWewdDuJ0y2Q/z5ACMFp5/fPRENMhmaUdEQeKwwqFq/k6+0M+htua/NLa9vnpujovsgu99jowxt+kyi4gIrj/za7NyOxKhTUGsRGSiwrCAQU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IRKJPBxX; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hvPQWST5; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IRKJPBxX"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hvPQWST5" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6137A7N6255932 for ; Tue, 3 Feb 2026 12:14:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J0sfhluVRaK+7nfABb5VFYSmnKNequ3uhG7WHjNhsCo=; b=IRKJPBxXK21Kbtdg 7/lM3CvcoiOV5N6Q3zMnyohn3kwx45Nwd9F1+fxycsMwkP9CbVlrfYPOfJgBsS34 DHgtcsRrdnjtgC5Ux7DZX8mkCHXF+qlHIqUgsGArJCYD6Zk9YWL2Xl+R3H2sKTfc i+KJPCpNYG1kn6grtx1cGJhS9NzHpqAMX+wzBh13PSxraxGszLRQRFY4OcRHf23+ jQuD644CyFvGE1o+LEgBo5s3Gt03EumpnpU51Yo28IhOi/78biWlLJQ40y4KLhVp YCfz2ztmkcexSDWxHHRPk/7Fr8FWsPuIczzNb0wiPA3Gaqv7u1z8ftxJahWUhgbe Zc+2rA== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2v0km0nt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 12:14:48 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-8c6a182d4e1so103978985a.0 for ; Tue, 03 Feb 2026 04:14:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770120887; x=1770725687; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J0sfhluVRaK+7nfABb5VFYSmnKNequ3uhG7WHjNhsCo=; b=hvPQWST5GI7LFpa/YGhFB/XBWKmFhyr4Wm2NGt6AWavoYky00ufSrtLT93lnB4CvX3 YdMWd0F7OhBP2iy+aclF01TQGu+y1bZvmDT+5ZorMjqIoJa0lbUpSuU/ASHm0BZFCYk0 4fBrRPqWM378M36sArl8d8eHMZZbdKVP1ptbP1wxJXpffhVeuXIPUFMZGzmfc/ECqXe+ Bs06dKSZv0drsQq2WN7DP8IxWs/iPphs3eVEgHiRuBKgZoYpElRbT0wMRWWpou06+1Vp jpoR5EzoKo5V1d8fsASQUBLzpWWUu309UizSe/SR5avRY5NyUBgP1LbimMHDieE1dcEm MG7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770120887; x=1770725687; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J0sfhluVRaK+7nfABb5VFYSmnKNequ3uhG7WHjNhsCo=; b=ZI8OBAl6+uUvBBHfJUJTvELP5Eg949vTmGtsP9gPc+BoaiX4oYvmTF6SHc7vk3Ae3N hw7dJ/Mr3S67pusbu/9ItoB+yRDicv++lkrNx/pRQjB7GrO1KRbBlIA5kgCxcT5PFJoP PEucPDs6gef5JIeyQu9dvoGtikdzZfQOEN4YjxH+xocSCQoiq8rjgsRevBL4Xt5SN9BK ZnXbtEprwSuRwzDpgrmoQ265+eVt7DrXQGxGRKfRRrdvVXD990bPlzwm9P5Kf6hefmU8 a53yUrk9oCbxaCztI3fG5ZH038LF2Hj8lh4OzBGKb8X94pbct9K6IRvWHwCC7gP3/rxf zgOw== X-Forwarded-Encrypted: i=1; AJvYcCV+Xzlj3DrkxTpdnpTJbXOAuFZl/LxVLEfehTGQ8VAmq0B+zya+C6rxxWkV/s2Haxj4AoXmNHSuyuClqo8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+lF7TOOS9Ctz7rymuCTPyuiIhP2V/fWXz1ehkduVeEedEIDGU TrfW1QeJxzGpLv8TVDOgOsenjtrRqtRPlyiALVffHvKwcOSUOjN+LWPtRnaSFUuNFDsHJg49J9c 8CeEH6tBF53p4pxC+z2UUgxLAJnCYxJYx2h+YeAVlzMdyd8UWfa2UPdM+5Rvicec4jXw= X-Gm-Gg: AZuq6aK9nv4aY7X+TjxNmWk+rE94UYNbq8YPhTyzIbrw9q7gdgYS6vsLGqGk0vuDOr9 bP8QcmEZvFgNQ88uo5jvEUY9ssT/+F6li7xMFQSsQ41yeIkVqgahOYDblxUbYFi6YsnKC3TBYC2 9J+JhZP5hGPkd5l7d0Zwm3lqa+zKLxbsTbQnng29yUb/DghHpfcEo0A50c8LU51PxHW9KZY/vjI op7AssiO33vpwtUCWKs/BfoCjCuCsm8pdQv/h5XbEoLRaw4weUuXBEFFS6OhTLXXditOfnCvKhb e360/Qs9HtBXtoethcppcTzdI46/shNCpHBXqM3SLSBAZ3b2cIQw9epWmWC7rUKpTYLW5NeWgMS thKPJpfdMl0nRf73Ea1fEJLKtweG1j5igYZkFOoD4jGx2TQ091IETsUjU3gbOIZr6tRE= X-Received: by 2002:a05:620a:17aa:b0:8c6:ab77:f95e with SMTP id af79cd13be357-8c9eb352ba1mr1354436885a.11.1770120887417; Tue, 03 Feb 2026 04:14:47 -0800 (PST) X-Received: by 2002:a05:620a:17aa:b0:8c6:ab77:f95e with SMTP id af79cd13be357-8c9eb352ba1mr1354432785a.11.1770120886907; Tue, 03 Feb 2026 04:14:46 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8de8c93c11sm849299466b.28.2026.02.03.04.14.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 04:14:46 -0800 (PST) Message-ID: <540cbb53-1028-4f17-ab83-5ac4cabe3421@oss.qualcomm.com> Date: Tue, 3 Feb 2026 13:14:43 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks_on() To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-5-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202180922.1692428-5-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Reqdyltv c=1 sm=1 tr=0 ts=6981e6b8 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=qVim3Os-OfJW7Cew8TEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5NyBTYWx0ZWRfXw0wWN0GBIB/I vc2YascdmPrsgslBR7PDC5M9akQfqjU+Bsw3/vrwO1WYcvXgVG3Bf1DnGvOJ2b3iEWgioNs5Jtt /FLLIqM/JpbmnpJe2g1KMccxJST/IZuBvo/agU1TVNonnaiwT2QOy5i6arFolv39hn3L1RkTR1K zj1j+ejt+P65SD4DlgQ0IBo5oO+tPrGGpj/W2Em61kRMm1sIlKsHC3ARteuMwAeyyzN6ZZpLxyR xIiGTEhkTSq1i6NnLKsH36m/1gkmwlzDL+NlbWSwvX0/Bm5eNYy4ick1mT5oPoNQY9xDcI7JJuw 6x2lb08vEQDU0Ih+si6pmrM10XnijpjOWMJCaGC4PAAzD54eEww1ilOXJnax3D861orCuQ1Svq9 X/4oAD8nrwEJPwsQdqHV6bTEXjEBozoDbbCQGE3b/HaqiLNkXcpzQHBryMnkA6Rk/ZWxWW4OxRY JL5EPth07i0uKEdlskA== X-Proofpoint-GUID: 7KBc36NX9P4MvCLvFfNjYbNyXj32lKmR X-Proofpoint-ORIG-GUID: 7KBc36NX9P4MvCLvFfNjYbNyXj32lKmR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_03,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 malwarescore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030097 On 2/2/26 7:09 PM, Praveen Talari wrote: > Currently, core clk is handled individually in protocol drivers like > the I2C driver. Move this clock management to the common clock APIs > (geni_se_clks_on/off) that are already present in the common GENI SE > driver to maintain consistency across all protocol drivers. > > Core clk is now properly managed alongside the other clocks (se->clk > and wrapper clocks) in the fundamental clock control functions, > eliminating the need for individual protocol drivers to handle this > clock separately. > > Signed-off-by: Praveen Talari > --- It may not be obvious from the context, but this core_clk ptr is left uninitialized (because it'd only be assigned with geni_se_resources_init() introduced in the previous patch, which is not called at this point) so everything works out Reviewed-by: Konrad Dybcio Konrad