From: Florent Revest <revest@chromium.org>
To: Yonghong Song <yhs@fb.com>, bpf@vger.kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
kpsingh@chromium.org, revest@google.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/2] bpf: Add a selftest for the tracing bpf_get_socket_cookie
Date: Fri, 27 Nov 2020 10:17:31 +0100 [thread overview]
Message-ID: <540fd8fd4542c9737224a43fa4123ceb679a7b59.camel@chromium.org> (raw)
In-Reply-To: <8b0529f0-5f1e-b403-2772-7a56c44a3a55@fb.com>
On Thu, 2020-11-26 at 23:56 -0800, Yonghong Song wrote:
>
> On 11/26/20 9:02 AM, Florent Revest wrote:
> > This builds up on the existing socket cookie test which checks
> > whether
> > the bpf_get_socket_cookie helpers provide the same value in
> > cgroup/connect6 and sockops programs for a socket created by the
> > userspace part of the test.
> >
> > Adding a tracing program to the existing objects requires a
> > different
> > attachment strategy and different headers.
> >
> > Signed-off-by: Florent Revest <revest@google.com>
> > ---
> > .../selftests/bpf/progs/socket_cookie_prog.c | 41
> > ++++++++++++++++---
> > .../selftests/bpf/test_socket_cookie.c | 18 +++++---
>
> Do you think it is possible to migrate test_socket_cookie.c to
> selftests/bpf/prog_tests so it can be part of test_progs so
> it will be regularly exercised?
I suppose it's possible, I can give it a try :)
next prev parent reply other threads:[~2020-11-27 9:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 17:02 [PATCH bpf-next 1/2] bpf: Expose bpf_get_socket_cookie to tracing programs Florent Revest
2020-11-26 17:02 ` [PATCH bpf-next 2/2] bpf: Add a selftest for the tracing bpf_get_socket_cookie Florent Revest
2020-11-27 7:56 ` Yonghong Song
2020-11-27 9:17 ` Florent Revest [this message]
2020-12-02 1:01 ` Andrii Nakryiko
2020-11-27 8:08 ` [PATCH bpf-next 1/2] bpf: Expose bpf_get_socket_cookie to tracing programs Yonghong Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540fd8fd4542c9737224a43fa4123ceb679a7b59.camel@chromium.org \
--to=revest@chromium.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=revest@google.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®