From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794780235; b=qDkgNh0xe2m9D4BVNhBxhXq/eSbcyovSu36HIIYR1IaMUv3EPKLP4kWZ77chvtqiISDH rob5RuLIeMNXri/1il3NiRgS6WKOh9YNQsBPkv0jmA/NxFUFxYeDbXDRdA+NwxPoveT7F U601Q3XDMy3hk7fTOKOwcNztGA3pkSGnrpdQEv48rYX7an5BHt5svedxaULHL0DKZEHKc SuS7sVgON2JXvS3YUp04GOP3HK81TTAW8zTdXOkHqpY4onswSiLAeQlys2Do0LKsWMd4T 7umdx/2AAfIcivM8jA6+uBVGgAVshNQkIMH1l8TEOEw6wtyVaAvKWrqWMW6tOvmydHA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794780235; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:In-Reply-To: Content-Type:Content-Transfer-Encoding:X-Spamd-Result:X-Rspamd-Server: X-Rspamd-Action:X-Spam-Flag:X-Spam-Score:X-Spam-Level: X-Rspamd-Queue-Id; bh=CFjckpkKpxZQl7refnurMjE2pE+eWaaM4naABY3aji0=; b=UtfyyIDF6k/Ob3Ix7PD0D7UL4YDDJsMl2AZBQV8qQH79CxBBEVHmHJIX45V4HHcd3fYv mO2xDuxrsn8JJLCPaa3YpjlpgAgBdl8n6E9tl/FWMdV5qr4+rGkt1g9ceKem8TKqsEl8m Gz7vLxhg6Li1jg4CeriNDCBP1Uy/rsSUv25853sz0QAqZyRsKMgC9xJZ5u0UyVGdnl4xU 4tsej8lvr5G/kMTCVvcLw+kpEoLJVrjvEgTrJl6BBG4SCSPDYOz5XW6D5Dx2HisItd+BM oOofBChV6E9MA8gIFtLX2j7/i/RPhoGXL7Yea7Pp+QYEqxLqGfyYSBqDmNjh6zi6nCw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZGBkIWcO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4PQMnCTn; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZGBkIWcO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4PQMnCTn; arc=none smtp.remote-ip=195.135.223.130 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7EC26606A32F; Sun, 15 Nov 2026 22:03:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 7EC26606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZGBkIWcO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4PQMnCTn; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZGBkIWcO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=4PQMnCTn Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 33AF321E76; Sun, 15 Nov 2026 22:03:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794780232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFjckpkKpxZQl7refnurMjE2pE+eWaaM4naABY3aji0=; b=ZGBkIWcOxQJjdDqEfSg9iVP0fEIttrVsvIVsoss9fKm4l11GcJPktxSG50oAMsrtkp3cvo 6fesLoGr9nX+06DOsA6sVXYccYxDKwOCbKw8UtI4q8x3gvLOU70VaBDZvEbPMgBT+v1z3/ Ikj79aL7x81OAYkHknKK5Mh6xz8abps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794780232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFjckpkKpxZQl7refnurMjE2pE+eWaaM4naABY3aji0=; b=4PQMnCTnsDkT7rVaMOut/wKMfi9DV4yhSwE86WrI6WPRoW6YksQCEIpgq9eOIBRP+mhjnC 1zJrxQTfOr22O0AQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZGBkIWcO; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=4PQMnCTn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794780232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFjckpkKpxZQl7refnurMjE2pE+eWaaM4naABY3aji0=; b=ZGBkIWcOxQJjdDqEfSg9iVP0fEIttrVsvIVsoss9fKm4l11GcJPktxSG50oAMsrtkp3cvo 6fesLoGr9nX+06DOsA6sVXYccYxDKwOCbKw8UtI4q8x3gvLOU70VaBDZvEbPMgBT+v1z3/ Ikj79aL7x81OAYkHknKK5Mh6xz8abps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794780232; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CFjckpkKpxZQl7refnurMjE2pE+eWaaM4naABY3aji0=; b=4PQMnCTnsDkT7rVaMOut/wKMfi9DV4yhSwE86WrI6WPRoW6YksQCEIpgq9eOIBRP+mhjnC 1zJrxQTfOr22O0AQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id BAAC4134F4; Sun, 15 Nov 2026 22:03:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ut9FG0Ys+moHdAAAD6G6ig (envelope-from ); Sun, 15 Nov 2026 22:03:50 +0000 Message-ID: <5412ba3a-ff32-48e8-b5a1-d46b97cf5f8f@suse.de> Date: Sun, 15 Nov 2026 23:03:50 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/9] mm/mprotect: add MM_CP_PERM_UPGRADE To: "David Hildenbrand (Arm)" , kvm@vger.kernel.org, linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, seanjc@google.com, pbonzini@redhat.com, akpm@linux-foundation.org, peterx@redhat.com, ljs@kernel.org, imbrenda@linux.ibm.com, borntraeger@linux.ibm.com, frankja@linux.ibm.com, "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato References: <20261112142039.907090-2-clopez@suse.de> <20261112142039.907090-7-clopez@suse.de> <3314e44d-dbfe-45da-a1b0-8337784a5e86@kernel.org> Content-Language: en-US From: =?UTF-8?Q?Carlos_L=C3=B3pez?= In-Reply-To: <3314e44d-dbfe-45da-a1b0-8337784a5e86@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-13.50 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCPT_COUNT_TWELVE(0.00)[21]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,suse.de:dkim] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -13.50 X-Spam-Level: X-Rspamd-Queue-Id: 33AF321E76 On 11/13/26 7:51 PM, David Hildenbrand (Arm) wrote: >> diff --git a/mm/mprotect.c b/mm/mprotect.c >> index 84bcfe0281d3..8c0fcd10f5a3 100644 >> --- a/mm/mprotect.c >> +++ b/mm/mprotect.c >> @@ -767,6 +767,17 @@ static const struct mm_walk_ops prot_none_walk_ops = { >> .walk_lock = PGWALK_WRLOCK, >> }; >> >> +static bool vma_flags_is_perm_upgrade(vma_flags_t old_vma_flags, >> + vma_flags_t new_vma_flags) > > Two tab indent. Will fix >> +{ >> + vm_flags_t old = vma_flags_to_legacy(old_vma_flags); >> + vm_flags_t new = vma_flags_to_legacy(new_vma_flags); >> + /* VM_ACCOUNT does not affect page tables */ >> + vm_flags_t mask = VM_READ | VM_WRITE | VM_EXEC | VM_ACCOUNT; > > Why is VM_ACCOUNT a permission upgrade? At best it's "no change". > > What am I missing? It isn't, this just means to cover the case where mprotect(PROT_READ | PROT_WRITE) on a private read-only VMA sets VM_ACCOUNT as well. Without this, the change is not detected as an upgrade. > Also, what you really care about is "no permission downgrade", and "no > permission upgrade" is not the inverse of that ;) Right, I'll rename it.