mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Avi Kivity <avi@cloudius-systems.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Paul Mackerras <paulus@samba.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Stephane Eranian <eranian@google.com>,
	Jan Stancek <jstancek@redhat.com>
Subject: Re: [BUG] perf tools: Demangle kernel and kernel module symbols too
Date: Sat, 13 Sep 2014 06:34:37 +0300	[thread overview]
Message-ID: <5413BB4D.10606@cloudius-systems.com> (raw)
In-Reply-To: <20140906184631.GA6059@krava.brq.redhat.com>

On 09/06/2014 09:46 PM, Jiri Olsa wrote:
> hi,
> Jan Stancek found test 1 breakage, probably caused by following patch:
>    950b8354716e perf tools: Demangle kernel and kernel module symbols too
>
> it seems to break test 1:
> ---
> [jolsa@krava perf]$ ./perf test -v 1
>   1: vmlinux symtab matches kallsyms                        :
> --- start ---
> test child forked, pid 6288
> Looking at the vmlinux_path (6 entries long)
>
> SNIP
>
> 0xffffffff8142dba0: diff name v: event_queue virtual table k: __vt_event_queue
> 0xffffffff8142dc00: diff name v: event_dequeue virtual table k: __vt_event_dequeue
> 0xffffffff8142dd90: diff name v: event_wait::isra::::part:: virtual table k: __vt_event_wait.isra.0.part.1
> ---
>
> Avi,
> could you please update the tests/vmlinux-kallsyms.c to reflect
> the demangle change?
>
>

It's not a simple matter of updating the test: the demangler interprets 
name beginning with __vt as C++ mangles names, which of course they aren't.

The only way I see to proceed is to make the demangling optional, 
default off.

  parent reply	other threads:[~2014-09-13  3:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-06 18:46 Jiri Olsa
2014-09-12 15:22 ` Jiri Olsa
2014-09-13  3:34 ` Avi Kivity [this message]
2014-09-14  9:41   ` Peter Zijlstra
2014-09-14 17:08     ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5413BB4D.10606@cloudius-systems.com \
    --to=avi@cloudius-systems.com \
    --cc=acme@kernel.org \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=fweisbec@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=jstancek@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome