mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: <trix@redhat.com>, <davem@davemloft.net>, <kuba@kernel.org>,
	<michal.simek@xilinx.com>, <radhey.shyam.pandey@xilinx.com>,
	<gary@garyguo.net>, <rdunlap@infradead.org>, <esben@geanix.com>,
	<huangguangbin2@huawei.com>, <michael@walle.cc>,
	<moyufeng@huawei.com>, <arnd@arndb.de>,
	<chenhao288@hisilicon.com>, <andrew@lunn.ch>,
	<prabhakar.mahadev-lad.rj@bp.renesas.com>,
	<yuehaibing@huawei.com>
Cc: <netdev@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: xilinx: cleanup comments
Date: Wed, 16 Feb 2022 08:41:42 +0100	[thread overview]
Message-ID: <54168947-f587-2209-b6df-80aefb968123@xilinx.com> (raw)
In-Reply-To: <20220215190447.3030710-1-trix@redhat.com>



On 2/15/22 20:04, trix@redhat.com wrote:
> From: Tom Rix <trix@redhat.com>
> 
> Remove the second 'the'.
> Replacements:
> endiannes to endianness
> areconnected to are connected
> Mamagement to Management
> undoccumented to undocumented
> Xilink to Xilinx
> strucutre to structure
> 
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
>   drivers/net/ethernet/xilinx/Kconfig               | 2 +-
>   drivers/net/ethernet/xilinx/ll_temac.h            | 4 ++--
>   drivers/net/ethernet/xilinx/ll_temac_main.c       | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +-
>   drivers/net/ethernet/xilinx/xilinx_emaclite.c     | 2 +-
>   5 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig
> index 911b5ef9e680..0014729b8865 100644
> --- a/drivers/net/ethernet/xilinx/Kconfig
> +++ b/drivers/net/ethernet/xilinx/Kconfig
> @@ -1,6 +1,6 @@
>   # SPDX-License-Identifier: GPL-2.0-only
>   #
> -# Xilink device configuration
> +# Xilinx device configuration
>   #
>   
>   config NET_VENDOR_XILINX
> diff --git a/drivers/net/ethernet/xilinx/ll_temac.h b/drivers/net/ethernet/xilinx/ll_temac.h
> index 4a73127e10a6..ad8d29f84be6 100644
> --- a/drivers/net/ethernet/xilinx/ll_temac.h
> +++ b/drivers/net/ethernet/xilinx/ll_temac.h
> @@ -271,7 +271,7 @@ This option defaults to enabled (set) */
>   
>   #define XTE_TIE_OFFSET			0x000003A4 /* Interrupt enable */
>   
> -/**  MII Mamagement Control register (MGTCR) */
> +/**  MII Management Control register (MGTCR) */


When you touch this you should remove /** which points to kernel-doc format.

When fixed you can add my
Reviewed-by: Michal Simek <michal.simek@xilinx.com>

Thanks,
Michal

      parent reply	other threads:[~2022-02-16  7:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 19:04 trix
2022-02-15 19:10 ` Randy Dunlap
2022-02-15 20:12 ` Radhey Shyam Pandey
2022-02-16  7:41 ` Michal Simek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54168947-f587-2209-b6df-80aefb968123@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=andrew@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=chenhao288@hisilicon.com \
    --cc=davem@davemloft.net \
    --cc=esben@geanix.com \
    --cc=gary@garyguo.net \
    --cc=huangguangbin2@huawei.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=moyufeng@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=radhey.shyam.pandey@xilinx.com \
    --cc=rdunlap@infradead.org \
    --cc=trix@redhat.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®