From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95C4B30B53F for ; Tue, 23 Jun 2026 16:00:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230453; cv=none; b=S2IADYM7WghFoEUHXZrdQe4jvxZwRdQIrFJ+3IZ6egQ5Lz/6zB+u5n/QdHVUcNaWZDd19GmOCUa+utUb0vOkw5U/TDjd9kgiZZcm95fXLzytQunBbG9+vwX1A0x1nBB6NAd9+87RUO8zn8l4ULc9i8fc8ckEi7lvp+CBwrlM+mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782230453; c=relaxed/simple; bh=7zC9pfHYsK99ZK3cKWoS4K4CNMWolRWecCBf9kpQFw4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K/hg0ARURxbko4w8vfG2RL4k76KMluOtxo1SwPg+Sdjat69kfG06j8UR39EyBBxP/b3CT44z9g+n4cLD1kl42SnGwPGyfMXuMO/ziAM155M7xd7xSXP+0wJdvQqYneTo7QPxxH3zp/RF3Y6QTZmMFYyoH1ppJhK7vvzqX8EoB7s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UC5r/Aak; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Evc+/+wG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UC5r/Aak"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Evc+/+wG" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65NBXbNP1155214 for ; Tue, 23 Jun 2026 16:00:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5n9k4KX04Bj2DP4+GCETxqUImU32jpS5w2W/MeCTA4c=; b=UC5r/AakEX9tCSnR VOKYIjJdRnOiPqu6HM3UlLAsyB0P/Rxmuq7LQeKZw5mYYiSewz+euND5UpiqVO/B P6SQSUZ8QrqvO0jheBqCj5tUnBqg947l72FUOAeZYF69QvqdCmb53kSx8HTal3y8 Hg0stY5vl+KWipBw17oOAAQG3sYels5wwH028j4TaPwxfh62Mzcm5tiMeyZyKfLy a7h8QNl0aD2DMEt2vwrz0Lno0HM0/VXB1U1tSc0iIpJhNeKwfL7XBY9H0iA+thC3 0y0ewCkjOtCfNUTYuxtuoFdoytX7pSJmppCp2DPrDe76l0n1llYt9J6Oc30LvYj5 WnaBmg== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eyr28sesf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 23 Jun 2026 16:00:51 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-9156dc90fdaso95576585a.0 for ; Tue, 23 Jun 2026 09:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782230451; x=1782835251; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5n9k4KX04Bj2DP4+GCETxqUImU32jpS5w2W/MeCTA4c=; b=Evc+/+wGgNUW/AGvVYVU8Nc+EzY/x94+KGMt5XAZ50jGEdwxVfnvv8Wy1UPu5AvlJs +zfRykTm5FHdAE+nKXuUSleCDp+0vz50iHQgfSearwn7/3tW6PnY55tG+3yEV0ZJ085q 5qhd+z67OO/vRrzSeflDf9elDcan1bWHjc7JZVmUHxi5W9Sx26touy4VZitcdW8PJUFF 931nufxvn2vIudMuDXQbjPE+P/vj8go15jM9R0PI8DQPfo2TgrkFzZgdEuKIvDP8s8Vp KDPXjp2WLUGDWjr2d19DG2vM2BD5a+WPUdBWhsubXX1TFYwt3O5C0Yc4UCt7LoA25mAN 1sNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782230451; x=1782835251; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5n9k4KX04Bj2DP4+GCETxqUImU32jpS5w2W/MeCTA4c=; b=LqX4jXvRfydVcW18SYfMzKrNzGF8vJv1mxkg8XnqJ+NSODl7gyxqJgLfThgfyOGKlG Fim1/2WpxKxRnMQVKD5iGPh4NBHBfc9NFeNingx1Zf25ewbCKlHQg+4bPstIvKB229Yh 9TlOoCCabq7/RrvsV3wFJ4kHnY20TllSuBF1B6V0/4jVPw3hvww9XpQ8viu2cUys3lyS rpQyDvhD0MVcYcrdKeLGiuhQLpu8ssiusKeXl9r64Z4BBUNCM5ShUIuRfByQXBA/TB6d T3aTK5f4CdKTyvQR89PzV3NFvmEGqVhT5aj3rgOaMA64EHZ5QyDYsnsEhNbpq52xZF+a ySxw== X-Forwarded-Encrypted: i=1; AFNElJ+Nuza3g2QYWdhinxxL6XwrjWRRZeCgRKzsCXid1eYCou1BxADb7MsI16LHXvk9c+ZKirZ6N1dkeXEBaiw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+e4EkgtRxN1zOMc5ilmVvMNCo7lHgPXl437w9W1AsDkbk+uj+ UqCc966lrB93SLGKyrGP9ZoL1K6MXOS2z5/0dRtF/9Vseuwj1JIugHfrWqxReMDnwejcXygiWz6 dnj+NiC7+1oXRNa0XgegsPotdCvRBLUfXOiuG7+gmSqG0FNTfcLp8fGlc6F0L0MRTGMM= X-Gm-Gg: AfdE7cnxuX92AkP6ZC//9qraus1U9xWjyf97IDR1BhpRRn4gbi+NaZYGY0wzlycEGl5 GOnfBWJGJFnUCQ12eNrm07aBuuLPQRYQc6WAdE6EVlwdCIZsPpksix4izKeGaHBysOZ269U3Vbh VyLZLI7cZt5aWPNyFydK6X7l0f81KYPnJjMXQRE/cmX5RKq6g3at78r3G4X0mnF1+Z2Zka7KuJ/ gGSQ9e28x9tglvkIHn1Qkrfbada7EVRaFxut1T0C31Ff/RjDbfprhvXjwnVN/BZ7UQDYWEh0D8G steklnAlmkWHSldwxBVkNF737qG87h38ALNbZQG9t/czuWWYHFhPB/UBG9IzG7xQNworeOYdya2 tliMJXA0e7SliVOC5SyzvWL9PpHQls84VScg= X-Received: by 2002:a05:622a:24e:b0:517:76dd:4c2a with SMTP id d75a77b69052e-51a4f4e1e4dmr56837351cf.7.1782230449864; Tue, 23 Jun 2026 09:00:49 -0700 (PDT) X-Received: by 2002:a05:622a:24e:b0:517:76dd:4c2a with SMTP id d75a77b69052e-51a4f4e1e4dmr56836611cf.7.1782230449107; Tue, 23 Jun 2026 09:00:49 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c0c5e497e88sm550111866b.11.2026.06.23.09.00.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Jun 2026 09:00:48 -0700 (PDT) Message-ID: <5417d960-85ee-4e56-8121-959b01511285@oss.qualcomm.com> Date: Tue, 23 Jun 2026 18:00:46 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] iommu/qcom: Fix missing pm_runtime_disable() in qcom_iommu_device_remove() To: Mukesh Ojha , Rob Clark , Will Deacon , "Joerg Roedel (AMD)" Cc: Robin Murphy , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260623122034.1166295-1-mukesh.ojha@oss.qualcomm.com> <20260623122034.1166295-3-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260623122034.1166295-3-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjIzMDEzMSBTYWx0ZWRfX7eVTRgzHi6eH SX+yPIMj57vlLsIBCqMYZKBPMU0RvgVWjU/lTM7Hpu+sBq8fVuR3JcnFV/6bdPU47unt3vyD43g Arw3WcvbZ9LEkUEN9fnc7P8TfsX/4o4= X-Authority-Analysis: v=2.4 cv=b4KCJNGx c=1 sm=1 tr=0 ts=6a3aadb3 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=CVC24o2f5RenLrmZXHoA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: ADoxzPjzCROjXQ3OeRbxmKtyqd-rzWMv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjIzMDEzMSBTYWx0ZWRfX9HslyXfr71Bc /HnFNWSOd61mYAf4iLoxkuPU0G81ndMVJdTJdhYDCwLChToaaDDLFkT37YrFFNI9RvnXKEhjy5W bA+JHLPqUkxJhlaBTUdEE8R4Pn8YqHa7OrzwUYMVdxpbDPtjxQkLZHNg0cSj99WlRhag05uQNRx 80SWuUVLEq72XP7TcZlAAusEAtX/+Fs9ZzUDnHPbeT8BP2iSoBIDLMd7Xo6krJ8UNJle/kks+e5 TxPRUZ+K2oEancljxVzo7vtuddcPVP9gG6lRgqmKjYK3l46EbJwGP4J9AVGz42/MwmlbNLRn7Ps 35/c5lQinSgU2k7w7PjHkXkqwXCahTNnorF17We+6Rb0t0laD6Yz0GInCJORxFBodHG6Up/PPc2 1yDFAMVrvVWMNDHX1tQjyRN5OkQqjRS+UBkppnvgsMYVtmapFsVLdVbZm6N1cokg6eMpEFwy3Z9 VRvxpq4SfcsOow8Ucjw== X-Proofpoint-ORIG-GUID: ADoxzPjzCROjXQ3OeRbxmKtyqd-rzWMv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-23_03,2026-06-23_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 phishscore=0 priorityscore=1501 clxscore=1015 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606230131 On 6/23/26 2:20 PM, Mukesh Ojha wrote: > qcom_iommu_device_probe() calls pm_runtime_enable() but > qcom_iommu_device_remove() only calls pm_runtime_force_suspend() without > a matching pm_runtime_disable(). This leaves runtime PM enabled after the > driver unbinds, which can cause issues on rebind or if any code races to > resume the device after removal. > > Add pm_runtime_disable() in the remove path to balance the enable in probe. > > Signed-off-by: Mukesh Ojha > --- > drivers/iommu/arm/arm-smmu/qcom_iommu.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/arm/arm-smmu/qcom_iommu.c b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > index 09f2ee6be988..cb43276f4a39 100644 > --- a/drivers/iommu/arm/arm-smmu/qcom_iommu.c > +++ b/drivers/iommu/arm/arm-smmu/qcom_iommu.c > @@ -878,6 +878,7 @@ static void qcom_iommu_device_remove(struct platform_device *pdev) > struct qcom_iommu_dev *qcom_iommu = platform_get_drvdata(pdev); > > pm_runtime_force_suspend(&pdev->dev); > + pm_runtime_disable(&pdev->dev); devm_ would be neater Konrad