From: "Jan Beulich" <JBeulich@suse.com>
To: "David Vrabel" <david.vrabel@citrix.com>
Cc: "xen-devel" <xen-devel@lists.xenproject.org>,
<boris.ostrovsky@oracle.com>, <konrad.wilk@oracle.com>,
"Juergen Gross" <JGross@suse.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH V2 3/3] xen: eliminate scalability issues from initial mapping setup
Date: Wed, 17 Sep 2014 15:17:15 +0100 [thread overview]
Message-ID: <5419B40B0200007800035B09@mail.emea.novell.com> (raw)
In-Reply-To: <54199589.9040703@citrix.com>
>>> On 17.09.14 at 16:07, <david.vrabel@citrix.com> wrote:
> On 17/09/14 05:12, Juergen Gross wrote:
>> +static void __init xen_cleanmfnmap(unsigned long vaddr)
>> +{
>> + unsigned long va = vaddr & PMD_MASK;
>> + unsigned long pa;
>> + pgd_t *pgd = pgd_offset_k(va);
>> + pud_t *pud_page = pud_offset(pgd, 0);
>> + pud_t *pud;
>> + pmd_t *pmd;
>> + pte_t *pte;
>> + unsigned int i;
>> +
>> + set_pgd(pgd, __pgd(0));
>> + do {
>> + pud = pud_page + pud_index(va);
>> + if (pud_none(*pud)) {
>> + va += PUD_SIZE;
>> + } else if (pud_large(*pud)) {
>> + pa = pud_val(*pud) & PHYSICAL_PAGE_MASK;
>> + xen_free_ro_pages(pa, PUD_SIZE);
>> + va += PUD_SIZE;
>
> Are you missing a ClearPagePinned(..) here?
No, this is a 1Gb data page, not a page table one.
Jan
next prev parent reply other threads:[~2014-09-17 14:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 4:12 [PATCH V2 0/3] xen: remove some memory limits from pv-domains Juergen Gross
2014-09-17 4:12 ` [PATCH V2 1/3] xen: sync some headers with xen tree Juergen Gross
2014-09-17 4:12 ` [PATCH V2 2/3] xen: eliminate scalability issues from initrd handling Juergen Gross
2014-09-17 13:45 ` [Xen-devel] " David Vrabel
2014-09-17 14:01 ` Juergen Gross
2014-09-17 4:12 ` [PATCH V2 3/3] xen: eliminate scalability issues from initial mapping setup Juergen Gross
2014-09-17 14:07 ` [Xen-devel] " David Vrabel
2014-09-17 14:17 ` Jan Beulich [this message]
2014-09-17 14:20 ` Juergen Gross
2014-09-17 14:42 ` David Vrabel
2014-09-17 14:47 ` Juergen Gross
2014-09-17 14:43 ` [PATCH V2 0/3] xen: remove some memory limits from pv-domains David Vrabel
2014-09-17 14:48 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5419B40B0200007800035B09@mail.emea.novell.com \
--to=jbeulich@suse.com \
--cc=JGross@suse.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®