From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755895AbaIRNZz (ORCPT ); Thu, 18 Sep 2014 09:25:55 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:36244 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755174AbaIRNZx (ORCPT ); Thu, 18 Sep 2014 09:25:53 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: caesar.wang@rock-chips.com X-FST-TO: cjf@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: caesar.wang@rock-chips.com X-UNIQUE-TAG: <53de90bd064087a09dccfcf28550d12a> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <541ADD58.7070901@rock-chips.com> Date: Thu, 18 Sep 2014 21:25:44 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Tomeu Vizoso CC: heiko@sntech.de, rui.zhang@intel.com, edubezval@gmail.com, Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-pm@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, huangtao@rock-chips.com, cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org, dmitry.torokhov@gmail.com, addy.ke@rock-chips.com, zyf@rock-chips.com, cjf@rock-chips.com Subject: Re: [PATCH v5 2/4] dt-bindings: document Rockchip thermal References: <1410926353-15674-1-git-send-email-caesar.wang@rock-chips.com> <1410926353-15674-3-git-send-email-caesar.wang@rock-chips.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tomeu, 在 2014年09月18日 17:27, Tomeu Vizoso 写道: > On 17 September 2014 05:59, Caesar Wang wrote: >> This add the necessary binding documentation for the thermal >> found on Rockchip SoCs > Hi Caesar, > > is there any reason to not use the existing thermal bindings? You can > find a description in > Documentation/devicetree/bindings/thermal/thermal.txt and example code > in omap, or in the patches for Tegra recently posted by Mikko > Perttunen. > > Regards, > > Tomeu Why should I use the existing thermal bindings? I believe omap,tegar and rockchip are the three seperate thermals driver. So far, I submitted the series Patchs for rockchip thermal. > >> Signed-off-by: zhaoyifeng >> Signed-off-by: Caesar Wang >> --- >> .../bindings/thermal/rockchip-thermal.txt | 41 ++++++++++++++++++++++ >> 1 file changed, 41 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> >> diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> new file mode 100644 >> index 0000000..6fc8bc3 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt >> @@ -0,0 +1,41 @@ >> +* Temperature Sensor ADC (TSADC) on rockchip SoCs >> + >> +Required properties: >> +- compatible: "rockchip,rk3288-tsadc" >> +- reg: physical base address of the controller and length of memory mapped >> + region. >> +- interrupts: The interrupt number to the cpu. The interrupt specifier format >> + depends on the interrupt controller. >> +- clocks: Must contain an entry for each entry in clock-names. >> +- clock-names: Shall be "tsadc" for the converter-clock, and "apb_pclk" for >> + the peripheral clock. >> +- num-trips: number of total trip points, this is required, set it 0 if none, >> + if greater than 0, the following properties must be defined; >> +- tripN-temp: temperature of trip point N, should be in ascending order; >> +- tripN-type: type of trip point N, should be one of "active" "passive" "hot" >> + "critical"; >> +- tripN-cdev-num: number of the cooling devices which can be bound to trip >> + point N, this is required if trip point N is defined, set it 0 if none, >> + otherwise the following cooling device names must be defined; >> +- tripN-cdev-nameM: name of the No. M cooling device of trip point N; >> + >> +Example: >> +tsadc: tsadc@ff280000 { >> + compatible = "rockchip,rk3288-tsadc"; >> + reg = <0xff280000 0x100>; >> + interrupts = ; >> + clocks = <&cru SCLK_TSADC>, <&cru PCLK_TSADC>; >> + clock-names = "tsadc", "apb_pclk"; >> + >> + num-trips = <2>; >> + >> + trip0-temp = <80>; >> + trip0-type = "passive"; >> + trip0-cdev-num = <1>; >> + trip0-cdev-name0 = "thermal-cpufreq-0"; >> + >> + trip1-temp = <100>; >> + trip1-type = "critical"; >> + trip1-cdev-num = <1>; >> + trip1-cdev-name0 = "thermal-cpufreq-0"; >> +}; >> -- >> 1.9.1 >> >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-pm" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- Best regards, Caesar