From: Dave Hansen <dave@sr71.net>
To: linux-kernel@vger.kernel.org
Cc: dave.hansen@linux.intel.com, a.p.zijlstra@chello.nl,
mingo@kernel.org, hpa@linux.intel.com, brice.goglin@gmail.com,
bp@alien8.de
Subject: Re: [PATCH] x86: new topology for multi-NUMA-node CPUs
Date: Thu, 18 Sep 2014 14:57:39 -0700 [thread overview]
Message-ID: <541B5553.8070206@sr71.net> (raw)
In-Reply-To: <20140918193334.C065EBCE@viggo.jf.intel.com>
On 09/18/2014 12:33 PM, Dave Hansen wrote:
> @@ -410,6 +442,8 @@ void set_cpu_sibling_map(int cpu)
> } else if (i != cpu && !c->booted_cores)
> c->booted_cores = cpu_data(i).booted_cores;
> }
> + if (match_mc(c, o) == !topology_same_node(c, o))
> + primarily_use_numa_for_topology();
> }
> }
I went to test this on some more systems. The "== !" above should be a
"!=". The test is meant to see if a CPU pair is in the same mc group,
but not in the same node.
I'll fix it in the next version.
next prev parent reply other threads:[~2014-09-18 21:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 19:33 Dave Hansen
2014-09-18 20:49 ` Peter Zijlstra
2014-09-18 21:57 ` Dave Hansen [this message]
2014-09-19 11:45 ` Karel Zak
2014-09-19 18:15 ` Dave Hansen
2014-09-22 7:43 ` Karel Zak
2014-09-21 17:56 ` Brice Goglin
2014-09-24 14:58 ` [tip:sched/core] x86, sched: Add " tip-bot for Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=541B5553.8070206@sr71.net \
--to=dave@sr71.net \
--cc=a.p.zijlstra@chello.nl \
--cc=bp@alien8.de \
--cc=brice.goglin@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome