mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg KH <greg@kroah.com>,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] asm/uapi: Add definition of TIOC[SG]RS485
Date: Thu, 18 Sep 2014 21:59:58 -0700	[thread overview]
Message-ID: <541BB84E.5030705@roeck-us.net> (raw)
In-Reply-To: <1411022745-6198-1-git-send-email-ricardo.ribalda@gmail.com>

On 09/17/2014 11:45 PM, Ricardo Ribalda Delgado wrote:
> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add
> support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on
> all the archs. Unfortunaltely the definition of TIOCSRS485 and

s/Unfortunaltely/Unfortunately/

> TIOCGRS485 was missing on the ioctls.h file
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>

Otherwise

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>   arch/alpha/include/uapi/asm/ioctls.h | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/alpha/include/uapi/asm/ioctls.h b/arch/alpha/include/uapi/asm/ioctls.h
> index 92c557b..f30c94a 100644
> --- a/arch/alpha/include/uapi/asm/ioctls.h
> +++ b/arch/alpha/include/uapi/asm/ioctls.h
> @@ -90,6 +90,8 @@
>   #define TIOCSBRK	0x5427  /* BSD compatibility */
>   #define TIOCCBRK	0x5428  /* BSD compatibility */
>   #define TIOCGSID	0x5429  /* Return the session ID of FD */
> +#define TIOCGRS485	_IOR('T', 0x2E, struct serial_rs485)
> +#define TIOCSRS485	_IOWR('T', 0x2F, struct serial_rs485)
>   #define TIOCGPTN	_IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */
>   #define TIOCSPTLCK	_IOW('T',0x31, int)  /* Lock/unlock Pty */
>   #define TIOCGDEV	_IOR('T',0x32, unsigned int) /* Get primary device node of /dev/console */
>


      reply	other threads:[~2014-09-19  5:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-18  6:45 Ricardo Ribalda Delgado
2014-09-19  4:59 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541BB84E.5030705@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=greg@kroah.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=ricardo.ribalda@gmail.com \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome